From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0DDF33A71F for ; Thu, 18 Dec 2025 13:48:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766065710; cv=none; b=dyDMRAvP6JehgZtD2Jne3SgUP7fe9RT3IgEQx5haFptAKld/ko9YsxJTZCcq+skqNmvN9vOFbr0HSbPGWyd7xt8cM5muqwuW1g/QMs6KujamuLcu5U+8quPaGCGBpCeIZh5+6EgR793wSCQSpsFHLcaqAJyDV35wwEkbwOVlSmw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766065710; c=relaxed/simple; bh=ZnIegsC3Gyy9VFNbUZxdrDxtSveJ4mNx7L3shQp8w14=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=jK22gc7tHEdW1wRc6uGnRkRiOmbLbDBBexA4CJqXKOCgYSJMCjWCIINsfhWVlOSRCnRc7sCKHzLBVuWbrNTZ7hc4+Cfsmlzo/PQGfqXTCRT0BWxqamyETClIebB6Pyz3nqPx35sK833DHUkhNqqOZLnRT9R2ZVFOb9T1sCcavNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QvcZr9B/; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QvcZr9B/" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-42fbad1fa90so585284f8f.0 for ; Thu, 18 Dec 2025 05:48:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766065707; x=1766670507; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=+RKDiQXHaclpMfqjcaOyio0I5Z0xDgJAm3l0KAwmXfA=; b=QvcZr9B/ycXV90oodOexmLIuPm8SWcsSW2T4RAsXs2ERsrHs5rRsPQzr1y4NXPCoLS pOo99kTfMkbXHlROAN7Cy7AKrOvb0Y7YEqdkgOtTyLPcc6NMRC7Q+6Gv30D+rFBJwlTd xzEMZNnoMHUOSe5PSTEZ/DFI3yRUJ+agTSRLOHiPPlmF4p5ICg0jr2zqtM7T7IZg1DH7 yOWztXG9akESOSMRI4+XRS6t6N3m1qhqIKc+x6rb1f74hR70qQNZ9u0Qd3R6MZkQX6BF X3HhNWObG6PHHP50finHZFVpHYAkQewl8dT0wCkzqADHkqM5LTdmfENTpncuaP5qYDVI YWTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766065707; x=1766670507; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+RKDiQXHaclpMfqjcaOyio0I5Z0xDgJAm3l0KAwmXfA=; b=wonwucoya4ew73DQpoq42ir6Gd35gisH723uJ2Nx8f+3+CHPUn1EsepwCKjZRO6QOh uqSlwL3pvgsPEtivw/+/e9R7VX3Lm3s5SfDbELbA3qSQw+wHVOQvqEEX14SbYDQ0CVGg CrS8bFsdrD3eXXXbRKLTBmrlcRAx1aFl2NbcFQ7L/exZTBaNL9xZazjmN5N8fsqdmSkc r6zwwf8b7HlHQ6Hn6oXwKUpjvEAhy8yoXciv5cvT8zphIZqybASxibYbSLSlhdX/hh3z QMqVEbWp1OH9+qCdMy2YvnXEdeRKarcgykuK8woWf7ed6/EsX0OsU9TZk75TBrmqbKhF Kchw== X-Forwarded-Encrypted: i=1; AJvYcCVvj9ppZr2UWs5IcuWIrIXsPBlgF8NyB1mV1XJYuyo+iplDOrCk7aXAyt/KnBjEeR92pQPjwY4sH49eW5o=@vger.kernel.org X-Gm-Message-State: AOJu0YwtqFcJsxJ3pzN044tC+LpHaxjd6hEYP3ZJcfMOzABeH5vV9dls 8lg+IN2fOdGCgPhbosWNlmmhbIGWxXi7b1BUJrW4qhyV4AAkCiF0gqtL X-Gm-Gg: AY/fxX7AE7hWYKYlHkrkkndvwCsKJ4OW3T3CP8pkBakodJSwO9MS47ZPgQh06nlb8qX lkEab1aHRMzE1OKdHKgO7e/7XyTBMUyuvanmP1bZxYxIIscIgWdH8C6QLOfn2T9ftMcXBkVWDCW wfPxCdEkQF/BzW3CV99Pn97sQpBscRTyFoeGgjBPwg7tTFZbhYLf/AlCU7ygtBkC4lorYZlJNlI v3Pbf9+rOoXiH9/1TfOnAHVWuGJJP/QLWcbcroQf7SVc4RWLzrIc5JyHKSiYUCymmnUeMugZPga 54VLXeShwL19lJM5yQLsRpPdfddRy6erPYb69oksX/J11tYBbT60+w0bU4k20u8PE/S7UEeni2N SyJ/gl++y7zHEQ2ckqUoPunz8+Eii2+6bXkm1rQ7SFgK3yuvIqP7cJzyGKY3EOMHYyHfaSXd63K er4SnG+7JokSQ= X-Google-Smtp-Source: AGHT+IHxI4NcgLibs10P8ERS3NVgrM2LIUaADcTQVD2Njbb3HrKZvZOwi8s+0QzT7KTYaYP7ns5RbQ== X-Received: by 2002:a05:6000:3111:b0:430:fcac:24ba with SMTP id ffacd0b85a97d-430fcac2aa2mr16838373f8f.36.1766065706795; Thu, 18 Dec 2025 05:48:26 -0800 (PST) Received: from [10.5.0.2] ([45.94.208.108]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43244934cf5sm5193168f8f.1.2025.12.18.05.48.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 05:48:26 -0800 (PST) Message-ID: <88efd2784c9fce72e432a59a03472bb4441e975b.camel@gmail.com> Subject: Re: [PATCH 2/2] iio: adc: ad9467: make iio backend optional From: Nuno =?ISO-8859-1?Q?S=E1?= To: Tomas Melin , Michael Hennerich , Nuno Sa , Lars-Peter Clausen , Jonathan Cameron , David Lechner , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 18 Dec 2025 13:49:07 +0000 In-Reply-To: <20251216-b4-ad9467-optional-backend-v1-2-83e61531ef4d@vaisala.com> References: <20251216-b4-ad9467-optional-backend-v1-0-83e61531ef4d@vaisala.com> <20251216-b4-ad9467-optional-backend-v1-2-83e61531ef4d@vaisala.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2025-12-16 at 11:40 +0000, Tomas Melin wrote: > Not all users can or want to use the device with an iio-backend. > For these users, let the driver work in standalone mode, not coupled > to the backend or the services it provides. >=20 > Signed-off-by: Tomas Melin > --- > =C2=A0drivers/iio/adc/ad9467.c | 37 +++++++++++++++++++++++++------------ > =C2=A01 file changed, 25 insertions(+), 12 deletions(-) >=20 > diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c > index 60fc3361b2689a4c38287c613ef93fe00338e5fa..37b8f88da6681d44f3fbbb6c8= c171ae7117b9090 100644 > --- a/drivers/iio/adc/ad9467.c > +++ b/drivers/iio/adc/ad9467.c > @@ -1000,6 +1000,9 @@ static int ad9467_update_scan_mode(struct iio_dev *= indio_dev, > =C2=A0 unsigned int c; > =C2=A0 int ret; > =C2=A0 > + if (!st->back) > + return -EOPNOTSUPP; > + Let's not add the buffering interface if we can't control it. Having it just to return error does not make sense to me. This means yet an= other info: https://elixir.bootlin.com/linux/v6.18.1/source/drivers/iio/adc/ad9467.c#L9= 16 Also the channel definition should not have the scan index. But, given that= the IIO device won't have any buffer I think there's no way to reach ad9467_update_scan_mo= de() (unless I'm missing something). Still, while I understand that updating the channels to not include the sca= n_index is very cumbersome, having a new iio_info with no .update_scan_mode() is trivial an= d make things more clear and explicit. - Nuno S=C3=A1