From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17B13C7EE37 for ; Fri, 9 Jun 2023 07:52:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239312AbjFIHwX (ORCPT ); Fri, 9 Jun 2023 03:52:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239479AbjFIHwC (ORCPT ); Fri, 9 Jun 2023 03:52:02 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19EBC3C0F; Fri, 9 Jun 2023 00:51:20 -0700 (PDT) Received: from [IPV6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab] (unknown [IPv6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 0362E6606F2A; Fri, 9 Jun 2023 08:51:17 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1686297078; bh=gET5+wLpIL9IzLnk5TgUuGrRAUjK20F8Y3m38Tws6Is=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=S1ooMctYRZn1jRx0gvlWhXL/zZS7WZHs5NjTzOtAz20TLcOI7MvBI54Xx2CpFTh9u hLCBr+g2ulHDGGkArNCn3yaUFfLu2LJjjOKjM3iqWu9KuPeVYmpvCgZpK89J6tlr+X Z+N/U1yKX9TSFO2zmc279KreqI1Lg1mvlLxwusSsO+j6ZH9w5cfo2KckHRMQ+diJke AnyNEtQw+C8erxUblmkPv1ouJl4yRJkVSQXYZGNAuvtae2hqFyjw69xohcGRE56mM3 4l3em+6M84SNOcvGF2z0HUuCar0H2JYftb8k7YAk2pFl0JiDJG+y0Qee0qcDJDfFXp ZJZl6bAxFq0Bw== Message-ID: <88f37d33-6545-d307-17a9-896e86d0ed50@collabora.com> Date: Fri, 9 Jun 2023 09:51:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v3 3/8] dt-bindings: leds: leds-mt6323: Support WLED output Content-Language: en-US To: Krzysztof Kozlowski , pavel@ucw.cz Cc: lee@kernel.org, sean.wang@mediatek.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20230601110813.2373764-1-angelogioacchino.delregno@collabora.com> <20230601110813.2373764-4-angelogioacchino.delregno@collabora.com> <75d78713-fc8f-24a9-a422-2b4d57c5d488@linaro.org> From: AngeloGioacchino Del Regno In-Reply-To: <75d78713-fc8f-24a9-a422-2b4d57c5d488@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 02/06/23 10:32, Krzysztof Kozlowski ha scritto: > On 01/06/2023 13:08, AngeloGioacchino Del Regno wrote: >> Some PMICs have a separated WLED string output: add a property >> `mediatek,is-wled` to indicate which LED string is a WLED. >> >> Signed-off-by: AngeloGioacchino Del Regno >> --- >> Documentation/devicetree/bindings/leds/leds-mt6323.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-mt6323.txt b/Documentation/devicetree/bindings/leds/leds-mt6323.txt >> index 052dccb8f2ce..904b2222a5fe 100644 >> --- a/Documentation/devicetree/bindings/leds/leds-mt6323.txt >> +++ b/Documentation/devicetree/bindings/leds/leds-mt6323.txt >> @@ -30,6 +30,7 @@ Optional properties for the LED child node: >> - label : See Documentation/devicetree/bindings/leds/common.txt >> - linux,default-trigger : See Documentation/devicetree/bindings/leds/common.txt >> - default-state: See Documentation/devicetree/bindings/leds/common.txt >> +- mediatek,is-wled: LED string is connected to WLED output > > Why would it matter to what the output is connected to? When this property is present, the MT6323 LEDs are managed through different hardware registers which are specific to WLEDs: if we have no indication of whether this is a WLED or a LED, we would program the wrong registers. P.S.: Sorry for the very late reply > > Best regards, > Krzysztof > >