mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Brijesh Singh <brijesh.singh@amd.com>,
	Janakarajan Natarajan <Janakarajan.Natarajan@amd.com>,
	x86@kernel.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Radim Krcmar <rkrcmar@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
	Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH v2] x86/kvm/Kconfig: Ensure CRYPTO_DEV_CCP_DD state at minimum matches KVM_AMD
Date: Sun, 15 Jul 2018 17:36:34 +0200	[thread overview]
Message-ID: <88f6ee88-7374-0b8f-ec67-4cb04da4f136@redhat.com> (raw)
In-Reply-To: <d884aed7-6c64-5e83-243b-e6ca6be543a0@amd.com>

On 02/07/2018 18:34, Brijesh Singh wrote:
> 
> 
> On 06/27/2018 11:30 AM, Janakarajan Natarajan wrote:
>> Prevent a config where KVM_AMD=y and CRYPTO_DEV_CCP_DD=m thereby ensuring
>> that AMD Secure Processor device driver will be built-in when KVM_AMD is
>> also built-in.
>>
>> v1->v2:
>> * Removed usage of 'imply' Kconfig option.
>> * Change patch commit message.
>>
>> Fixes: 505c9e94d832 ("KVM: x86: prefer "depends on" to "select" for SEV")
>>
>> Cc: <stable@vger.kernel.org> # 4.16.x
>> Signed-off-by: Janakarajan Natarajan <Janakarajan.Natarajan@amd.com>
>> ---
> 
> Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>
> 
> 
>>   arch/x86/kvm/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
>> index 92fd433..1bbec38 100644
>> --- a/arch/x86/kvm/Kconfig
>> +++ b/arch/x86/kvm/Kconfig
>> @@ -85,7 +85,7 @@ config KVM_AMD_SEV
>>       def_bool y
>>       bool "AMD Secure Encrypted Virtualization (SEV) support"
>>       depends on KVM_AMD && X86_64
>> -    depends on CRYPTO_DEV_CCP && CRYPTO_DEV_CCP_DD && CRYPTO_DEV_SP_PSP
>> +    depends on CRYPTO_DEV_SP_PSP && !(KVM_AMD=y && CRYPTO_DEV_CCP_DD=m)
>>       ---help---
>>       Provides support for launching Encrypted VMs on AMD processors.
>>  

Queued, thanks.

Paolo

      reply	other threads:[~2018-07-15 15:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27 16:30 Janakarajan Natarajan
2018-07-02 16:34 ` Brijesh Singh
2018-07-15 15:36   ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88f6ee88-7374-0b8f-ec67-4cb04da4f136@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=Janakarajan.Natarajan@amd.com \
    --cc=bp@suse.de \
    --cc=brijesh.singh@amd.com \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome