From: Bart Van Assche <bvanassche@acm.org>
To: XueBing Chen <chenxb_99091@126.com>,
jejb@linux.ibm.com, aacraid@microsemi.com,
martin.petersen@oracle.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: aacraid: Clean up errors in commsup.c
Date: Thu, 11 Jan 2024 09:33:24 -0800 [thread overview]
Message-ID: <89041392-c747-4aa8-875d-38d3dc892ffa@acm.org> (raw)
In-Reply-To: <20240111113240.15985-1-chenxb_99091@126.com>
On 1/11/24 03:32, XueBing Chen wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: spaces required around that '<' (ctx:VxV)
> ERROR: "foo * bar" should be "foo *bar"
>
> Signed-off-by: XueBing Chen <chenxb_99091@126.com>
> ---
> drivers/scsi/aacraid/commsup.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
> index 25cee03d7f97..865316ba3c19 100644
> --- a/drivers/scsi/aacraid/commsup.c
> +++ b/drivers/scsi/aacraid/commsup.c
> @@ -129,7 +129,7 @@ void aac_fib_vector_assign(struct aac_dev *dev)
> * fib area, the unmapped fib data and also the free list
> */
>
> -int aac_fib_setup(struct aac_dev * dev)
> +int aac_fib_setup(struct aac_dev *dev)
> {
> struct fib *fibptr;
> struct hw_fib *hw_fib;
> @@ -144,7 +144,7 @@ int aac_fib_setup(struct aac_dev * dev)
> if (dev->comm_interface != AAC_COMM_MESSAGE_TYPE3)
> dev->init->r7.max_io_commands = cpu_to_le32(max_cmds);
> }
> - if (i<0)
> + if (i < 0)
> return -ENOMEM;
>
> memset(dev->hw_fib_va, 0,
checkpatch is for checking patches before these are submitted and should not
be run on code that has already been merged into the kernel tree.
Bart.
prev parent reply other threads:[~2024-01-11 17:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 11:32 XueBing Chen
2024-01-11 17:33 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89041392-c747-4aa8-875d-38d3dc892ffa@acm.org \
--to=bvanassche@acm.org \
--cc=aacraid@microsemi.com \
--cc=chenxb_99091@126.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®