From: Anshuman Khandual <anshuman.khandual@arm.com>
To: linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com
Cc: Sami Mujawar <sami.mujawar@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mike Leach <mike.leach@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
coresight@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 1/4] arm_pmu: acpi: Refactor arm_spe_acpi_register_device()
Date: Thu, 3 Aug 2023 11:43:27 +0530 [thread overview]
Message-ID: <89058c7c-1fed-60ea-7233-04187772a931@arm.com> (raw)
In-Reply-To: <20230803055652.1322801-2-anshuman.khandual@arm.com>
On 8/3/23 11:26, Anshuman Khandual wrote:
> + /*
> + * Sanity check all the GICC tables for the same interrupt
> + * number. For now, only support homogeneous ACPI machines.
> + */
> + for_each_possible_cpu(cpu) {
> + struct acpi_madt_generic_interrupt *gicc;
> +
> + gicc = acpi_cpu_get_madt_gicc(cpu);
> + if (gicc->header.length < len)
> + return gsi ? -ENXIO : 0;
> +
> + this_gsi = parse_gsi(gicc);
> + if (!this_gsi)
> + return gsi ? -ENXIO : 0;
Hello Will,
Moved parse_gsi() return code checking to its original place just to
make it similar in semantics to existing 'gicc->header.length check'.
If 'gsi' is valid i.e atleast a single cpu has been probed, return
-ENXIO indicating mismatch, otherwise just return 0.
- Anshuman
next prev parent reply other threads:[~2023-08-03 6:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 5:56 [PATCH V3 0/4] coresight: trbe: Enable ACPI based devices Anshuman Khandual
2023-08-03 5:56 ` [PATCH V3 1/4] arm_pmu: acpi: Refactor arm_spe_acpi_register_device() Anshuman Khandual
2023-08-03 6:13 ` Anshuman Khandual [this message]
2023-08-04 16:39 ` Will Deacon
2023-08-07 5:33 ` Anshuman Khandual
2023-08-08 13:21 ` Will Deacon
2023-08-09 7:01 ` Anshuman Khandual
2023-08-03 5:56 ` [PATCH V3 2/4] arm_pmu: acpi: Add a representative platform device for TRBE Anshuman Khandual
2023-08-03 9:14 ` Yicong Yang
2023-08-04 9:34 ` Anshuman Khandual
2023-08-04 10:01 ` Anshuman Khandual
2023-08-03 5:56 ` [PATCH V3 3/4] coresight: trbe: Add a representative coresight_platform_data " Anshuman Khandual
2023-08-03 13:55 ` Suzuki K Poulose
2023-08-04 9:18 ` Anshuman Khandual
2023-08-04 10:04 ` Suzuki K Poulose
2023-08-03 5:56 ` [PATCH V3 4/4] coresight: trbe: Enable ACPI based TRBE devices Anshuman Khandual
2023-08-07 4:43 ` Anshuman Khandual
2023-08-07 11:37 ` Suzuki K Poulose
2023-08-07 11:58 ` Anshuman Khandual
2023-08-13 21:43 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89058c7c-1fed-60ea-7233-04187772a931@arm.com \
--to=anshuman.khandual@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=catalin.marinas@arm.com \
--cc=coresight@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=sami.mujawar@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®