mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: arch/parisc/kernel/setup.c:64 setup_cmdline() warn: inconsistent indenting
Date: Wed, 16 Nov 2022 21:53:09 +0100	[thread overview]
Message-ID: <8905cecd-e5e0-f7aa-59bf-7083c4859820@gmx.de> (raw)
In-Reply-To: <202211170149.PzIstxxm-lkp@intel.com>

On 11/16/22 18:48, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   59d0d52c30d4991ac4b329f049cc37118e00f5b0
> commit: 5f7ee6e37a3cadefe45378c17c4285fa41141d92 parisc: Autodetect default output device and set console= kernel parameter
> date:   10 months ago
> config: parisc-randconfig-m041-20221116
> compiler: hppa-linux-gcc (GCC) 12.1.0
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
>
> smatch warnings:
> arch/parisc/kernel/setup.c:64 setup_cmdline() warn: inconsistent indenting

Fixed now in for-next.

Thanks.
Helge


> vim +64 arch/parisc/kernel/setup.c
>
>      47
>      48	void __init setup_cmdline(char **cmdline_p)
>      49	{
>      50		extern unsigned int boot_args[];
>      51		char *p;
>      52
>      53		/* Collect stuff passed in from the boot loader */
>      54
>      55		/* boot_args[0] is free-mem start, boot_args[1] is ptr to command line */
>      56		if (boot_args[0] < 64) {
>      57			/* called from hpux boot loader */
>      58			boot_command_line[0] = '\0';
>      59		} else {
>      60			strscpy(boot_command_line, (char *)__va(boot_args[1]),
>      61				COMMAND_LINE_SIZE);
>      62
>      63		/* autodetect console type (if not done by palo yet) */
>    > 64		p = boot_command_line;
>      65		if (!str_has_prefix(p, "console=") && !strstr(p, " console=")) {
>      66			strlcat(p, " console=", COMMAND_LINE_SIZE);
>      67			if (PAGE0->mem_cons.cl_class == CL_DUPLEX)
>      68				strlcat(p, "ttyS0", COMMAND_LINE_SIZE);
>      69			else
>      70				strlcat(p, "tty0", COMMAND_LINE_SIZE);
>      71		}
>      72
>


  reply	other threads:[~2022-11-16 20:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 17:48 kernel test robot
2022-11-16 20:53 ` Helge Deller [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-11-17  6:46 kernel test robot
2022-01-26  7:08 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8905cecd-e5e0-f7aa-59bf-7083c4859820@gmx.de \
    --to=deller@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®