From: "Ju, Seokmann" <Seokmann.Ju@lsil.com>
To: "James Bottomley" <James.Bottomley@SteelEye.com>
Cc: <vvs@sw.ru>, <akpm@osdl.org>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"Patro, Sumant" <Sumant.Patro@engenio.com>,
"Yang, Bo" <Bo.Yang@engenio.com>
Subject: RE: [PATCH 1/3] scsi : megaraid_{mm,mbox}: 64-bit DMA capabilitychecker
Date: Thu, 10 Aug 2006 08:55:19 -0600 [thread overview]
Message-ID: <890BF3111FB9484E9526987D912B261932E331@NAMAIL3.ad.lsil.com> (raw)
Hi,
Friday, July 28, 2006 2:21 PM, James Bottomley wrote:
> I'll fix it up this time, but in future could you trailing whitespace
> check your patches? (git will do this for you).
I have one clarification.
When will be these patches merged into scsi-misc tree?
I've seen them merged into -mm tree.
I have another patch to create, which tree should I against for it?
Seokmann
> -----Original Message-----
> From: James Bottomley [mailto:James.Bottomley@SteelEye.com]
> Sent: Friday, July 28, 2006 2:21 PM
> To: Ju, Seokmann
> Cc: vvs@sw.ru; akpm@osdl.org; linux-scsi@vger.kernel.org;
> linux-kernel@vger.kernel.org; Patro, Sumant; Yang, Bo
> Subject: Re: [PATCH 1/3] scsi : megaraid_{mm,mbox}: 64-bit
> DMA capabilitychecker
>
> On Tue, 2006-07-25 at 08:44 -0600, Ju, Seokmann wrote:
> > This patch contains
> > - a fix for 64-bit DMA capability check in
> megaraid_{mm,mbox} driver.
> > - includes changes (going back to 32-bit DMA mask if 64-bit DMA mask
> > failes) suggested by James with previous patch.
> > - addition of SATA 150-4/6 as commented by Vasily Averin.
>
> Warning: trailing whitespace in lines 885,889 of
> drivers/scsi/megaraid/megaraid_mbox.c
> Warning: trailing whitespace in lines
> 13,15,16,19,21,22,26,27,29,31,33,37,39,46 of
> Documentation/scsi/ChangeLog.megaraid
>
> I'll fix it up this time, but in future could you trailing whitespace
> check your patches? (git will do this for you).
>
> Also, when you do a git workflow, the body of the email becomes the
> commit message, so things like this
>
> > This is a third patch which follows prevous two patches ([PATCH 1/3]
> > and
> > [PATCH 2/3]).
>
> while no doubt being useful to the members of linux-scsi who are
> actually unable to count aren't actually useful in commit messages.
>
> James
>
>
>
next reply other threads:[~2006-08-10 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-10 14:55 Ju, Seokmann [this message]
2006-08-10 15:09 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=890BF3111FB9484E9526987D912B261932E331@NAMAIL3.ad.lsil.com \
--to=seokmann.ju@lsil.com \
--cc=Bo.Yang@engenio.com \
--cc=James.Bottomley@SteelEye.com \
--cc=Sumant.Patro@engenio.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=vvs@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®