From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=158.69.130.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795105505; b=n9CXS1BZUXODczeNOEGbKNedb5lwAXBVB4DhgTK/lkgcXwPtjw2DkJyI7Pp4rSOofwK5 z1ijc8nXFQeiZ0jxHaA26LhyBhXWh2gyjJ2lSfI2t67K27zasHazhm6hL/Z41ANCpdWnw FPYWTQ90Rtmsw1NpsPjRPaejuDWlpMGb7Apk/kmAjhmGb1sw7fs0tnq4bLTdFvlxcXhAD hZVl8viXvbLEgJ+S+NP5u+YlLf3PQlSjozEvQhANeKnXsyr9DsY3wThUsecnu8ejWofvs YS87H1I6H5k0OoKtw1FFb8WiJ7vlyxA+zbQUEIfH75yTAicYayGWFXMhYofBM+GWMLw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795105505; h=DMARC-Filter:DKIM-Signature:Received:From:To:Cc:Subject:Date: Message-Id:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=ecolJmUIVAvJpPgaxFVFIXgCSCdtlmKz+g0qabV5LGI=; b=j202PZeicK8YolATLdngFFjnOGRyvJcuRdEjN2WGnLQnfsLHgvZ+m1su2FDQFlqsUNt0 oQpW6gObsSj/znjTUKd5eINDoClQbCMhNFctU6NMbq250be+f1wO1ZYLPm6XunkNCbvTp DuXjk3fADDjf6UpwXyNYsQr7bnJmtPMN4LdrAiw4NMfkfh3r1jsJioN0Mtl6KxAO6YdNq l9aLYvIzZ4SC3ajbbXOn9G2wvoH6DCrMDCpss+6N/w7sF5kHjY2tC5cdQr6JU3YNuRmo9 rTeQAM4NOOHn2CA299dJbJlQBvrx1H1cQXe3jKCpYbQ2+MNLwPWfZ3BJoN8tvG7IEGA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=smtpout1 header.b=oVDaeVxg; arc=none smtp.remote-ip=158.69.130.18 Received: from smtpout.efficios.com (smtpout.efficios.com [158.69.130.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39E7C60A2609; Thu, 19 Nov 2026 16:25:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 39E7C60A2609 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=smtpout1 header.b=oVDaeVxg DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=smtpout1; t=1795105503; bh=ecolJmUIVAvJpPgaxFVFIXgCSCdtlmKz+g0qabV5LGI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oVDaeVxgBqDytaDqWG5VZK13DZZFhAitlQu7Gv0FLeMl+dlNMknbGF2Mwdvhe9SmD fmRjG34lsDv5F7t4KxmwoTpr/GEzSMs2PCru7f0978DNyJ/0gqwDxOMmUh9u5owcKu cqS24+e3ifB8vmiV9LEUpmafH9de6F4DyeCUFSq95H1W6IFb3WhqDi9nEIKd0Zzoqp U5pgnTXzlKjLgTBDRS7+2F9Yi59O5ni8RQ2Pi56KG4kudpCmeQdLFMuaH7Kk0Q05Ky 46BwJKfZ2DIHjNan9gnqVGQGznFP/9mqnqg88sv64F+/ksVGCm8eWs4U2mh3p9Nx5L lhXP5sCag8iLQ== Received: from thinkos.internal.efficios.com (mtl.efficios.com [216.120.195.104]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4jVkMg59PRzTpk; Thu, 19 Nov 2026 11:25:03 -0500 (EST) From: Mathieu Desnoyers To: juri.lelli@redhat.com, peterz@infradead.org, mingo@redhat.com, vincent.guittot@linaro.org Cc: Mathieu Desnoyers , tglx@kernel.org, will@kernel.org, boqun@kernel.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, kprateek.nayak@amd.com, luca.abeni@santannapisa.it, mathieu.poirier@linaro.org, longman@redhat.com, ridong.chen@linux.dev, tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com, shuah@kernel.org, bigeasy@linutronix.de, clrkwllms@kernel.org, parri.andrea@gmail.com, m.szyprowski@samsung.com, kayracizmeci@gmail.com, weihengqiuu@gmail.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rt-devel@lists.linux.dev, stable@vger.kernel.org Subject: [RESEND PATCH v4 11/17] sched/deadline: Release the bandwidth of a task that leaves the class asleep Date: Thu, 19 Nov 2026 11:24:51 -0500 Message-Id: <890f50eb9b802f09440aa1a4ef17abc7bda8ca68.1795105408.git.mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A task that leaves SCHED_DEADLINE while it is not queued can keep its bandwidth in total_bw until the next rebuild of the root domains. Repeated, this fills total_bw up to the admission limit. Then sched_setattr(SCHED_DEADLINE) and CPU offlining fail with EBUSY. A task that leaves the class keeps its bandwidth until its 0-lag time. Releasing it earlier would allow temporary overloads. For a queued task, switched_from_dl() calls task_non_contending(). It releases the bandwidth if the 0-lag time is past. Otherwise it arms the inactive timer, which releases it then. For a task that is not queued, switched_from_dl() relies on the timer armed when the task blocked. But the timer is not always pending when the task leaves the class: - The task blocked after its 0-lag time. The timer was not armed. - The timer fired while the task was still in the class. It only removed running_bw. - The task was woken up on another CPU and is not enqueued there yet. The wakeup cancelled the timer. - The task came back to the class asleep. switched_to_dl() cancelled the timer. Then nothing releases total_bw. Fix this in switched_from_dl(). For a task that is not queued and has no timer pending, call task_non_contending(), as for a queued task. It arms the timer if the 0-lag time is ahead. Otherwise it releases the bandwidth now and clears the parameters, as inactive_task_timer() does. Clearing the parameters keeps later paths from releasing the bandwidth again: - A timer handler that already started finds a dl_bw of 0. - The deboost of a later priority inheritance boost finds no parameters. An owner that the task boosts as a waiter can find the parameters cleared too. "sched/deadline: Do not replenish a boost from cleared parameters" handles this, so a backport needs it first. Without it, the owner's CPU can lock up as soon as the waiter leaves the class. Before this patch, a task that left the class asleep kept its parameters. That hid a bug of the rtmutex chain walk. The walk can stop before the end of a chain. An owner then keeps as its donor a deadline waiter that left the class. With this patch, the parameters of that donor are cleared. Until the owner unlocks, each refill gives it no runtime and a deadline of about now. This is the bail-out of "sched/deadline: Do not replenish a boost from cleared parameters". Other deadline tasks keep their bandwidth, but run late. Real-time and fair tasks on that CPU could starve. The pi_chain_top_moves case of a later series has the steps. With this patch, the case fails in every run. It passes on v7.4-rc2. Two rtmutex fixes of that series make it pass with this patch. Juri Lelli's first fix, since dropped from tip, released the bandwidth here without clearing dl_bw. The bandwidth of a boosted task was then released twice. Juri Lelli suggested the call to task_non_contending() in review. The Sashiko AI review of this series found the two cases with the 0-lag time ahead. deadline_switch_test, added later in this series, tests the release in asleep_round_trip. Fixes: 209a0cbda7a0 ("sched/deadline: Improve the tracking of active utilization") Reported-by: Tejun Heo Closes: https://lore.kernel.org/all/2b5fb3f22bca6aa383be8f4781923392@kernel.org/ Signed-off-by: Mathieu Desnoyers Reviewed-by: Juri Lelli Cc: stable@vger.kernel.org Link: https://lore.kernel.org/all/20261103-b4-sched-dl-bw-fixes-v1-2-dd761fe005b4@redhat.com/ --- kernel/sched/deadline.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 5e4aff28e9bc..bdeb2ecc9255 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -3620,6 +3620,14 @@ static void switched_from_dl(struct rq *rq, struct task_struct *p) if (p->dl.dl_non_contending) sub_running_bw(&p->dl, &rq->dl); sub_rq_bw(&p->dl, &rq->dl); + /* + * Without an armed timer, nothing releases total_bw. Do as for + * a queued task: arm the timer if the 0-lag time is ahead, or + * release the bandwidth and clear the parameters now. Call + * task_non_contending() after sub_rq_bw(), which needs dl_bw. + */ + if (!p->dl.dl_non_contending) + task_non_contending(&p->dl, false); } /* -- 2.47.3