From: "Juan A. Suárez" <jasuarez@igalia.com>
To: Colin Ian King <colin.i.king@gmail.com>,
Emma Anholt <emma@anholt.net>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, Melissa Wen <mwen@igalia.com>,
dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/v3d: Fix null pointer dereference of pointer perfmon
Date: Mon, 25 Apr 2022 09:10:17 +0200 [thread overview]
Message-ID: <890f6416ab37e40c929d95a8b4dcc8feb3dfb4d1.camel@igalia.com> (raw)
In-Reply-To: <20220424183512.1365683-1-colin.i.king@gmail.com>
On Sun, 2022-04-24 at 19:35 +0100, Colin Ian King wrote:
> In the unlikely event that pointer perfmon is null the WARN_ON return
> path
> occurs after the pointer has already been deferenced. Fix this by
> only
> dereferencing perfmon after it has been null checked.
>
Good catch!
Reviewed-by: Juan A. Suarez <jasuarez@igalia.com>
J.A.
next prev parent reply other threads:[~2022-04-25 7:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-24 18:35 Colin Ian King
2022-04-25 7:10 ` Juan A. Suárez [this message]
2022-04-26 12:58 ` Melissa Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=890f6416ab37e40c929d95a8b4dcc8feb3dfb4d1.camel@igalia.com \
--to=jasuarez@igalia.com \
--cc=airlied@linux.ie \
--cc=colin.i.king@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mwen@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®