From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751010AbdALLcA (ORCPT ); Thu, 12 Jan 2017 06:32:00 -0500 Received: from foss.arm.com ([217.140.101.70]:43886 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbdALLb7 (ORCPT ); Thu, 12 Jan 2017 06:31:59 -0500 Subject: Re: [RFC PATCH 09/10] drivers/perf: Add support for ARMv8.2 Statistical Profiling Extension To: Kim Phillips , Will Deacon References: <1483467027-14547-1-git-send-email-will.deacon@arm.com> <1483467027-14547-10-git-send-email-will.deacon@arm.com> <20170110160419.4cc3d61c9d652e5d5da13f15@arm.com> Cc: linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, alex.bennee@linaro.org, christoffer.dall@linaro.org, tglx@linutronix.de, peterz@infradead.org, alexander.shishkin@linux.intel.com, robh@kernel.org, suzuki.poulose@arm.com, pawel.moll@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, linux-kernel@vger.kernel.org From: Marc Zyngier Organization: ARM Ltd Message-ID: <891006af-9b82-59e8-b91e-ccf1399726a0@arm.com> Date: Thu, 12 Jan 2017 11:31:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170110160419.4cc3d61c9d652e5d5da13f15@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/01/17 22:04, Kim Phillips wrote: > On Tue, 3 Jan 2017 18:10:26 +0000 > Will Deacon wrote: > >> +#define DRVNAME "arm_spe_pmu" > > Based on Intel naming "intel_pt" and "intel_bts', I had expected > "arm-spe" as the universal basename for SPE. I don't really care about > whether '_pmu' is included, but it's yet another naming inconsistency we > have with coresight's "cs_etm" (the other being prefixed with "arm_"). > > Also, nit, since I don't know why perf userspace tools can't handle > dashes in PMU names (commit 3d1ff755e367 "arm: perf: clean up PMU > names" doesn't say), can we at least start to use dashes in our > filenames? arm-spe-pmu.c is easier to type than arm_spe_pmu.c. Fortunately, not everyone is using a UK/US keyboard... ;-) Thanks, M. -- Jazz is not dead. It just smells funny...