From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1B667080D for ; Wed, 24 Jun 2026 11:00:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782298833; cv=none; b=ThShGDNw42JgMCd502bEzx5YNmLZrZ2Y7KBRvmlNSsC0JdIDjEYc6HWl+TCkr1/aZYAviOAYwQ6aJPjKVE4R/1LD+GUkWf3reUAJ3SpssKJBOiVFVod+JBnyAJB6jh27MJG6s3aWXTAq3GTc+i1TetREwUWyD+C0eTugrxfS/Og= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782298833; c=relaxed/simple; bh=uPbUn6actKKkvsdui2PhPU5T7wXetEBaeMWfS73GncM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qn3cy3YPW1bGVw6Ep0syC1jFbFO+PMHoqWJfWt73h5bmD1NlxnLEBqGgkQbls2c58F7VXxENuICZoQq4JuBFkEieBoAe2pc8kD+HUHoJEshvrorTKpk1af8UaFJ/uLC9GgnGXZG4zWTujPWBcAo95vc1AzJybiB18UBMpsjkUGQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ojvBR0YY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NNFAYYnr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ojvBR0YY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NNFAYYnr" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65OANlJx2586229 for ; Wed, 24 Jun 2026 11:00:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Uc5Cj3yh7udwhNMcfVCvV98vfUFOng4oy8Pby1IpcrI=; b=ojvBR0YYRIqoisgZ LolSuv3sxSulWt0/PlHffbvHZNPMOvzl6uaQvSENxe2gKHIknb0uRsPzqvTktD3F Md/8KexnuF8wcacC4NJxsELoZOvL93xExCYB8kzKxlfVFskj97feDBemUxUMkKG8 bpANkRKvRtMx6JQygc4X0wy2DAMDxV2BBpluW2BZSSdykIa+zcl/c6QAdyvB3vFh xiYAgg83WnQsKtvS6dtRRrRd1efrkgjiKCRoZXQPKNqu1xzSdb91KbfJs1aXGx6L 6GS/cOfoB27X5rK2N6bEC3rZZdLm1eI4AfbLr9H51NxaCDx+3Z+7zSCC4nxE0LW+ R6pjCw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f05aq9vbb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Jun 2026 11:00:31 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51968526a68so1840261cf.1 for ; Wed, 24 Jun 2026 04:00:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782298830; x=1782903630; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Uc5Cj3yh7udwhNMcfVCvV98vfUFOng4oy8Pby1IpcrI=; b=NNFAYYnrQm62P3H4RlEpAHJXlBGE704xS9IzxvdXAjkMMyUTETNV86tnMCHJD3PpyP l1LsJMfMPVqzBhAoaaeUdameK14D7fIuL+KFXSoCHkOzdmPx9y6tLLsUVhah96dMPsjt cWrXOX0IS2EdvslDnCqgCW3P/OLoKzUkebXGg3pWMc+nUmEFJQtizqr/v4dAsIgyM5dB 0he5uVfdWVX9lyNuoNq9Rz5spOr2MygCYa2W+5w+IfLfhQSaWt9uxszfREQa5SDhRT4u uEi2u6i2JcBHjb+eOAyvIdd2MZTRR56ysfvbu8euej7Turz/8egMm+eQymrb5514odT8 5rhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782298830; x=1782903630; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Uc5Cj3yh7udwhNMcfVCvV98vfUFOng4oy8Pby1IpcrI=; b=jPnjdARLIGt65fIRO4zxFZMQs8/2zOD0oumm9PXxUQnrlSiphOePZolpozQduHzXOs qNqO6FBebueiWKfLm3RxlH+aVu/7bmOa/77dPSvpbmA+3AYDMJdxvztXsnKgcl9iHjpG a6Ho4H2hHCVaeq+W3B8rx4xaG5tiOAsxFYnpXIhhvn5DxUA4Xjtb93hCM1sPwZ5NSscM T7iCczAxJB3t8zA2RmRTpwr6a5gMTy6UNm5woIMb6J23mukC/H960ZKvRSDYITeNVw/4 mtfoQY84QaKoSN/T1KbCeiAR3QRaKbE9LQLFknsAWDugpbJZGcRkTDgKORgFcJnp1Coe +F1w== X-Forwarded-Encrypted: i=1; AFNElJ9tv+2SuDyHHEYFuDnKLOWIRzqvRCwCEP3YMkC8TMnp0yaIzRnK9/MpdpaKI/Y2P+ueyIXVEr0r2U6hcU0=@vger.kernel.org X-Gm-Message-State: AOJu0YwzyCdB6lBO8JZmqaEBo9krUI2zqr4OaUG6CxMKGd64c3qDRy0j GCiaixAmyBWkPoWMtVDaxUBiqSTa49jWMTsdG62efgWx589xh3n9uZGFwo8LwKEVJIreLehHtK7 lu7+UC5e9SESczj09GrpKvpQbYXNcZps4PHHhMonMfCE+d8mAPCxgI7LKldSReN1nUfE= X-Gm-Gg: AfdE7cmsh0jKxNCtuo5V8W14D4ReBnKI+qtTGqnq3o8AJXDdAphwfym+ANvaVDR3YVN R/DFLEeV0XDbmMylL4t+4iXliZHFkcMyGY/OPRNnbjjPLKgwFJg5MJ4spl3w7rNZwyiqMFaR2I7 L4b445vDXKQRosIYLXlEGQ916XblF2DTK80grGmIs3a6lyr3/N2NN+akrX7F7jrJ58KiNXOa8t3 /TFXtGI/KPOGbB981zEYjRogjaetFMZflt+zqG0eHFJj7Xspdk7cMv++iPDtGnbBgyn32N7R6cW U03Yk/qUTCCyU1IX0p7pnpL/rkEBoJX3npaIAd061lHMl9fFL2GvhTvuWRvYwS1gAI5PHAfN1ap LNDhQug7WSUc27RAlEPw3XXps7BAjzO72oGo= X-Received: by 2002:a05:620a:460b:b0:913:b4b9:5ec8 with SMTP id af79cd13be357-925c87e2572mr916085785a.6.1782298829919; Wed, 24 Jun 2026 04:00:29 -0700 (PDT) X-Received: by 2002:a05:620a:460b:b0:913:b4b9:5ec8 with SMTP id af79cd13be357-925c87e2572mr916074085a.6.1782298828928; Wed, 24 Jun 2026 04:00:28 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad69580f73sm1620615e87.63.2026.06.24.04.00.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jun 2026 04:00:27 -0700 (PDT) Message-ID: <891015c8-68df-4654-b1e7-94d73e74267c@oss.qualcomm.com> Date: Wed, 24 Jun 2026 13:00:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: sm8250-xiaomi-elish: Add pm8008 PMIC To: Xin Xu Cc: andersson@kernel.org, devicetree@vger.kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI0MDA5MSBTYWx0ZWRfX/KTio/EFhQ/O BeeMDklZzNFUyslDkM0BQm4TOZLagDiNIHs2Dq9uQ2nokemXUxjcc3ee9R+WgJNrXJs+uCi77UC fVxmv+LrsQfP+SW8hVVeeuxSNgCcz3A= X-Proofpoint-GUID: LwqpQF1JQ6-QTnhexXiKbjRtOR0i9V_y X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI0MDA5MSBTYWx0ZWRfXyh/EN4KWnpzl D2bbWblRG9iGWs9q0zkwSuDCGoVeo0zz1aMDqDkM9bLq+v3Pqas6ccU9HHusFaVT/00HF/r/yIl bxEp0aix/LxXVPt4tkTqw5BcZsW3VRGhA+S9jFEktZa9HXBj8sYSvzKUhettWOCDzCrBtUsNcWF xZWBRSRYPDCNA541B9jLcGUu+yOmYw3FAX7UTCgI/riRELiTicLodv4Fahe82prygXxkD7DNRQJ b+oESmep5bStpk0ZQA2hG/J1YSDpyQK7oxZelocc6nF9y4uPHyUdwg4kWG7g4KL/PZ5I/jxiOgC sBvxFzp3xzDsfWR/F/gvcK3rqBGjfYz+AWc3b+P5epRG48mz7oNow4l7LQhOlng1htAWggyKaDN AKKQZI+y61DumW1vAmqyebqUV9l3zw== X-Authority-Analysis: v=2.4 cv=UphT8ewB c=1 sm=1 tr=0 ts=6a3bb8cf cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=NEAV23lmAAAA:8 a=dZbOZ2KzAAAA:8 a=i_-uY6NMUGNg07SqJiEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: LwqpQF1JQ6-QTnhexXiKbjRtOR0i9V_y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-24_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606240091 On 6/22/26 8:07 PM, Xin Xu wrote: > On Mon, 2026-06-22 at 13:40 +0200, Konrad Dybcio wrote: >> On 6/19/26 6:07 PM, Xin Xu wrote: >>> Add the pm8008 PMIC node on i2c15 with seven LDOs, >>> using GPIO84 as interrupt and GPIO76 as reset. >>> >>> Signed-off-by: Xin Xu >>> --- [...] >>> + pm8008_default: pm8008-default-state { >>> + int-pins { >>> + pins = "gpio84"; >>> + function = "gpio"; >>> + bias-disable; >>> + drive-strength = <2>; >>> + input-enable; >>> + }; >>> + >>> + reset-pins { >>> + pins = "gpio76"; >>> + function = "gpio"; >>> + bias-pull-up; >>> + drive-strength = <2>; >>> + output-high; >> >> Drop output-high, the driver will take care of setting the output >> state >> >> Konrad > > Thank you for your review! > > I will fix the coding style issues (blank line before status, > interrupts-extended, property order, and dropping output-high) > in the next version. > > I have verified all LDO voltages against the downstream device tree: > https://github.com/MiCode/kernel_devicetree/tree/elish-r-oss/ > The definitions can be found around lines 209–244 in > qcom/elish-sm8250-camera-board.dtsi Thanks. It's best if you grab the DTB from a running device (which has all the overlays applied etc.), which you can grab from /sys/firmware/fdt You can then pass that to DTC directly Konrad