From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
kernel@collabora.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 09/15] drm/tests: hdmi: Fixup CamelCase warning
Date: Thu, 10 Apr 2025 13:16:49 +0300 [thread overview]
Message-ID: <89108670-c48b-4713-9bbb-98ab966f2197@collabora.com> (raw)
In-Reply-To: <20250409-accomplished-vivacious-ant-3c03c3@houat>
On 4/9/25 6:13 PM, Maxime Ripard wrote:
> On Wed, Mar 26, 2025 at 12:19:58PM +0200, Cristian Ciocaltea wrote:
>> Rename the reject_100_MHz_connector_hdmi_funcs variable to make
>> checkpatch.pl happy:
>>
>> CHECK: Avoid CamelCase: <reject_100_MHz_connector_hdmi_funcs>
>>
>> While at it, also rename reject_100MHz_connector_tmds_char_rate_valid()
>> for consistency.
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>
> In this case, checkpatch is wrong. mhz != MHz.
>
> And since it's not a warning, I'd just ignore it.
I think it also improves consistency a bit, as this is actually the only
place where "[_]MHz" is being used in the file, everywhere else we have
"mhz", without '_' prefix.
But I can still drop the patch if you prefer.
next prev parent reply other threads:[~2025-04-10 10:16 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 10:19 [PATCH v3 00/15] drm/connector: hdmi: Allow using the YUV420 output format Cristian Ciocaltea
2025-03-26 10:19 ` [PATCH v3 01/15] drm/connector: hdmi: Evaluate limited range after computing format Cristian Ciocaltea
2025-03-26 10:19 ` [PATCH v3 02/15] drm/connector: hdmi: Add support for YUV420 format verification Cristian Ciocaltea
2025-04-09 15:04 ` Maxime Ripard
2025-03-26 10:19 ` [PATCH v3 03/15] drm/connector: hdmi: Improve debug message for supported format Cristian Ciocaltea
2025-03-26 10:19 ` [PATCH v3 04/15] drm/connector: hdmi: Add missing bpc debug info to hdmi_try_format_bpc() Cristian Ciocaltea
2025-03-30 21:18 ` Dmitry Baryshkov
2025-03-26 10:19 ` [PATCH v3 05/15] drm/connector: hdmi: Rename hdmi_compute_format() internal helper Cristian Ciocaltea
2025-03-26 10:19 ` [PATCH v3 06/15] drm/connector: hdmi: Factor out bpc and format computation logic Cristian Ciocaltea
2025-04-09 15:02 ` Maxime Ripard
2025-04-10 10:06 ` Cristian Ciocaltea
2025-03-26 10:19 ` [PATCH v3 07/15] drm/connector: hdmi: Use YUV420 output format as an RGB fallback Cristian Ciocaltea
2025-04-09 15:09 ` Maxime Ripard
2025-04-10 10:08 ` Cristian Ciocaltea
2025-03-26 10:19 ` [PATCH v3 08/15] drm/tests: hdmi: Add macros to simplify EDID setup Cristian Ciocaltea
2025-04-09 15:11 ` Maxime Ripard
2025-03-26 10:19 ` [PATCH v3 09/15] drm/tests: hdmi: Fixup CamelCase warning Cristian Ciocaltea
2025-04-09 15:13 ` Maxime Ripard
2025-04-10 10:16 ` Cristian Ciocaltea [this message]
2025-03-26 10:19 ` [PATCH v3 10/15] drm/tests: hdmi: Replace open coded EDID setup Cristian Ciocaltea
2025-04-09 15:15 ` Maxime Ripard
2025-04-10 10:27 ` Cristian Ciocaltea
2025-03-26 10:20 ` [PATCH v3 11/15] drm/tests: hdmi: Drop unused drm_kunit_helper_connector_hdmi_init_funcs() Cristian Ciocaltea
2025-04-09 15:24 ` Maxime Ripard
2025-04-10 10:37 ` Cristian Ciocaltea
2025-03-26 10:20 ` [PATCH v3 12/15] drm/tests: hdmi: Setup ycbcr_420_allowed before initializing connector Cristian Ciocaltea
2025-04-09 15:15 ` Maxime Ripard
2025-03-26 10:20 ` [PATCH v3 13/15] drm/tests: hdmi: Add limited range tests for YUV420 mode Cristian Ciocaltea
2025-04-10 7:18 ` Maxime Ripard
2025-04-10 11:23 ` Cristian Ciocaltea
2025-03-26 10:20 ` [PATCH v3 14/15] drm/tests: hdmi: Add max TMDS rate fallback " Cristian Ciocaltea
2025-04-10 8:35 ` Maxime Ripard
2025-04-10 12:00 ` Cristian Ciocaltea
2025-03-26 10:20 ` [PATCH v3 15/15] drm/tests: hdmi: Add test for unsuccessful forced fallback to YUV420 Cristian Ciocaltea
2025-04-10 9:21 ` Maxime Ripard
2025-04-10 12:07 ` Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89108670-c48b-4713-9bbb-98ab966f2197@collabora.com \
--to=cristian.ciocaltea@collabora.com \
--cc=airlied@gmail.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®