From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Debraj Mukhopadhyay <quic_dmukhopa@quicinc.com>,
quic_neersoni@quicinc.com, andersson@kernel.org,
konradybcio@kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] qcom: ice: Prevent client probe failures on unsupported ICE
Date: Tue, 21 Oct 2025 11:27:52 +0200 [thread overview]
Message-ID: <89150929-873f-4d09-9cec-727f92572d17@oss.qualcomm.com> (raw)
In-Reply-To: <20251021040337.787980-1-quic_dmukhopa@quicinc.com>
On 10/21/25 6:03 AM, Debraj Mukhopadhyay wrote:
> Storage clients (ex. UFS and MMC) invoke of_qcom_ice_get() to obtain the
> handle from ICE (Inline Crypto Engine) driver. Currently if ICE is
> unsupported, the return code from probe could prevent the client
> initialization which is a bug. To fix this a new flag
> qcom_ice_create_error is introduced which caches the error encountered
> during ICE probe.
Probe currently only happens if the ICE node is present in the DT and
referred to from the storage controller. What does this patch solve?
Konrad
>
> The qcom_ice_create() and of_qcom_ice_get() functions are updated to
> return -EOPNOTSUPP when ICE is unsupported, allowing clients to proceed
> without ICE.
>
> For other failures, such as ICE not yet initialized, the existing
> behavior (e.g., -EPROBE_DEFER) is retained to ensure proper error
> handling.
>
> This improves error signaling and ensures that client initialization is
> not blocked unnecessarily.
>
> Signed-off-by: Debraj Mukhopadhyay <quic_dmukhopa@quicinc.com>
> ---
next prev parent reply other threads:[~2025-10-21 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 4:03 Debraj Mukhopadhyay
2025-10-21 9:27 ` Konrad Dybcio [this message]
2025-10-21 12:34 ` Debraj Mukhopadhyay
2025-10-21 13:16 ` Konrad Dybcio
2025-10-27 18:26 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89150929-873f-4d09-9cec-727f92572d17@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_dmukhopa@quicinc.com \
--cc=quic_neersoni@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®