From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752130AbdHPOlK (ORCPT ); Wed, 16 Aug 2017 10:41:10 -0400 Received: from mout.web.de ([212.227.17.11]:55320 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751471AbdHPOlJ (ORCPT ); Wed, 16 Aug 2017 10:41:09 -0400 To: Jan Kara , kernel-janitors@vger.kernel.org Cc: LKML From: SF Markus Elfring Subject: [PATCH] quota_v2: Delete an error message for a failed memory allocation in v2_read_file_info() Message-ID: <8916fd8c-2f13-e343-d648-1174563e9c38@users.sourceforge.net> Date: Wed, 16 Aug 2017 16:41:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:gLMAJ/7GhFjzIhGOKO1N6hE1ZaLf0dOdhUgQJfngfsFqoFVckOf CvRcBYNsu8dRwf79oO5cYvIK0HnP/4uQGD3fZtLHJSNMHgTFvMR+wO0JiFW/QW2gA2sllvD Rs2hN9ONzOT01H1c//GLmndYj67Zd8cCF5fcS2muD08gWOs01kR/qrqqrNCyUXBKiLnnd31 iol+UOJDSZPbX+cnVOkEQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:HITHTcWW2Ac=:Aa7IYkk+bpyJ33fdrX0cqZ Qk1E/b/ezOKu1SgjXJxZnz4DoYcu7FAJWRhryeIpAzss2+le5tBdMHbaAGJ9sRetS8Co6janT pfwCezvxOHaKKt3gwHrOVVnyNJj5shsLDairB7KNNtIl+Xn1gL4kbG1Bh2FeGl8z1/5TmbNzf 1/3E1s8dnKYVbxk0eeAelVwVYJtMxmZFtQKsNaLdy4aCgP+41KfV5bQV22R/8iyZKskjrpDG3 b8p3ZQtepHTyHseg3PdtjKG8myQX8zR4NnUbqiRqIxuAU5u9MJxa6cev4whS07UCVfpTFSU+R zycKGcRqeVcSr81p6GsGA4amovjdle806g/K3Ikjmw51OX8/eda6ZBdx/kqZXKUc8/CJnhzks z6w+6OJtbe2+Zj23RgHMJl9pnLy746BGIAMscIeRu49vRYIoBnA4EDHyxi0esaa9s0Jfqw1HF ana/b0QM+FPadZHHQW44a/j3SLwXeGNWrFLlzAA0mybBOOtmbqIZEVpgCKBlOjzV4nlpuP086 yXYHp0Xsq+SJJs//QvwBXWc3WKcGKqFELlESpj/Z+jeSke1OMbYvZkSt1muVV7aS5w65Lr+3q s7W+hmR3BVjDRejaE20m+0/Q2+hfFWp3tU4kSmVbh7eduujL4Il+kmI/dIyyEz9vwEZ26qyRF DSNQjMmIXPXNxChIDu1BB9P98ExhbyrBldPxBwfHuK/9SYxsXm7o3eHZAlzUbKOGG1SvdcBsy 49irD/1ZAYxl/vNHvcKBLftX/RhSMXjSL7xeomU5eTZkr/AN96CTaQNiiALI/Uxzbop3Y2dGe k3G405ZAwUXxHFWTUd3GQZDrIa3lMt4dt/R4KkI9ALyRd3q8bE= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 16 Aug 2017 16:16:30 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/quota/quota_v2.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/quota/quota_v2.c b/fs/quota/quota_v2.c index ca71bf881ad1..2259329616b7 100644 --- a/fs/quota/quota_v2.c +++ b/fs/quota/quota_v2.c @@ -109,11 +109,9 @@ static int v2_read_file_info(struct super_block *sb, int type) return -1; } info->dqi_priv = kmalloc(sizeof(struct qtree_mem_dqinfo), GFP_NOFS); - if (!info->dqi_priv) { - printk(KERN_WARNING - "Not enough memory for quota information structure.\n"); + if (!info->dqi_priv) return -ENOMEM; - } + qinfo = info->dqi_priv; if (version == 0) { /* limits are stored as unsigned 32-bit data */ -- 2.14.0