From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 270833BBFC4 for ; Sun, 2 Aug 2026 15:21:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785684108; cv=none; b=g8O3YqkiZQgOpqklNUgHWpHKSl6e+SU6Xgw6b/3ez7d1zCjRaMJCKhc/uGYIOXAW1trfnuk70/5rKj5Snaon66cRTX4gd0GS1p0ce1Ax3tGvOKLfycmqz5FLbN1XEHBmZ9TM9KVpsiCj+D8bBsYYevi3CA9NJv+VkF8IIFIx33c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785684108; c=relaxed/simple; bh=oPIPJIbT996fDCjpLjlK/ZsY97vJTBErQkLcDSYPjus=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EyJb69/XXRJYjhzyMpyqHdqc37jWfp4n4sPeFZ2d529/l8B2JdAwW6o08IUZxwpQPfXsvpllGeHXnGTiFkTnDiYY4TG6YzBvsK8TQnJ7DkmA5HZsMEdBS9ms0O6JIlJlYpjJVwJEsUHR2REJpRbUuYdHhxaBGmPMaKqLwBhE0Vo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=FuUHKUM1; arc=none smtp.client-ip=209.85.160.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="FuUHKUM1" Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-446f87b6de1so1534041fac.3 for ; Sun, 02 Aug 2026 08:21:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1785684105; x=1786288905; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kPqOl4wp7KWWvdGsj9eCGVRa0PYoR/ErdETgCVgpTQk=; b=FuUHKUM1KzwS2MQ+9NmMqcT6uJHYboTu5ZF99UbQje0MzLpo95skdMWNbl8rDrIMxd fTpMLYL0uZ0iG6PiRqLmgtk8JvnCiwtWAZKWqsVkn/aY2Y6130RcXtq3gJ12ebLBIiPC IMaWN5fkotB6wFMThjZuqXWJOxDrK/iXTZowUUjX0nhRM4LaKSEvhzJ6blI0ti87kMll U01PoeijqcXdNMgCfTF6s2NgW5zaeFLk00MGIjYG7WGvwB6qb/Ym3GPTcEJw+K9dByFZ 3ywppGBYQbXsZzSs5aiFelAIBpdHRueIml4xHSApD+4iu3YLx3hEAF0lBGsEEjeMXCCn araw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785684105; x=1786288905; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kPqOl4wp7KWWvdGsj9eCGVRa0PYoR/ErdETgCVgpTQk=; b=M/mNPvGdlKi5fv4PJtmkKLDVIuo1Z5/xmaU7RBBkGZfWY+TKqcDATSFRINXkzw0GnI bSRVungxV+vBxdLu7CCRWYoX1GHl8qUoc8R4N9hCz0jT+1uGxqJQsDCBB8wjuW0Nv0eK gLW6dT9KlE/0kCLd8/EWC8XeRs4ZmVkY5fYxyDghkYYER8i1aIaRFkYAhAbgu+vpmP1z 5oht/WzeAehAQDekB39AR0VN7L7jV+RyH7odlNTzmFozk32SBNKyYWmuHvZTvcT1I6gN PLSwW3+gV/MxFEz1FGAxjwjimSYR7p5ifuvjsAfILxQJJfWWreRO/VT46u2N7BkKcIZ0 Wv9w== X-Forwarded-Encrypted: i=1; AHgh+RoMRoL6u2lpFIOf9CPPYsMbkBJagORSCa+dH1fzD3Ly3ciH8vbAvbxzf44OhuDods/BajlsdLPltQYHpDw=@vger.kernel.org X-Gm-Message-State: AOJu0YzkVFHNgNA7zy1N8MYe4C2Sgms4tdCBBl7VYGfGNuNljMAj/0sL p2wVJiFy5JCPFxW/LJ7Z2EdfkdfNno+SfWTtVa4EapssQlBUFDeCNxIB+x81wLN8gNE= X-Gm-Gg: AR+sD11aETGrEH1TdbytDxCT2itdWJ++lq2olJa1XwRrByUvdLNZXk30WoJBTKPYPWN yoPhMpykAQ6SJ14nX9sDKhAK9jyBTfhB87uI9qDFGPhilBM/2412kOPwqBAXRzF3b6JaOvlV6zk UXt4RxQxYHWLil/TCCE0IvG8wA08fwphB7H41hMHQieZI95JK6Z9TS8HeJ/jsW0OHPv6ttw5b8l 7dO1nJMSZf4di/m4XYd8eHL8rOmdb2O6es96oNE1gNuHd7JuvlSbU9vzCaNurnuzvt4tqMF1Ttf z5e6xtrY285mYonC4dmKXV46y0X5LY/IX/UJMM+CcQms7u2nExGp26dNyd65V9ui7yloRXlOb9l 860sz/hVxpysJnBbnW8/aLuxRCK5Wi4qs3zyE7SFGc5uuiQq6swo3/0Be50yFeR4KRjYubcjI1/ lYjMy5J1UI4QS4cdm/sUCPaNH77AS1RGOQYjMMLOVlWfJl02SJeGMenngP/qxjC8E6Q8JXvTiBC HR7/I+npHmE3+2lrn7HJHk0iTdyftJ4QLqUNCA= X-Received: by 2002:a05:6820:991:b0:6ae:46cd:e8fd with SMTP id 006d021491bc7-6ae46cdea66mr8564071eaf.21.1785684104915; Sun, 02 Aug 2026 08:21:44 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:5487:2b6e:1057:d3d3? ([2600:8803:e7e4:500:5487:2b6e:1057:d3d3]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-458f60650c2sm6608256fac.2.2026.08.02.08.21.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Aug 2026 08:21:43 -0700 (PDT) Message-ID: <89176b25-bcf6-4d44-94b3-7a29abec7b10@baylibre.com> Date: Sun, 2 Aug 2026 10:21:41 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] iio: health: max30102: fix NULL dereference in interrupt handler To: Jonathan Cameron Cc: Marco Chen , nuno.sa@analog.com, andy@kernel.org, pmeerw@pmeerw.net, matt@ranostay.sg, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev References: <20260731184124.112124-1-marcochen.dev@gmail.com> <20260802031035.6eb2be14@jic23-huawei> Content-Language: en-US From: David Lechner In-Reply-To: <20260802031035.6eb2be14@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/1/26 9:10 PM, Jonathan Cameron wrote: > On Sat, 1 Aug 2026 10:18:42 -0500 > David Lechner wrote: > >> On 7/31/26 1:41 PM, Marco Chen wrote: >>> The interrupt is requested in max30102_probe() and stays enabled >> >> I've always wondered why most IIO drivers seem to do this. It seems to >> me that requesting the irq with IRQF_NO_AUTOEN and only enabling it >> when everything is set up for reading data would avoid spurious interrupts >> like this. > > It teaches discipline. More serious from what I recall the no autoen thing > used to be done via a racey bit of trying to turn it off as fast as you can. > > Most of the time we should be able to write drivers that don't need to > use that flag and don't touch enable_irq() at all. > > Obviously that's not always true. > Hmm... so I should go back and change [1] since it isn't strictly required there? [1]: https://lore.kernel.org/linux-iio/20260731-iio-adc-ti-ads112c14-continuous-mode-v2-1-eb13da38e8fc@baylibre.com/