From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6A2EC55179 for ; Wed, 21 Oct 2020 17:55:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E9DE2225F for ; Wed, 21 Oct 2020 17:55:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="reyVjsuA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438246AbgJURzE (ORCPT ); Wed, 21 Oct 2020 13:55:04 -0400 Received: from m42-4.mailgun.net ([69.72.42.4]:29484 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391138AbgJURzD (ORCPT ); Wed, 21 Oct 2020 13:55:03 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1603302903; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=LRMUirYzhYY9YlK5k5r6P0ZepRcjoq/tviwqExz3pxk=; b=reyVjsuActxvxHCTAYDI9wO5Ucnl3e7xnAXNhG1uL9jVKrUkDBgmx50qL/GOD57Fq0bEiw/5 7jVsZ1IVgxUGztJ48YhYeTgCvrxuU6+rXdRFShj18WyW750wdE6osW8Dq7VBHhdJF3fO+5Dm NM5LoYboULW2ypvLmQWONevWiOI= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 5f9075f6aad2c3cd1c7975f1 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 21 Oct 2020 17:55:02 GMT Sender: hemantk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id EB34DC43385; Wed, 21 Oct 2020 17:55:01 +0000 (UTC) Received: from [10.46.162.249] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: hemantk) by smtp.codeaurora.org (Postfix) with ESMTPSA id D4153C433C9; Wed, 21 Oct 2020 17:55:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D4153C433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=hemantk@codeaurora.org Subject: Re: [PATCH v7 1/4] bus: mhi: core: Add helper API to return number of free TREs To: Loic Poulain , Manivannan Sadhasivam Cc: Greg Kroah-Hartman , linux-arm-msm , open list , Jeffrey Hugo , Bhaumik Bhatt References: <1602907457-13680-1-git-send-email-hemantk@codeaurora.org> <1602907457-13680-2-git-send-email-hemantk@codeaurora.org> <20201021152714.GD3334@Mani-XPS-13-9360> <20201021162540.GG3334@Mani-XPS-13-9360> From: Hemant Kumar Message-ID: <891914f1-13f2-abf8-46a6-d52218d67094@codeaurora.org> Date: Wed, 21 Oct 2020 10:55:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Loic, On 10/21/20 9:51 AM, Loic Poulain wrote: > On Wed, 21 Oct 2020 at 18:25, Manivannan Sadhasivam > wrote: >> >> On Wed, Oct 21, 2020 at 05:43:14PM +0200, Loic Poulain wrote: >>> On Wed, 21 Oct 2020 at 17:27, Manivannan Sadhasivam < >>> manivannan.sadhasivam@linaro.org> wrote: >>> >>>> On Fri, Oct 16, 2020 at 09:04:14PM -0700, Hemant Kumar wrote: >>>>> Introduce mhi_get_free_desc_count() API to return number >>>> >>> >>> Would it not be a good idea to have naming aligned with other methods? >>> Like mhi_queue_num_free() or mhi_queue_no_free_elem... >>> >> >> 'queue_num_free' doesn't sound like getting the number of available >> descriptors... > > Right, TBH, just wanted the function to start with mhi_queue since > it's about getting info about remaining size of the DL or UL 'virtual > queue'. But AFAIU, this is the number of available ring elements that > is returned here, not the number of transfer descriptors (that can be > composed of one or more ring elements), so maybe > mhi_queue_num_free_elements or something similar, I don't want to be mhi_get_free_desc_count is the number of TREs available which queue APIs can use to queue an transfer ring element. My only concern is if we get confused with the name mhi_queue_ part of as number of TREs queued ? Transfer ring element is indeed a transfer descriptor. > picky here. > > Regards, > Loic > Thanks, Hemant -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project