From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751688AbcHZIAo (ORCPT ); Fri, 26 Aug 2016 04:00:44 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:35891 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751098AbcHZIAn (ORCPT ); Fri, 26 Aug 2016 04:00:43 -0400 Subject: Re: [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl To: Maxime Ripard References: <1472107494-20740-1-git-send-email-woogyom.kim@gmail.com> <1472107494-20740-2-git-send-email-woogyom.kim@gmail.com> <20160826071056.GA10545@lukather> Cc: Chen-Yu Tsai , Thierry Reding , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring From: Milo Kim Message-ID: <89195613-d5b6-bfc6-1c8c-0d74d9d02a99@gmail.com> Date: Fri, 26 Aug 2016 17:00:37 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160826071056.GA10545@lukather> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/26/2016 04:10 PM, Maxime Ripard wrote: >> + uart1_pins_a: uart1@0 { >> > + allwinner,pins = "PG6", "PG7"; >> > + allwinner,function = "uart1"; >> > + allwinner,drive = ; >> > + allwinner,pull = ; >> > + }; >> > + > Our policy is that we don't introduce new pinctrl nodes that are not > used by any board to avoid bloating the DT too much with unused nodes. > > If you have a board using it, please submit that change as well. OK, I agree. However, this pinmux is only useful in case PA5 is assigned for PWM. PA5 is commonly used for UART0_RX, so I'd like to add UART1 node into *.dts and disable it (status = "disabled"). Does it make sense? Best regards, Milo