From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49D06C433F5 for ; Wed, 20 Apr 2022 08:38:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376791AbiDTIlg convert rfc822-to-8bit (ORCPT ); Wed, 20 Apr 2022 04:41:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376766AbiDTIld (ORCPT ); Wed, 20 Apr 2022 04:41:33 -0400 X-Greylist: delayed 77379 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 20 Apr 2022 01:38:47 PDT Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D67029C9B for ; Wed, 20 Apr 2022 01:38:46 -0700 (PDT) Received: (Authenticated sender: hadess@hadess.net) by mail.gandi.net (Postfix) with ESMTPSA id 5829B40004; Wed, 20 Apr 2022 08:38:42 +0000 (UTC) Message-ID: <892475a2d458aa1e8f5027f13d6582f0f6b4b05e.camel@hadess.net> Subject: Re: [PATCH] HID: wacom: Correct power_supply type From: Bastien Nocera To: Jiri Kosina Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Tissoires , Ping Cheng , Jason Gerecke Date: Wed, 20 Apr 2022 10:38:41 +0200 In-Reply-To: References: <20220407115406.115112-1-hadess@hadess.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.44.0 (3.44.0-1.fc36) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-04-11 at 17:08 +0200, Jiri Kosina wrote: > On Thu, 7 Apr 2022, Bastien Nocera wrote: > > > POWER_SUPPLY_TYPE_USB seems to only ever be used by USB ports that > > are > > used to charge the machine itself (so a "system" scope), like the > > single USB port on a phone, rather than devices. > > > > The wacom_sys driver is the only driver that sets its device > > battery as > > being a USB type, which doesn't seem correct based on its usage, so > > switch it to be a battery type like all the other USB-connected > > devices. > > > > Signed-off-by: Bastien Nocera > > --- > >  drivers/hid/wacom_sys.c | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c > > index 066c567dbaa2..620fe74f5676 100644 > > --- a/drivers/hid/wacom_sys.c > > +++ b/drivers/hid/wacom_sys.c > > @@ -1777,7 +1777,7 @@ static int __wacom_initialize_battery(struct > > wacom *wacom, > >         bat_desc->get_property = wacom_battery_get_property; > >         sprintf(battery->bat_name, "wacom_battery_%ld", n); > >         bat_desc->name = battery->bat_name; > > -       bat_desc->type = POWER_SUPPLY_TYPE_USB; > > +       bat_desc->type = POWER_SUPPLY_TYPE_BATTERY; > >         bat_desc->use_for_apm = 0; > >   > >         ps_bat = devm_power_supply_register(dev, bat_desc, > > &psy_cfg); > > Thanks Bastien, makes sense. CCing Jason and Ping (the Wacom driver > maintainers) to get their Ack. Hey, I know both Jason and Ping, but their name didn't show up when running get_maintainers.pl and neither of their names are in the MAINTAINERS file. This probably needs fixing. Cheers