mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xin Li <xin@zytor.com>
To: "H. Peter Anvin" <hpa@zytor.com>, Brian Gerst <brgerst@gmail.com>
Cc: linux-kernel@vger.kernel.org, luto@kernel.org,
	tglx@linutronix.de, mingo@kernel.org, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org,
	peterz@infradead.org
Subject: Re: [PATCH v3 3/3] x86: Zap TOP_OF_KERNEL_STACK_PADDING on x86_64
Date: Sun, 11 May 2025 23:13:44 -0700	[thread overview]
Message-ID: <8925f277-a173-47c4-95e3-ed6234a45043@zytor.com> (raw)
In-Reply-To: <1106B557-4AA2-410F-A990-C0C3BB7E675B@zytor.com>

On 3/21/2025 1:14 AM, H. Peter Anvin wrote:
> On March 20, 2025 10:47:25 PM PDT, Xin Li <xin@zytor.com> wrote:
>> On 3/19/2025 12:17 PM, Brian Gerst wrote:
>>> I'm not sure it's worth fully removing TOP_OF_KERNEL_STACK_PADDING for
>>> 64-bit if it results in needing separate definitions of
>>> task_top_of_stack().  Leaving it at zero is fine.  The other changes
>>> are fine though.
>>
>> Let's leave it to x86 maintainers ;-)
>>
>> But to me, TOP_OF_KERNEL_STACK_PADDING no longer makes sense on 64-bit,
>> and it makes it simpler to remove it.  On the other side, 32-bit is to
>> be zapped...
>>
>> Thanks!
>>     Xin
>>
> 
> For what it's worth, it was there as 0 before the FRED changes, so ...
> 

Okay, I will drop this patch and send the patch set as v4.

Thanks!
     Xin

      reply	other threads:[~2025-05-12  6:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-19  7:10 [PATCH v3 0/3] x86: Allow variable-sized event frame Xin Li (Intel)
2025-03-19  7:10 ` [PATCH v3 1/3] x86/fred: " Xin Li (Intel)
2025-03-21  5:37   ` [PATCH v3A " Xin Li (Intel)
2025-03-19  7:10 ` [PATCH v3 2/3] x86: Remove the padding space at top of the init stack Xin Li (Intel)
2025-03-19  7:10 ` [PATCH v3 3/3] x86: Zap TOP_OF_KERNEL_STACK_PADDING on x86_64 Xin Li (Intel)
2025-03-19 19:17   ` Brian Gerst
2025-03-21  5:47     ` Xin Li
2025-03-21  8:14       ` H. Peter Anvin
2025-05-12  6:13         ` Xin Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8925f277-a173-47c4-95e3-ed6234a45043@zytor.com \
    --to=xin@zytor.com \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®