From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 589FD30DD36 for ; Tue, 2 Sep 2025 14:29:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756823350; cv=none; b=sIqmwL/Tz0GfqUEvohNPYwhbZ8QnYAkskWY2SBj1Fdhog9mOTmw4J9471dfdASR3JhQJInJx3f3XFC+/Cq9l8MQw5lpHDpZzKGOI4EzvjkaOj2P69QLMu9As2MWFsOAh1rCpPvsksm+KiPh0HPyjtUtO7Rpa07DjKc/yi5eE6YM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756823350; c=relaxed/simple; bh=Zh/esVOjxW9buYPgrg25ime4g5npaPosuL61f9Sd6lc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qfiBlgINrFTbB3TJ8fBBEstBqbqv3RwwN1XtUzTLacGKdNJYwy4Vi3uEHgABWdvOZ7MsqA+u2pWu90LP3NLYRBbfX4SYaE2AMzEs/zAgyaGJg9yy123ov1p/jZ+FKDY9JknmkTY4h73lO/v2NKpW4ajp6vewouqrdaXiRsVF/js= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=d4RwbFT8; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="d4RwbFT8" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-7438175d42aso3217848a34.1 for ; Tue, 02 Sep 2025 07:29:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1756823346; x=1757428146; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pp38Yvg3RiytProyc5t2mGqns6Lb9l3HNRoLbsNuGqs=; b=d4RwbFT8GryJDSSfS/vvnQ5NYIUEncQQTaY0qPKyd22otXxkGl/RXepzlCAZlhetZd 2WNkXNwB7npWfxum7PvK605qGN2qcfiITRUiA2WU+P276RqaltQHmVxGCNP9CA0gct8W CJ9Nm6gy/2Gk/ONx07/u3Wxo1zjifXYaGm8yQjM6EFD4LqdZKzsn+n4iw2GDTPoKsLBJ Xm3eFlLf+3uPjcLAY5G0Hv56XgXOIdi2yfetiKOdQI9sVkC4DlnxRbuGR4Q8A4jrNkqb JBUMeq+mqXgCOqyFFrKqzg8TY9xev/pr7IWS8+jZST5sLM4/NkZX4+uYckl1ZJPLC095 wAfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756823346; x=1757428146; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pp38Yvg3RiytProyc5t2mGqns6Lb9l3HNRoLbsNuGqs=; b=HdJmREjgMCKmDnh+i+ZlF+y1aQjcJIfwyWXAzOxeQAeYpeBGAd8E98C1gW7/rlOGmt XSGFgXkX9r/OfcxW/W2JOpdlYdmX/jskUf+CuLKUY19G3Q/5b7SfIEGSACLQoYXrEovQ F24VLsvKfbNkeDQof7Vv16SMROJftq7qhkjJsJ+E8Xn09mIPSNHlLK2otSMOfwUZ7k6L gGC3v+NkOnFC92ZtL+YDayICXKh2Ohi5JVgdF2q1tiwU+WroAYd3vrYp2nj7DSdsrO8z GSMHIFivnwMvUNU960SZhutPwUS9XEsGdsu1FS7dDTJRBL8JtILeuIeLKlTyK438HBci FVpQ== X-Forwarded-Encrypted: i=1; AJvYcCWycbfsJJMMB1PPxJpuAf21BPQhZmhcT6Y9qpIOtagrGWpRs3LLktrbZm76FCZA7vWYhTCs890+5JHUFMk=@vger.kernel.org X-Gm-Message-State: AOJu0YxWgqGkcm5KeeExp4O8qQ/mSplzxy23McsYDZhhQMEWCSROYHV7 IKc02sy5teUFogqSoRF9ZKpLQXoGdrUqPA8d9N+1yqKium6NtzZPINW7qTsBfVXybGM= X-Gm-Gg: ASbGnctd0d39GOpPQKErgq557iWXp4CFAXT5dj9WXUcHIPtpqPwOuq5uTppEG+6rEdH UOnrlWAUNEvQCnOfYuGEYA30OCwC3dvzLfxNi5TYCNf/k+DuzZHz+eQNAuABgDwMeFZm8jLRsQj 5ohcWI21qoFo6A0gdUyBJ7GkTJBK6+PSNCiISxwDbf5/AoGLOhjZjLFkZ85wZRBItDWeH8PtOW4 DUQGaIS4B2BVmnuOX1/j56t/pEgbSs2SkBAtACjw7cgcp2QJLlYqM7gaxXQmbprqLmnwbvd9BKM KnEGOzVke/b6/o3nFOe21lcYlxj2V7azpxb73Tj2PE7/rVD7vO+v+mKNJW5LWU9CflNxjsOD5jO Hn35lt7ppY2ninwR/p1FshM5vCmprTBopjMRjsauFPieWx2VDeuH/OYYEnPG0P3p7eUlOlYF2 X-Google-Smtp-Source: AGHT+IGLw6/8aesIjAkhpVEJeXPBKTkpcMtabs/+MAUeiJpSmdalTytyjetDUXmkZqhdD3fGgZrheA== X-Received: by 2002:a05:6830:7101:b0:73e:9fea:f2a5 with SMTP id 46e09a7af769-74569d9deb9mr8195564a34.4.1756823346157; Tue, 02 Sep 2025 07:29:06 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:8d95:114e:b6f:bf5b? ([2600:8803:e7e4:1d00:8d95:114e:b6f:bf5b]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-745743d0e97sm1581788a34.42.2025.09.02.07.29.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Sep 2025 07:29:05 -0700 (PDT) Message-ID: <89265de7-eeff-4eea-838b-6a810c069a20@baylibre.com> Date: Tue, 2 Sep 2025 09:29:04 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 1/2] dt-bindings: iio: adc: add max14001 To: Marilene Andrade Garcia , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Kim Seer Paller , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marcelo Schmitt , Marcelo Schmitt , Ceclan Dumitru , Jonathan Santos , Dragos Bogdan References: <34b7cc7226e789acdc884d35927269aa5a0d5e14.1756816682.git.marilene.agarcia@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <34b7cc7226e789acdc884d35927269aa5a0d5e14.1756816682.git.marilene.agarcia@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/2/25 8:15 AM, Marilene Andrade Garcia wrote: > Add device-tree documentation for MAX14001/MAX14002 ADCs. > The MAX14001/MAX14002 are isolated, single-channel analog-to-digital > converters with programmable voltage comparators and inrush current > control optimized for configurable binary input applications. When there are multiple devices, DT maintainers like to know what is the difference between the devices. > > Co-developed-by: Marilene Andrade Garcia > Signed-off-by: Marilene Andrade Garcia > Signed-off-by: Kim Seer Paller Sine the patch is From: M.A.G., according to [1], this should be: Co-developed-by: K.S.P. Signed-off-by: K.S.P. Signed-off-by: M.A.G. (hopefully obvious, but don't use the abbreviations - I just did that for brevity) [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by > --- > .../bindings/iio/adc/adi,max14001.yaml | 79 +++++++++++++++++++ > MAINTAINERS | 8 ++ > 2 files changed, 87 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml b/Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml > new file mode 100644 > index 000000000000..ff9a41f04300 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml > @@ -0,0 +1,79 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2023-2025 Analog Devices Inc. > +# Copyright 2023 Kim Seer Paller > +# Copyright 2025 Marilene Andrade Garcia > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/adi,max14001.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices MAX14001-MAX14002 ADC > + > +maintainers: > + - Kim Seer Paller > + - Marilene Andrade Garcia > + > +description: | > + Single channel 10 bit ADC with SPI interface. > + Datasheet can be found here > + https://www.analog.com/media/en/technical-documentation/data-sheets/MAX14001-MAX14002.pdf > + > +$ref: /schemas/spi/spi-peripheral-props.yaml# > + > +properties: > + compatible: > + enum: > + - adi,max14001 > + - adi,max14002 > + > + reg: > + maxItems: 1 > + > + spi-max-frequency: > + maximum: 5000000 > + > + vdd-supply: > + description: > + Isolated DC-DC power supply input voltage. > + > + vddl-supply: > + description: > + Logic power supply. > + > + vrefin-supply: The actual pin name is REFIN, so refin-supply would make more sense. > + description: > + ADC voltage reference supply. > + > + interrupts: Likely needs `minItems: 1` in case only one interrupt is wired. > + items: > + - description: | > + Interrupt for signaling when conversion results exceed the configured > + upper threshold for ADC readings or fall below the lower threshold for > + them. Interrupt source must be attached to COUT pin. We could shorten these descriptions. The important part is which pin it is connected to. > + - description: | > + Alert output that asserts low during a number of different error > + conditions. The interrupt source must be attached to FAULT pin. > + And also `interrupt-names:` makes sense so we know which one is is wired if only one is given. > +required: > + - compatible > + - reg > + - vdd-supply > + - vddl-supply > +