From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012009.outbound.protection.outlook.com [40.107.200.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF3D21E3DDB for ; Thu, 20 Nov 2025 06:10:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.9 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763619024; cv=fail; b=VEZEAUHYcB3rW7DaY3DAuC/BYlebuZo6BsEOPNaWHcSkajx2VEbR+Zo8bIUAkKx7xwq0nzYylSNieOB0e995h29E41Nf6JIvicMnstUAj1SoPBniJ8iUeEmkOondLS6jn3qi8N0Vhjqd7+RwwZHI11VSYTU3gEvNpx0lWQgip4s= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763619024; c=relaxed/simple; bh=f9KQv/S4xOU5p+kRnL0p1OvSxx1H2gzwnups9tdq3wI=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=QHpQQ3rSHnQW7feKW0BTrKA+xP+1vxeMw0A/VYox0hkdju/T8JOK0x9WLMJrJbUIzd1dpPGKvKMubA8iTw4daIxOh1cSE3yIaK+sUJscp0H4zlN6c1wo3X4mDi9LaWo9QCxLjF24lq5JtmkaDzenyBdRiIyf7rybpQ7dKezFX2c= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=fojaSVdT; arc=fail smtp.client-ip=40.107.200.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="fojaSVdT" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eUQXoJyXD4wvD2j6Xp5aE30wS8VjmxTPbIcqSpqbzMxrSOm0MTwgcLM4KhP8ZVFj+ptjvlxRtP/oHYVNzoTVfbj13nJ/ESk2b3ub5D06s3ZgQkqKUlZuHmGm6EAm1YmbamV6/SSWRd4QHid9hoUjuaW+16nghWtBRCZhX75p9B8y6drxGdg1HJw3to/HCdWsRjwEurk7SIyV6xAxfu/DrP0GSU64DZ8lr593d2tXal7k2zRfWlXQ7lWNmHL9RHpcIiQveUokrrbHf9obmSD0v9jr80dBXSqoNm7q5WQMJi0okb0fkU4KlQMl0LHDKO5JuEnoyZsmZqqY//UywQfrKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pYS1rbTVc1K+3cAgRtAPXvOLRPj4yT/Wx/GfQfe9gTg=; b=bd/pOPI+DLYB8W/I7iR/+Qvc6HX+zVk6NcQpY1NYvwlv3KIKpCYT5RwU5N02v0njsK/RELXXSfSOyXzAv8rO+IETaijsNzg1bqtgSTxiMxeDpvT0mgeb1cdkg/YiUD1C7tO+6GNpS2vjnnjgaj9AXXqyEO/YnBpzA8e/fq1BbIJj/I1WjUomCkMhSbAQyffztVPsdhEsrhpeEku93Me2h2OsBZCkddx6ZckjV1mR4AEce4Lvtc8bJ1itL5L5N+W4gqpIDcqySS9XOm/ruAfG7+Fbly6325aq3ew+1ZI+vA4wEifn5PwZTMBmQyK4U2nwteuAeDIUaiyoWA0EN0ZyRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.ibm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pYS1rbTVc1K+3cAgRtAPXvOLRPj4yT/Wx/GfQfe9gTg=; b=fojaSVdTCRC6U5jUc2jkITDgJHWS1NRR0OoTNz6MsmKERyxB7EEXOACGwdEEr3Mo8iTnnEL8JP/CgslFxbQxqd4WBokUcTSCbwh2NDYhiMisf7nvtZRiKGGtAqoVtvG5sCnlkfrt987avIIskMqejirV/QK0U/AGnTf9dd16YZw= Received: from BY3PR10CA0001.namprd10.prod.outlook.com (2603:10b6:a03:255::6) by DS7PR12MB5885.namprd12.prod.outlook.com (2603:10b6:8:78::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Thu, 20 Nov 2025 06:10:17 +0000 Received: from SJ1PEPF00002320.namprd03.prod.outlook.com (2603:10b6:a03:255::4) by BY3PR10CA0001.outlook.office365.com (2603:10b6:a03:255::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.10 via Frontend Transport; Thu, 20 Nov 2025 06:10:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ1PEPF00002320.mail.protection.outlook.com (10.167.242.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Thu, 20 Nov 2025 06:10:16 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 19 Nov 2025 22:10:16 -0800 Received: from [10.136.37.179] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Wed, 19 Nov 2025 22:10:13 -0800 Message-ID: <892917ec-15b3-4852-b12f-9232e438802f@amd.com> Date: Thu, 20 Nov 2025 11:40:11 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] sched/psi: Make psi stubs consistent for !CONFIG_PSI To: Madadi Vineeth Reddy CC: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , John Stultz , Johannes Weiner , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Suren Baghdasaryan , References: <20251117185550.365156-1-kprateek.nayak@amd.com> <20251117185550.365156-2-kprateek.nayak@amd.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002320:EE_|DS7PR12MB5885:EE_ X-MS-Office365-Filtering-Correlation-Id: bbe81110-594a-4e27-c88f-08de27fb79dd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|7416014|376014|1800799024|82310400026|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eWxsdEttV3FHaFNNd2lPSGU5bUJmSFB1UURKOEptU1JHa0UyaGhIdTJUeXFJ?= =?utf-8?B?YWdoZFpEc0YwbGMzOGlySndjcjJYZ1B6RC9EZ214Y3RNSGhybE9lU2Z3WGF5?= =?utf-8?B?WWR3ME1GSExTMTNjRjg3c0hmZW0zcnY3NzRHYUxGSHZMYzhQb3VvWForSjZs?= =?utf-8?B?TmVwUW5IUGgybVV3elRiZWFaSDViWE80eXNwbVhNTWI0WWs4bXAyS05BKzl3?= =?utf-8?B?SmVDRW93TXlCQm41S1FFQlY5UHRnOHN2YWY1ZzEwL1FZK3Z1TkhPYTVKc0tP?= =?utf-8?B?S0xrOE9xTHdvcjhJYVpMdlpHRVJxKzFPT2JXS0dwQW9GY21wRW80dHRoamw0?= =?utf-8?B?cEFqd0FKWkhyN3dlSjJtV2FXekhMRUd6Y3ZiYlJBMk9qNXJvcC9uN3VNRFJ0?= =?utf-8?B?NHZ4Z2JTK1dYMlhyQjV4M3RkWTlvMmdjSEdWZEtjM29uZEczTkxvbUV2aGlN?= =?utf-8?B?TWNlaERsdnZQcmtvRVBES3RTVFhuR2NrMkNWclg5Y1BDQVhxS0R4MU1ycDRQ?= =?utf-8?B?bXdoVjA2dTFXMUREb04yYWtJWk1sbkdRYkFDbDFnWmFyVVVEVEl5UG1XcDBv?= =?utf-8?B?SEtsa200YU5XV1ZMWnVlY2I3cUhqZStsUFFaSW9JQ0Zya1picER2LzMrQmpN?= =?utf-8?B?UGhRREJGQ1p1MGY4T05OVTV5TGJHaDcrNFltSDBYNllYUWdQNjlpWVdtN0lt?= =?utf-8?B?aXhGcUhHS2VWQTJQbFdSU0ZsWXhLemU2andoaGRWTDNoVFRmQ0xjam1pVDdk?= =?utf-8?B?VmRNWnJSNXJJVEQ5TVMrc2FlYUsvUjNTbWo1SFdVQU5FZ042aWp6VE5LdnpR?= =?utf-8?B?djFTTFdUcHVlU2lYWElVTWI2bHVKTjVJR21CRGdEb2ltVGlWdjc3VHZ1emJV?= =?utf-8?B?a2VvZkplcG1GaE5xYWx4VlJDVm1LWVZWcnk1ZUdlZjVNV3dNR1FBc0NMdEVF?= =?utf-8?B?ZzVqL0tMQkJhR0lIZEJ0YktyRU9yNHpLVGtvSHN0Y1hCcFRpaXhDMC9zZ3pn?= =?utf-8?B?Z1dGUlh6TlE3QklSOVpMekFGNjR5SzhDOVMrTmRGSDlZWHdIMU5xT3FSZDFt?= =?utf-8?B?cGNsbjgxMXJtZmtCVGFRc3ZWSWxLcXNVaXZzZ2FRZk9McnR6VkIxc3hhVU5u?= =?utf-8?B?SXN3Y1YwcFc3VjArV3hCWllDb1JGTmQ4bm5BMEZTUjVsWTVuM2JZQi8zZFZy?= =?utf-8?B?RWtBUmZzVUp0dGJ4S0VEaEt1Q2dPNTBZYzRvb3h6QURsOXNlM1NIY0xON0Jp?= =?utf-8?B?d0NWS3dlZUtSRVhmWGlhbWVoZGdFNlp1UnFWRGltQjdlbFRtZndobEgxaGg0?= =?utf-8?B?THlvdUFRbkluWEdwcFc5aGk1WVJjRXlOUlZ3bTJmclRuQ1lndkVZWS9sS1B1?= =?utf-8?B?bWwyL2sxdERXcW1COHIzc2lqSm50YVNUYTdTL08vakkxNXZXbjJGOHgxNXZE?= =?utf-8?B?NS9TTFB1cnQ0OTg1RnZjNVpZc1ptUDZQNDVIQUFvdm5ob2oyb2NVTk9YcWx0?= =?utf-8?B?cEtKU1BsTHFSWHJKR0d4bU5sVGF4cWpiZlNIWmNpdHZNWnN6eDNweUgwUUIw?= =?utf-8?B?N3FYYWVkMXY2TVFtQk5BcHFwUHVkOXA2dzBUNlJBUjBodEVFcXlqV1dIVDFk?= =?utf-8?B?eTladVNCZnBiL0cwdlVKZDB0Tzg5UkF5UzNCUVhLOU1WNWdFS2RudTh1dTAr?= =?utf-8?B?VmVSbUZiRnFzMGRYakpGdW1Bc0xCeE9PL25Edi9FZk9QbEYxdDhMTUpIUUFH?= =?utf-8?B?dFR0VEhlVy9pQy9EeHBjWEdLRGl5ZVI5WHdxNjdPdlkwNisvOTBrRk1xZmRq?= =?utf-8?B?WVNsRHhxdEhSUG5Ca2tya3U1Q21DRlIwU1FPYXNlZ3gwYnVTUmpab0ZhMklF?= =?utf-8?B?bzU2T0RpM2hGcm42eE5rL0xXelVMZFh0MWZMQ2ZNRWZ4Y2lKTXkzY20rNm90?= =?utf-8?B?Vm5Xd0xTcE5paS9iY1FuRDh2TzJVb01mNW9HUFdwaVY3Q1dhY1pMdnFIaGFJ?= =?utf-8?B?MzR6ME9RQXoxTnlzdGlDSFpRcEtWZWhEclhISitTbkx0VnpTKzZzdGlnRzlD?= =?utf-8?B?NmZXMzdQT3ZqcUFOUU1zclgzMDBLZVVQT3ZmcEE0dWlKWFhjdkFUdHFIRnJM?= =?utf-8?Q?n+T8=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(7416014)(376014)(1800799024)(82310400026)(7053199007)(13003099007);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2025 06:10:16.6952 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bbe81110-594a-4e27-c88f-08de27fb79dd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002320.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5885 Hello Vineeth, On 11/20/2025 11:29 AM, Madadi Vineeth Reddy wrote: > On 18/11/25 00:25, K Prateek Nayak wrote: >> commit 1a6151017ee5 ("sched: psi: pass enqueue/dequeue flags to psi >> callbacks directly") modified the psi_enqueue() and psi_dequeue() >> functions to take the complete enqueue/dequeue flags but left the stubs >> for !CONFIG_PSI unaltered. >> >> Modify the stubs to also accept the flags argument to keep it consistent >> with CONFIG_PSI. >> >> Signed-off-by: K Prateek Nayak >> --- >> kernel/sched/stats.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/kernel/sched/stats.h b/kernel/sched/stats.h >> index cbf7206b3f9d..3323d773fec3 100644 >> --- a/kernel/sched/stats.h >> +++ b/kernel/sched/stats.h >> @@ -221,8 +221,8 @@ static inline void psi_sched_switch(struct task_struct *prev, >> } >> >> #else /* !CONFIG_PSI: */ >> -static inline void psi_enqueue(struct task_struct *p, bool migrate) {} >> -static inline void psi_dequeue(struct task_struct *p, bool migrate) {} >> +static inline void psi_enqueue(struct task_struct *p, int flags) {} >> +static inline void psi_dequeue(struct task_struct *p, int flags) {} >> static inline void psi_ttwu_dequeue(struct task_struct *p) {} >> static inline void psi_sched_switch(struct task_struct *prev, >> struct task_struct *next, > > Right. The commit that updated the function signature did not update the > !CONFIG_PSI stubs accordingly. This patch corrects that. > > Reviewed-by: Madadi Vineeth Reddy Thanks for the review. P.S. John has an alternate fix for the same at https://lore.kernel.org/lkml/20251118055242.4030849-1-jstultz@google.com/ That considers a blocked donor as a runnable entity from PSI standpoint. This series implements the alternate approach of blocking the PSI signals when the blocked donor is retained on the rq, skipping the block_task() and it enqueues the PSI signal back when the donor is woken up again. -- Thanks and Regards, Prateek