From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41B04C433ED for ; Mon, 17 May 2021 16:29:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 254EC61059 for ; Mon, 17 May 2021 16:29:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245156AbhEQQbE (ORCPT ); Mon, 17 May 2021 12:31:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243661AbhEQQaP (ORCPT ); Mon, 17 May 2021 12:30:15 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A003C08EB04 for ; Mon, 17 May 2021 08:13:07 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id c20so9779528ejm.3 for ; Mon, 17 May 2021 08:13:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=usbkl3eSbLJY48dNZ3F0WFUOcTmkoTvft5/B7CL2sSU=; b=kEuT1N5/kO7rAdEgl1j8JLVDuUgyk4mkEmZFl/+L8PvOtZmcdeETEi8LQMF8goxorE FHnZ92LpD8DQrwHOQnBY0OJtFifqJVScvJBJMt7TI/clMG9wx1CsJjBQx5H0QwNpwNqz MGfJd0FotdiakdxcCi9xYYnEwCAN2u0wOhxTnXByh1if0GaLk0sx0poV3LInQt1k+l8T YULNsLltGxmiW6JJkLVGH4BUgIznFMaEjApb9esqcBXB3UeNl8GhX9YL3Yf/61VvVBEQ 3/0oV9tncPFMDubvXrNbDEVU9mMc9AvFU3gIfELO3i7hr2vxS/xIirAA+Ma1oZ+/A3ZB woog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=usbkl3eSbLJY48dNZ3F0WFUOcTmkoTvft5/B7CL2sSU=; b=P6YDWzfrPWLZpZVT1zrK0Y5wLLnJ7PvW/y3bhdKEVdUvvsAKt9cnpzY3tpIO8q8qmF 4dyvvqh7ohEODUmEfOkqUS8TiYzP3Xr2AhsAjKKaPJgZAkoAuYEh3LuThzI+yj3UrBUQ 0UtED8fYcTDo4Up/Tk/hcsPGMQquZPDYIcNqV3NqG3FrI1Ck2PzDR5pt8AmSbCxpW/cJ z5CTMMZPQ3NYpM+N4YSIGOhaTEE8Jg38EMXeDPluBgCH2tOAO3yXykdEGe2yOkdpjl8Y ZzrrexcX/4bhpvzsSEybGbfR9hJ8mmBjGfJQ9LrwgXCBlZPf9GLiDkZ30eb6q1fy9Ec2 Y31A== X-Gm-Message-State: AOAM532wMbNKvFOvhztdG0qb8fowrCv11087cEEAizHw+I5HIuXdJ6wj V8aRuQ90i1KyCoXzhWuOjcNA5Q== X-Google-Smtp-Source: ABdhPJyz6c2G3oG+zPca9fjjDDqPHFgaRlOjr19GzNPtmUAVMbqQGJd82kvv2LT1kvF53lvygb3s8Q== X-Received: by 2002:a17:906:2559:: with SMTP id j25mr423050ejb.42.1621264386090; Mon, 17 May 2021 08:13:06 -0700 (PDT) Received: from [192.168.1.14] ([195.24.90.54]) by smtp.googlemail.com with ESMTPSA id z4sm11175002edc.1.2021.05.17.08.13.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 May 2021 08:13:05 -0700 (PDT) Subject: Re: [PATCH 1/3] v4l: Add Qualcomm custom compressed pixel formats To: Nicolas Dufresne , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-api@vger.kernel.org Cc: Hans Verkuil , Mauro Carvalho Chehab References: <20210429105815.2790770-1-stanimir.varbanov@linaro.org> <20210429105815.2790770-2-stanimir.varbanov@linaro.org> From: Stanimir Varbanov Message-ID: <892effb7-7a29-e016-c903-1a9bee6e9881@linaro.org> Date: Mon, 17 May 2021 18:13:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/29/21 10:10 PM, Nicolas Dufresne wrote: > Le jeudi 29 avril 2021 à 13:58 +0300, Stanimir Varbanov a écrit : >> Here we add custom Qualcomm raw compressed pixel formats. They are >> used in Qualcomm SoCs to optimaize the interconnect bandwidth. > > Wasn't reviewing, just skimming the lists, but s/optimaize/optimize/ > >> >> Signed-off-by: Stanimir Varbanov >> --- >>  .../userspace-api/media/v4l/pixfmt-reserved.rst | 12 ++++++++++++ >>  drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ >>  include/uapi/linux/videodev2.h | 2 ++ >>  3 files changed, 16 insertions(+) >> >> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst b/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst >> index 0b879c0da713..30b9cef4cbf0 100644 >> --- a/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst >> +++ b/Documentation/userspace-api/media/v4l/pixfmt-reserved.rst >> @@ -260,6 +260,18 @@ please make a proposal on the linux-media mailing list. >>   of tiles, resulting in 32-aligned resolutions for the luminance plane >>   and 16-aligned resolutions for the chrominance plane (with 2x2 >>   subsampling). >> + * .. _V4L2-PIX-FMT-QC8C: >> + >> + - ``V4L2_PIX_FMT_QC8C`` >> + - 'QC8C' >> + - Compressed Macro-tile 8Bit YUV420 format used by Qualcomm platforms. >> + The compression is lossless. It contains four planes. > > Would be nice to document if the bytesperline is meaningful or not. Basically, > what information need to be carried to other drivers ? I don't think that bytesperline has some valuable information, the important thing is the size of the memory buffer and it should be used to negotiate between v4l2 and drm for example. The layout of the buffer can be seen at [1]. [1] https://android.googlesource.com/kernel/msm/+/android-msm-bullhead-3.10-marshmallow-dr/include/media/msm_media_info.h -- regards, Stan