From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFA3F3E5ECC for ; Thu, 26 Mar 2026 11:33:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774524848; cv=none; b=pn2w6PbsBdwRNTlylonVow4AoPgv4K701TPl4smLViz7THlCtOhXibLqEVpqIXBETo1O6enoWGcKpMPI20DekDA0DgjFl7FcQEi2cSru3lFQHaKgxrvIzox7m8faxyaa3hCYnma6dCs2wxos0r+5CuaK4nDhllk/Ya0Heh00BMw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774524848; c=relaxed/simple; bh=p5eOJ8UP0LNtB9lHbCk2xWsNKUMoenzukYy1sW1T/LE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KOVTHqbfgPoTYdjUlQIGrnn7zUzbxaXhuzQ2NPhiUAMoC9PWllyzFmPF005IoxjFCOsdUR8e2McA8de5LlmH06V7uXs26UUTXw7yvCgsXRdNpzYzm6gdBHynhjzjnjvBNfd9hnOIFab6H16b743SBLugW0w8oM1DTo8Fwnjb3tw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TIqVfVqP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JCsDHUEy; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TIqVfVqP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JCsDHUEy" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62Q6Qblw1965106 for ; Thu, 26 Mar 2026 11:33:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GkKtJY/neo4snbhX1Pu52JIsgsMpo3+dszfpnntdauo=; b=TIqVfVqPEdWhtOZi DJo8cSNbuSSHbtoMOvX+WkGAuN2dX2GNXAcrWUJiPwhY/Yzu7ADAObnUeIT/p83R TXhMEXDOJ1Nmo8rzM8C1FzH771IOcHgNhM7MP8qx0NmNls/zXbk07Ke0WOZiVaBC vEEK42tTU9vewugowPLmYpGmRSUlcrI2tqE64hrPE+GLHAl+S9HWIBXBoi6cSbFc svNJu++SLY7zraZ1wPixjiAKQGK6jdhPPFQ8eTcztMVhP5Q9ylcYH8lkM2uZHLlC qy50LxgMeNjl1rrwZeeK8ixXDJ4mJcVoBdgr+p8wWlneSOEizU75mgPxosITis6P WW73dw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d4pymjky3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Mar 2026 11:33:58 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cfc4ba4de0so31400285a.3 for ; Thu, 26 Mar 2026 04:33:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774524837; x=1775129637; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GkKtJY/neo4snbhX1Pu52JIsgsMpo3+dszfpnntdauo=; b=JCsDHUEy3CxoXnq7GyLuuj9RPjuWi/sOO9qBxAQpjVxqUHXj1gSlAl6ItFY20nkgUf HrfpIw7Ca7Ae/rqsbww6Lj033R7diZ51e4XXc/6uqT+Jl0hinged+FxMV3mY/DU0ztNF QPq67oPetNHYpJDB6FfXToP9n6R3dgk8kFoj8v/gJhnMCpJyNpgjpvt0Bw8igFJXsvw0 OSYIc9k4JowwK5N6kJ9aHtc2xu3DztmkC7w889eqwm9Z6FEm87RD1q0/PA+rhdDM3a5X iQkwFUuGMyGb2leC8Vs1mfXsLklwaJ+5oZMhr+iHomOlQlTcelZ2J/EvGaqtCOI4+iTz 7f3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774524837; x=1775129637; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GkKtJY/neo4snbhX1Pu52JIsgsMpo3+dszfpnntdauo=; b=pROUiGyocgW1V02cqoNtI5asNTBzFA0ff5R5wm7e3qCUEbgWioa/9baek3tE3m7TF5 kfazGANpKsCxrqII0DtJosNiHL0IuMIk6/tFX7f5WRvU/uiDLrXdmyTA379vIhJuR1Fq ykNuMFFXrSSkkYXJuRlCBSYfTY1nOe3ZzdhkdMg/v/5D2MwatP1xXrYo35KFiCOJIr9m F31rjwEuslXQQ9RF1xQXRJn66wBAJdElZHd2O+RSRPZZ43ZfrczrYVQMX7nIZvBJbS4p fSVOJbqjJIViEyqJ/8TXS/KRZSE+iadcLYdW+zsRj98NN5+FmBbChP+uIR7lpEFmMLwS l+oA== X-Forwarded-Encrypted: i=1; AJvYcCXvPwKuy6sVsivC9pFkG3cg0A1cPuBMwPPvMpcxcMTV/+c4j44/pl2U1/PR3Rf7TScayEDy4SpMpG9Ua1E=@vger.kernel.org X-Gm-Message-State: AOJu0Yzuizsrkx8kw23DRdAN9dan9yYdpPu1nhdf0mPUKTbxlh7tcT7m v7rVn3H9rt/NkzWXie6/a9qROWLMJY+NZStozON/ybPuOiV20FVg6qjAyLTjZ3kaFRvNA9Zz1xv SzF1EKJL6nKB7nlgpesxSjJ/iNsH9sFAB6QIGwODdGMND3Sc3/LK9zD6cre9ZDKOslXA= X-Gm-Gg: ATEYQzy3Oh7/x4crBD0YlZz3WZA1VHUmDdNYuzk+Q8G8FaSuqt3iyPVSsLXHWsKXcde uVRW5yvXDTp/wWJGNhF1osWHc6WGzHJoLYKANYsLAVIeg9fDwbwjBBrIPMF7pr+2gkg9Mb0TY3L bLX8ikeI0B9lSdkMq19yDIg8RrYsFaBi7HFv3dedm4riZXXB29ZzAIbXqAzfY5kVjz6ggVMcye+ VVrPgS69oKBzhperYfk3TqD0HcJSGTLlSdo6DYwIxc/xeO7IOS4pxay8BJK20eJmQmkUE7R/t5Z EBWfJStn3c76VeaY6y8ENNGcRoTXxlIdH6LmmFQlgLmp/pLedwWD3YEpgeh+BSmLs8KrBQJTmk6 ci2SbqDyX6F09sesHAVnfvULAntcglyGga+MBqo7LyRxEBEDDEoNZLKbmHEAkN/YEaGZkUQgE0J RlPG8= X-Received: by 2002:a05:620a:711a:b0:8cf:c757:f1d1 with SMTP id af79cd13be357-8d001225dbamr713467985a.8.1774524837167; Thu, 26 Mar 2026 04:33:57 -0700 (PDT) X-Received: by 2002:a05:620a:711a:b0:8cf:c757:f1d1 with SMTP id af79cd13be357-8d001225dbamr713464385a.8.1774524836579; Thu, 26 Mar 2026 04:33:56 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66b0bdf75b2sm434716a12.3.2026.03.26.04.33.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 04:33:55 -0700 (PDT) Message-ID: <892fe03c-f3d5-4b6c-b821-95dad55fdade@oss.qualcomm.com> Date: Thu, 26 Mar 2026 12:33:53 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 3/3] arm64: dts: qcom: Add Samsung Galaxy Book4 Edge DTS/DTSI To: Maxim Storetvedt , andersson@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: marcus@nazgul.ch, marijn.suijten@somainline.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, abel.vesa@linaro.org, abel.vesa@oss.qualcomm.com, johan@kernel.org, konradybcio@kernel.org, kirill@korins.ky References: <20260322160317.424797-1-mstoretv@cern.ch> <20260322160317.424797-4-mstoretv@cern.ch> <881975ea-cc16-4b26-9672-731c146a1ba8@oss.qualcomm.com> <40e31e2f-84ff-425c-a7e9-f2df4210ddbc@cern.ch> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <40e31e2f-84ff-425c-a7e9-f2df4210ddbc@cern.ch> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: XsCATqGE9jkmBTs-HW9XWdZyUAJQh6DB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI2MDA4MCBTYWx0ZWRfX7GiDRx3nJ9qr EoS6uYbGp4H58bFGh8HvXZJA/ink9kmBXjAs5capJqy3nnkQUc/tKw9uJ14kPMw0aq9hYFjmVe3 YaxUClxgBJ5nS7lrG43bR9VcrbSjooOZFjbjruBUP60+toQvnzgAoNs6z+9zENE/dctgzgrkH40 RXePTsbCpp5SPCI1xxUOMK2cp2UHp4zItj4NpFlW12AvqvNOyfLzvlXAKcSaAwjUNzfHfX8CzFd vS11ZpIpmbEWfVNpxI/fBcSuKoOS0olNCIR9Jk9GiXGTihi1ROEHVtk2A56pJqyK3i3OSjgbPyy /gg4LebaP+oLLmRdU1RVqKFcOP1V7aiFAw3Bw49wV529TzpPHWLdqHXt5hplk86+d552w37sUDy +y9L0DbZgDbzInXqUP5K7qfT3qDpKGgpoEVzTuMaDM5KK/xVvIF/CacElhTGqXo4L2EpdIsRBQZ 4sUFp9SmjCkDPMOlEOw== X-Authority-Analysis: v=2.4 cv=SvedKfO0 c=1 sm=1 tr=0 ts=69c519a6 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=GZ5DO3GdeKtHaIBBAEEA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: XsCATqGE9jkmBTs-HW9XWdZyUAJQh6DB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_02,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603260080 On 3/25/26 7:30 PM, Maxim Storetvedt wrote: > > > On 3/23/26 13:17, Konrad Dybcio wrote: >> On 3/22/26 5:03 PM, Maxim Storetvedt wrote: >>> Adds devicetrees for the 14-inch and 16-inch SKUs of the Samsung Galaxy Book4 Edge. >>> >>> These use a common dtsi derived from nodes that were able to work on Linux >>> from the initial Galaxy Book4 Edge DTS by Marcus: >>> >>> Link: https://lore.kernel.org/all/p3mhtj2rp6y2ezuwpd2gu7dwx5cbckfu4s4pazcudi4j2wogtr@4yecb2bkeyms/ >>> >>> combined with the ongoing patch for the Honor Magicbook Art 14, and its downstream by >>> Valentin Manea, which shares device similarities: >> >> [...] >> >>> +&i2c8 { >>> + clock-frequency = <400000>; >>> + >>> + status = "okay"; >>> + >>> + touchscreen@5d { >>> + compatible = "hid-over-i2c"; >>> + reg = <0x5d>; >>> + >>> + hid-descr-addr = <0x1>; >>> + interrupts-extended = <&tlmm 34 IRQ_TYPE_LEVEL_LOW>; >>> + >>> + vdd-supply = <&vreg_misc_3p3>; >>> + /* Lower power supply is not enoug to work. */ >>> + // vddl-supply = <&vreg_l15b_1p8>; >> >> How should we interpret that? >> > > This was in the original patch, but using that same regulator appears to > be enough to also get touchscreen working on the 16" book4e. That said, > it still does not work on the 14". Something to revisit later... > >> >> [...] >> >>> +&panel { >>> + compatible = "samsung,atna40cu07", "samsung,atna33xc20"; >> >> I think it'd make sense to move the compatible from 'common' to the >> 16in DTS then too >> >>> + enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>; >> >> this matches the common definition >> >>> + power-supply = <&vreg_edp_3p3>; >> >> ditto >> >>> + no-hpd; >> >> really?? >> > One less thing to debug while previously attempting to work around the > "illegal link rate" error, which turned out to be related to eDP 1.4 > (similar to the sp11). I've kept it as-is in case other SKUs attempt > booting from this dts, such as the x1e80100 16" (as it might be getting > a black screen using the current x1e84100 16" dts, though this is not > fully tested). So do the 80100 and 84100-equipped SKUs of the laptop come with different displays? Konrad