From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA4142D94AF for ; Fri, 22 May 2026 07:41:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779435702; cv=none; b=Gr2W6hNvVB51vbfxn2z2oyYEb9OoZVsZKvXZv43YW8x0EzJSzqRM+2NfZsr8WKXggEXMjfwwEnh9viecNjnyymaB7LfEpfv7Toc4PUlqdTQ6UyMR4fQBcGcgV91/PxuzqqwP623u2FbKub+durJ+4U/wOK00yV60bTh1oE3/EZs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779435702; c=relaxed/simple; bh=1ilqqnZXwB75sj1gU5SXI1Nj9+h8HY3PA6r2A2sE+1Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aMLHcd6FxTrEsmXaiQhcsaueHEifmOPiDXdiGesz11TQGfzkYpmJhlFiWAFnOHeOs7oWuhEM1AwHVV3WksKwOHGfKufLbGLq08azHwu8o5Fca30aF9Nh2FTNnLKL08cIjDTeH4+M9rTb43s9h8PIZNd6YYFp6mqVHzK0uGDyUKk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DTfyLhow; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DTfyLhow" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 193681F000E9; Fri, 22 May 2026 07:41:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779435701; bh=s04p8sRBilefrJ3qNkPkFCTZXc1+vdhBxglscTg+Mgk=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=DTfyLhowZTtw1Uw3MclA7IUOAQagmqpcPHoNLlPbgqMsOZcyqaLVhHfgNBDozH5rj bQDiaY1wh1iLy6ltDF1ctnz0JZsjMsCZr1zQngQFYzIBPufrl8sSraGWtwHWroj3E7 Xt1PtpDayttJYbN+r6mfxQLCAsj5cLsC/gWTWLFqIy7+r3xRVIV7iK4cMWFm3NXer0 2qfFCBZCUS3AEzIkeX7P45yNCkWk912xadlOxYIHiwgbZ2+k7BFQ6CI5Jy5UyMW1DF kOF1bYJ6GM9P3kfEpha1F9IzsuYJ0oGBsDx+EbfCTrJX0yaejTUoU40InRAwebD74f FTp+Ptgh/ZlYg== Message-ID: <89333b92-103a-4c0b-822c-1b4f2f8185cd@kernel.org> Date: Fri, 22 May 2026 09:41:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/page_alloc: drop a misleading __always_inline Content-Language: en-US To: Brendan Jackman , Andrew Morton , Suren Baghdasaryan , Michal Hocko , Johannes Weiner , Zi Yan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260517-b4-drop-always-inline-v1-1-97b90930e8b8@google.com> From: "Vlastimil Babka (SUSE)" In-Reply-To: <20260517-b4-drop-always-inline-v1-1-97b90930e8b8@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/18/26 01:37, Brendan Jackman wrote: > get_pfnblock_migratetype() is called from outside page_alloc.c, so it > cannot always be inlined. Remove the annotation to avoid misleading > readers. > > At least in my minimal config, with GCC, this doesn't change > mm/page_alloc.o at all. > > Suggested-by: Vlastimil Babka > Link: https://lore.kernel.org/all/016c8bef-57ef-44ef-bf60-86dbfd368dcd@kernel.org/ > Signed-off-by: Brendan Jackman Reviewed-by: Vlastimil Babka (SUSE) > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index e262d1316259d..be7f5671d421c 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -434,7 +434,7 @@ bool get_pfnblock_bit(const struct page *page, unsigned long pfn, > * Use get_pfnblock_migratetype() if caller already has both @page and @pfn > * to save a call to page_to_pfn(). > */ > -__always_inline enum migratetype > +enum migratetype > get_pfnblock_migratetype(const struct page *page, unsigned long pfn) > { > unsigned long mask = MIGRATETYPE_AND_ISO_MASK; > > --- > base-commit: 0cec77cfd5314c0b3b03530abe1a4b32e991f639 > change-id: 20260517-b4-drop-always-inline-17702081c2aa > > Best regards,