mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno  <angelogioacchino.delregno@collabora.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: matthias.bgg@gmail.com, qii.wang@mediatek.com,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	jassisinghbrar@gmail.com, houlong.wei@mediatek.com,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, kernel@collabora.com,
	phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v1 03/18] arm64: dts: mediatek: mt6795: xperia-m5: Enable Frequency Hopping
Date: Mon, 27 Mar 2023 10:09:35 +0200	[thread overview]
Message-ID: <8937b354-a808-5e4b-94c4-f2c8a63945e2@collabora.com> (raw)
In-Reply-To: <ZB9jlTsEb0Clf1zu@duo.ucw.cz>

Il 25/03/23 22:11, Pavel Machek ha scritto:
> On Fri 2023-03-24 18:54:41, AngeloGioacchino Del Regno wrote:
>> Enable FHCTL with Spread Spectrum for MAINPLL, MPLL and MSDCPLL
>> as found on the downstream kernel for this smartphone.
>> Which one to enable, and at what SSC percentage, was found by
>> dumping the debugging data from a running downstream kernel and
>> checking the downstream code.
> 
> What advantages does this have? Lower EMI emissions?
> 

Hello Pavel,

this is done for multiple reasons, main one being lower EMI, but the effects
on functionality, depending on the actual board, may be quite dramatic and
ranging from lower WiFi and/or modem signal "sensitivity" (as in, for example,
having to automatically lower signal gain because of signal disturbance from
the conducted EMI ripple), to even a complete platform crash due to clocking
issues.

This is not about accounting for hardware quirks because having this situation
is totally normal and expected, especially on "particular" usecases such as
smartphones, where the actual board is typically much constrained in terms of
space, and where on the same board you have multiple components generating noise,
either wanted (a nfc/wifi/bt/2g/3g/4g/5g/something-else signal), or unwanted.

Cheers!
Angelo

  reply	other threads:[~2023-03-27  8:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-24 17:54 [PATCH v1 00/18] MT6795 Helio X10 and Sony Xperia M5: DT step 2! AngeloGioacchino Del Regno
2023-03-24 17:54 ` [PATCH v1 01/18] arm64: dts: mediatek: mt6795: Add Frequency Hopping Controller node AngeloGioacchino Del Regno
2023-03-24 17:54 ` [PATCH v1 02/18] arm64: dts: mediatek: mt6795: Add apmixedsys syscon node AngeloGioacchino Del Regno
2023-03-24 17:54 ` [PATCH v1 03/18] arm64: dts: mediatek: mt6795: xperia-m5: Enable Frequency Hopping AngeloGioacchino Del Regno
2023-03-25 21:11   ` Pavel Machek
2023-03-27  8:09     ` AngeloGioacchino Del Regno [this message]
2023-03-24 17:54 ` [PATCH v1 04/18] dt-bindings: i2c: i2c-mt65xx: Add compatible for MT6795 Helio X10 AngeloGioacchino Del Regno
2023-03-25 11:11   ` Krzysztof Kozlowski
2023-03-24 17:54 ` [PATCH v1 05/18] arm64: dts: mediatek: mt6795: Add nodes for I2C controllers AngeloGioacchino Del Regno
2023-03-24 17:54 ` [PATCH v1 06/18] arm64: dts: mediatek: mt6795: Add SoC power domains AngeloGioacchino Del Regno
2023-03-24 17:54 ` [PATCH v1 07/18] dt-bindings: mailbox: mediatek,gce-mailbox: Add compatible for MT6795 AngeloGioacchino Del Regno
2023-03-25 11:11   ` Krzysztof Kozlowski
2023-03-24 17:54 ` [PATCH v1 08/18] dt-bindings: gce: Add header for MT6795's GCE mailbox AngeloGioacchino Del Regno
2023-03-25 11:12   ` Krzysztof Kozlowski
2023-03-27  8:24     ` AngeloGioacchino Del Regno
2023-03-24 17:54 ` [PATCH v1 09/18] arm64: dts: mediatek: mt6795: Add support for the CMDQ/GCE mailbox AngeloGioacchino Del Regno
2023-03-24 17:54 ` [PATCH v1 10/18] arm64: dts: mediatek: mt6795: Add MMSYS node for multimedia clocks AngeloGioacchino Del Regno
2023-03-24 17:54 ` [PATCH v1 11/18] arm64: dts: mediatek: mt6795: Add VDECSYS and VENCSYS clocks AngeloGioacchino Del Regno
2023-03-24 17:54 ` [PATCH v1 12/18] arm64: dts: mediatek: mt6795: Add support for IOMMU and LARBs AngeloGioacchino Del Regno
2023-03-24 17:54 ` [PATCH v1 13/18] arm64: dts: mediatek: mt6795-xperia-m5: Enable I2C 0-3 busses AngeloGioacchino Del Regno
2023-03-24 17:54 ` [PATCH v1 14/18] arm64: dts: mediatek: mt6795-xperia-m5: Add Synaptics RMI4 Touchscreen AngeloGioacchino Del Regno
2023-03-24 17:54 ` [PATCH v1 15/18] arm64: dts: mediatek: mt6795-xperia-m5: Add Bosch BMA255 Accelerometer AngeloGioacchino Del Regno
2023-03-24 17:54 ` [PATCH v1 16/18] arm64: dts: mediatek: mt6795-xperia-m5: Add Bosch BMM050 Magnetometer AngeloGioacchino Del Regno
2023-03-24 17:54 ` [PATCH v1 17/18] arm64: dts: mediatek: mt6795-xperia-m5: Add Sensortek STK3310 Proximity AngeloGioacchino Del Regno
2023-03-24 17:54 ` [PATCH v1 18/18] arm64: dts: mediatek: mt6795-xperia-m5: Add NXP PN547 NFC on I2C3 AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8937b354-a808-5e4b-94c4-f2c8a63945e2@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=houlong.wei@mediatek.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=kernel@collabora.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=phone-devel@vger.kernel.org \
    --cc=qii.wang@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®