From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA08F331A76 for ; Mon, 2 Mar 2026 18:12:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772475161; cv=none; b=MrNvCQ3FaMEUw4DLlpM75UhOv1dfCQY39U0zTu4S7zNudkG7ggkHNtXqdYMYXILOczGc+RQvruR40GzSpiqui0ayoUD92rsCmOFj7/b0Gv6OUWbEpfjJtCYtG1Nrb3bVmZGDUV0TQgrM4PRSefmjVJu4FM/WUeE1QQk6dvBpWA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772475161; c=relaxed/simple; bh=hOaHl7xgoH9NNm4Pgd22IX+Qx3Mkn1Vn5XBCR/6m4aA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ajwCBZMLcNtau+bFchurc5cL/5IkRgQ7Xjxdm71NwJjPwnKOzN5vjeJ+g05U62onotvszoJmu4u3CL6QX00J7/z7c2QqcwPhgtiZ5gB7Pq0Gq1AAG8OzSyhhedFzj5zCIOLGZktRqa2cdzFw5ffM2M9cFHKCuazrIJ8PNtI12aU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WiJuAJR2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hjKLlTGQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WiJuAJR2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hjKLlTGQ" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 622H9jWb782739 for ; Mon, 2 Mar 2026 18:12:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Qvs6JsEJEphsd1VfOoRnt/bHD5uhVmAPnhjK60w7nJQ=; b=WiJuAJR2IYvAw+WN 15TkgRGHAjhTmNd72N+AuMapk6udlXbMUMqlqRM6xzforOKjNGzMpsZoHmWtlccw VXK8IrqsIDFw/viH5JYbw+lILDx/nUcI0xAYy/wCoDCbDgywSg9TNLjVrA28JN4W Gbf/ywx72vtTuqnrN3KQZwMKrfaHs7MaR8Wzr4M7o/1uLMPC2jJDYO67hE3mhAJJ 4l+F0cNkr01EnIdjM0KC8vd6Tkn/+E0GWoTEJ8vXZ5DhubOmmSew99H8UTfTlu6m QKMu+duUSiW0U1r3Ppxmvpx680tF2ovkPVPJ6Z9kdTgqYsAg1xBxY7XoTl6WBJSU iSdWKA== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cn7u01teq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 18:12:38 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ae5031c6c5so56878985ad.3 for ; Mon, 02 Mar 2026 10:12:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772475158; x=1773079958; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Qvs6JsEJEphsd1VfOoRnt/bHD5uhVmAPnhjK60w7nJQ=; b=hjKLlTGQNn/tOLvH1MOhiZ+DIjdiX9ik/1AzDTxbVTFUeZ5q2C+H6szu6hck7JcRzF 3CdU2pZOxhiSiH0nkLU/wdBl3VJ9015pzrxEabBdAA0kUHhFsQirT0jw3Fzp07Pw/2rb pLzt0JisPIpWiskSEy/INjjXI6Ql+tuHiAf+tETYZow9thdvg7NpEYE1zmKgYLX0Yt+A RdXDs0WHzs7cSALgbimvelrplW4JUUhr+GJcC5auTg1NKNBQeNaRwQYJAt8YE8DDJcI4 a79NGm350y+K/5YsbTRMMIstYdkFrPqKhqE0OlzXPe57MxmZdAhTfJnJ6ko58tkBHEG+ rpMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772475158; x=1773079958; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qvs6JsEJEphsd1VfOoRnt/bHD5uhVmAPnhjK60w7nJQ=; b=BVu0QhiGOWHuf7gp2OKQDxWDjN0KfO9ylsmwlJmYRMuAkGFrZFJxMR6YhSUExJWMba XROArGSvpMH/nWnmDCQ4+5tvTCvxIz4OmVsgJzn6GRbuDZs85re8ax+YhOdUoYrIxRNP RA5GVikwIEKUnNZhjz2OaWN9mwjZQiagLLngrNoj3G9QAQ7SzF77freM1W82oSjUfqVv 2U1OHAzwk31Jv73HjDcEOIxpHjsh4/mlB77f/RrxZJ/cOKDM00ORTyydv7bQVM8x0sQi qFFnoy0E0SAw5OWKSVDVT4chV84dyhO5pFHs0NfgUzYD6+I1AiCNaISVmAu6JiFaw5IV 4bOg== X-Forwarded-Encrypted: i=1; AJvYcCW6nNBgJMS9PGioaEi/b9Bm3wfdaDxr/kskSoOoOBv6Bb9RTAZmB5BlNYMzzy+sdRnWvMFDPDq8TiiuRZc=@vger.kernel.org X-Gm-Message-State: AOJu0YxKnEJ81SAJBjSQ/kedZZtlJVKGX6ALvQNTghQlf9OmUi3g3vpu EJqt2zzSvwZGhGESANn9THdxnZLmim5wCyo3Q7EEipKhRLJP8h8F2yzFGwZ6Zjwt8zTmahh0vIv q+EBuaQlaJgoy3s52J2Fs0WFHNk87ZmUh4Rgx1XRwMiiyZzmKISrqj/YeCa+Z1dSLzEFm2JwZB0 A= X-Gm-Gg: ATEYQzyylL6upLet4jeaNWZoFuZbVrRxb9oFwLIc+3Muv2EMnXiu9kG8WFPxf2Y9v95 AdlA+wehccnynMFlxQT/LhrgjJ2WuyauJY5/qf/RZMNxuEG9F582mxAAIreF6g1Y6j7Wgh0gKm/ F+/OGOlxWv8h4HWWT0Dwhxyx9YmU5PbDDZB7kCoAxajQ0Za09lcWZgQwNEmHUJr4PRyieJEt5OA bKnsEDby4La5gUREub01xPneCkLKZgcv+TyiZ/JkvnH6QNNZ0pt+I7ovEJd6HayTqTvlu/K1Itr bYNoipdn+Kd1hfk1Jdn7i8YfxCovyQ0vrbKD4QN31HKaNXGIUNS8dzOaYd5bVobIHzYRusf+efa N9oyAtU3MvztzSRNDyMCyRHCSK+t5oVf8XMJNTZ52sBY= X-Received: by 2002:a17:902:c951:b0:2a9:622e:fd46 with SMTP id d9443c01a7336-2ae2e035736mr140778565ad.0.1772475157561; Mon, 02 Mar 2026 10:12:37 -0800 (PST) X-Received: by 2002:a17:902:c951:b0:2a9:622e:fd46 with SMTP id d9443c01a7336-2ae2e035736mr140778255ad.0.1772475157005; Mon, 02 Mar 2026 10:12:37 -0800 (PST) Received: from [192.168.1.5] ([106.222.228.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb6b9b32sm191491435ad.66.2026.03.02.10.12.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 10:12:36 -0800 (PST) Message-ID: <8946c2fa-7b05-4f58-a11e-fa077dc0a267@oss.qualcomm.com> Date: Mon, 2 Mar 2026 23:42:32 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: qcom: ubwc: disable bank swizzling for Glymur platform To: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Rob Clark , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260228-fix-glymur-ubwc-v1-1-d80e3fe0dcc7@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: <20260228-fix-glymur-ubwc-v1-1-d80e3fe0dcc7@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=GMMF0+NK c=1 sm=1 tr=0 ts=69a5d316 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=5paVSw64R4kEUMRm3sSMUA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=COk6AnOGAAAA:8 a=IkhWcgckFE4J5cQLOdQA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDE0NSBTYWx0ZWRfXwUQFYWWR3mw3 crAIafDkEcBnuZvqNVIcf2JlbY9m8K8gTJKJDX7IjxYq+0R2keiOus2i6dfopq6vAAIMm5ml3T5 vrYoP0RrerBEVrnVDY9jh/HKCnThyUmzeZlKE8fr6AeqeCFUzfMmvbmKFt9ttRtbh3ozPfKw8P4 wQCxhHlaf5nkjKS054Qn6qzZ9EhhbYTzCNRcW8Kj6jFjMzzEa81hf9StoLCFOK+9c5krc5ZgdXt teolBUe8JqS+UGdy/A2Z6r26qRoOF3KnZSkJj6A8KabLIw8FOJ3ctfvz6Sfpz/GxqAbN0GK7+wA 9jXx4+xo/WtgOlrb98YhlkrdZIBCAxNDMJWWjRUMaN4tI3Kq8wi+N9hfYT0ENsV8LtqLAMH3bTY LjM7nXgwggNUvFpJ97pS1zvg3tiGpHcSkAe5tNdc9WWuYsyrkBxYfYPPOXgu3yLPsj2ujqtY4SE /8nbVVzIc/z3u/8E5Og== X-Proofpoint-GUID: S-nnvvACWYpqXLCDizqXZl61RgZ9d3VR X-Proofpoint-ORIG-GUID: S-nnvvACWYpqXLCDizqXZl61RgZ9d3VR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_04,2026-03-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 adultscore=0 priorityscore=1501 impostorscore=0 phishscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020145 On 3/1/2026 12:03 AM, Dmitry Baryshkov wrote: > Due to the way the DDR controller is organized on Glymur, hardware > engineers strongly recommended disabling UBWC bank swizzling on Glymur. > Follow that recommendation. > > Fixes: 9b21c3bd2480 ("soc: qcom: ubwc: Add configuration Glymur platform") > Signed-off-by: Dmitry Baryshkov > --- > drivers/soc/qcom/ubwc_config.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c > index 1c25aaf55e52..31e0d55c6d9e 100644 > --- a/drivers/soc/qcom/ubwc_config.c > +++ b/drivers/soc/qcom/ubwc_config.c > @@ -231,8 +231,7 @@ static const struct qcom_ubwc_cfg_data x1e80100_data = { > static const struct qcom_ubwc_cfg_data glymur_data = { > .ubwc_enc_version = UBWC_5_0, > .ubwc_dec_version = UBWC_5_0, > - .ubwc_swizzle = UBWC_SWIZZLE_ENABLE_LVL2 | > - UBWC_SWIZZLE_ENABLE_LVL3, > + .ubwc_swizzle = 0; > .ubwc_bank_spread = true, > /* TODO: highest_bank_bit = 15 for LP_DDR4 */ > .highest_bank_bit = 16, Reviewed-by: Akhil P Oommen We need a fix on the gpu side to properly handle this case. I will post a patch. -Akhil. > > --- > base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f > change-id: 20260228-fix-glymur-ubwc-f673d5ca0581 > > Best regards,