From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2765FC04AB5 for ; Thu, 6 Jun 2019 06:24:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E68122070B for ; Thu, 6 Jun 2019 06:24:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="pwQVtcio" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726541AbfFFGYq (ORCPT ); Thu, 6 Jun 2019 02:24:46 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:18829 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725267AbfFFGYq (ORCPT ); Thu, 6 Jun 2019 02:24:46 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 05 Jun 2019 23:24:45 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Wed, 05 Jun 2019 23:24:45 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Wed, 05 Jun 2019 23:24:45 -0700 Received: from [10.19.65.14] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 6 Jun 2019 06:24:42 +0000 Subject: Re: [PATCH V2] drivers: i2c: tegra: fix checkpatch defects To: Dmitry Osipenko , Laxman Dewangan , Thierry Reding , Jonathan Hunter , , , CC: Shardar Mohammed , Sowjanya Komatineni , Mantravadi Karthik References: <1559196850-7007-1-git-send-email-bbiswas@nvidia.com> <911e52ed-8f3c-583a-7610-e38723219eca@gmail.com> <2d83ad21-b012-1b3e-fc9a-741972ee3ba9@gmail.com> From: Bitan Biswas Message-ID: <89488516-a064-a1a0-9e3d-8234043201be@nvidia.com> Date: Wed, 5 Jun 2019 23:24:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <2d83ad21-b012-1b3e-fc9a-741972ee3ba9@gmail.com> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL103.nvidia.com (172.20.187.11) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1559802285; bh=A0EKOpcxSf6jypGXzxSbsk+o5ChWWgKynVYpvDClFmY=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=pwQVtciofapmmfptkDK4v975iSl9dM6h1y9B6e99JI3ft/ReUACHg7zVsbkQlQUOF rFcOSvvvQSqRz04KQaQ44YA7aWqGlS9dqO4c+mT970umX6oKsYT3h6HsNQaS0QNYyE ue+0SlkOnl+Mlxz5j4+zawMjMp5g0Y1Q15NK066KkCPs4AvUzp7adq8KV0+fhsWr2r wWdVOxr0K0lhr3BG73noS1zpBIM82jQkHNxM3j0MjGr2Km906NLqxIjzFj8YYvcluy qcE2OP79mcjOy8TlAx6gPnw2SzUBC86eLyT1L8Fal1T5pXI+QsFSIfZh4eS6+8SdII igWnHISZCrYFg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/31/19 5:45 AM, Dmitry Osipenko wrote: > 31.05.2019 12:04, Bitan Biswas =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> >> >> On 5/30/19 4:43 AM, Dmitry Osipenko wrote: >>> 30.05.2019 14:36, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>> 30.05.2019 9:14, Bitan Biswas =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>>> Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c >>>>> except for BUG/BUG_ON checks >>>> >>>> Please turn the BUG_ON's into WARN_ON's. The machine won't go on fire, >>>> hence there is absolutely no good reason in making system unusable on = a >>>> software bug. BUG_ON may be more useful for development, but not for a >>>> casual daily usage. >> I shall update the patch to remove the BUG/BUG_ON calls. >=20 > Please replace them with WARN_ON_ONCE. >=20 Based on review of the BUG_ON some were found redundant calls and hence=20 planned to be removed. Non-trivial BUG_ON planned to be replaced with=20 WARN_ON_ONCE call. -regards, Bitan