From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755527AbdC3FkT (ORCPT ); Thu, 30 Mar 2017 01:40:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34674 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754740AbdC3FkQ (ORCPT ); Thu, 30 Mar 2017 01:40:16 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6B9057AE92 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jasowang@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 6B9057AE92 Subject: Re: [PATCH net-next] virtio_net: don't reset twice on XDP on/off To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org References: <1490818456-6861-1-git-send-email-mst@redhat.com> Cc: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, John Fastabend From: Jason Wang Message-ID: <8949b5e9-602d-eef0-acdb-9f0f9a5a6f54@redhat.com> Date: Thu, 30 Mar 2017 13:39:49 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1490818456-6861-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 30 Mar 2017 05:39:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年03月30日 04:14, Michael S. Tsirkin wrote: > We already do a reset once in remove_vq_common - > there appears to be no point in doing another one > when we add/remove XDP. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/net/virtio_net.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index de42e9a..ed8f548 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -1810,7 +1810,6 @@ static int virtnet_reset(struct virtnet_info *vi, int curr_qp, int xdp_qp) > virtnet_freeze_down(dev); > _remove_vq_common(vi); > > - dev->config->reset(dev); > virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE); > virtio_add_status(dev, VIRTIO_CONFIG_S_DRIVER); > Acked-by: Jason Wang