From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB2F0C4332F for ; Mon, 12 Dec 2022 14:00:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233309AbiLLOAm (ORCPT ); Mon, 12 Dec 2022 09:00:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232529AbiLLOAi (ORCPT ); Mon, 12 Dec 2022 09:00:38 -0500 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60B7DD65 for ; Mon, 12 Dec 2022 06:00:37 -0800 (PST) Received: by mail-lf1-x129.google.com with SMTP id p8so18703522lfu.11 for ; Mon, 12 Dec 2022 06:00:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uXNjasCAMqOsg4AwZXK5gy3WyUBRJtec+Tu/Jp4jrQw=; b=NxzUJG6T+Im1jq8ga35JuknXDOmmVrmSyRQwnXdaYXpZ5j6jy5eS9o42QegY442r6Y SnnKVYmQyXW/0lA2ozQO15CIaHl90jrpDrcRDxaE/BC+5GpLpUVyISUYZ2Lqzj5aUhla XOC5f1e61kovwwIlZ2Np2Vw10Uox8NWHw3yc7WyELnbXs+t5G+ZKD4lp9CA1VBbpZeii sF+d01ghPWsqCNYOpJWTE0t8NQsRN6mg0y8ub2Yo6CKI61Y9fvA24hZFp/gY8qoc5HDP BYo6IOFZPoLfv+oYAgHbWZrRYjWvi1BZz/v6ikJHClpZSIP1FBZf3f2lWE9re/joRPUJ 0Xtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uXNjasCAMqOsg4AwZXK5gy3WyUBRJtec+Tu/Jp4jrQw=; b=uvl0GQlsgPdjkMJj7VVtJtQUxpqxt+xjYssgoeE6AmdY/wcWJK/EmC7u9b5BDPbWUA 5N93ATZYhrCVplJGduM5jJbbrQga5an5vGbEiUMBxue6w+vxX6xmRABB4zgqoay0hBNA dyv4PmE9jJTWpaAy68ofV2cjdFL8kxw54xoi8K64i5h3o8txGZd47cdK6jFKtfQ8VWYU wSAghbtr1xl+8rNTYoXTy8f25kw6sx9DKTCvYFaUV/7SwnZVFeHHbAg+M0oVOVvE5Rkd lG7Orbt7+YgM4NqpvOiiW2ArzPaKbHuJsF9Jmqo+nq29ThVh5oi+eT9awBkWf7byEy7j g0OA== X-Gm-Message-State: ANoB5pneBquvWQfURTUeyflqnRMk1MesoBoTw6mloDYo5Y4RCU9T4SjX a5KBJb29lEVlOP3n5idyi/NcnA== X-Google-Smtp-Source: AA0mqf76Z5LgwMdRcetNB2+IXivy9ORSfv9m/zYIe2DUINSY3rYdKIhoflCpAzaW6kN/AOO8Bhuucw== X-Received: by 2002:a05:6512:250f:b0:4a4:68b9:66d4 with SMTP id be15-20020a056512250f00b004a468b966d4mr4349072lfb.31.1670853635653; Mon, 12 Dec 2022 06:00:35 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id k38-20020a0565123da600b004b5a2a33972sm1638305lfv.40.2022.12.12.06.00.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 06:00:35 -0800 (PST) Message-ID: <894b930a-797d-3197-0c1a-5253ebb0a3f8@linaro.org> Date: Mon, 12 Dec 2022 15:00:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2 4/6] arm64: dts: qcom: sdm845: move DSI/QUP/QSPI opp tables out of SoC node Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221212100232.138519-1-krzysztof.kozlowski@linaro.org> <20221212100232.138519-4-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/12/2022 14:46, Dmitry Baryshkov wrote: > > > On 12 December 2022 13:02:30 GMT+03:00, Krzysztof Kozlowski wrote: >> The SoC node is a simple-bus and its schema expect to have nodes only >> with unit addresses: >> >> sdm850-lenovo-yoga-c630.dtb: soc@0: opp-table-qup: {'compatible': ['operating-points-v2'], 'phandle': [[60]], 'opp-50000000': >> ... 'required-opps': [[55]]}} should not be valid under {'type': 'object'} >> >> Move to top-level OPP tables: >> - DSI and QUP which are shared between multiple nodes, > > This makes me rise a question: on other platforms we have been placing the shared dsi opp table into one of DSI nodes (usually into the second one). Should we also move such tables up to the top level? Hmm, indeed I see SM8250. The location of the table from shared/non-shared point of view is one, but second problem is that DSI has address/size cells. DTC has additional checks for certain buses thus the QSPI table cannot be inside such node with address/size cells: Warning (spi_bus_reg): /soc@0/spi@88dc000/opp-table: missing or empty reg property This check is not triggered for DSI, but the concept is the same here - nodes with address/size cells are expected to have only properties, not other objects. See simple-bus: https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/simple-bus.yaml#L59 Best regards, Krzysztof