From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43C78C433EF for ; Mon, 20 Jun 2022 07:58:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239588AbiFTH6N (ORCPT ); Mon, 20 Jun 2022 03:58:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239522AbiFTH6J (ORCPT ); Mon, 20 Jun 2022 03:58:09 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17C8725D8; Mon, 20 Jun 2022 00:58:06 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id DF5CB660166E; Mon, 20 Jun 2022 08:58:03 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1655711884; bh=B+xTwEj2LWopnY2Mek8C1LH6BBhcx/zrcxMtLnoeiVA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Bx3CK9FAayRadGaBkxRj+jDh8Ivqjyz8uLq8JVnqfkvTTAcl7dsjQlbZ3H6jE5FoC vqcJ7Rgji2FSDrJFY+TW96nMRslPkAGFK0FkBemRiCkNwa2XEz4iSqGW+GmxYKaAaL oU6vnJi9MfLd4v1+cdzHl4XP14h5yhVrctSjyd+eRKIzJ08+38kW7WAhTrzzwdlQIj KRxr0LSjZv4u6Y+qAo36FuMDq1XHtz2hdy+cYVS2U1aOLxxbIJYcbxst/+CMmikcrj nLxkkoZPPPAI8JRcs+O52gs2Nork5+RJqR9rKhhq3G7vj9IhLi8+5BMI9XHjyYBVr4 mpHugrqh4gHHQ== Message-ID: <8956bb3e-60d7-a882-3672-f2a2f0bf858d@collabora.com> Date: Mon, 20 Jun 2022 09:58:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] media: mediatek: vcodec: Drop platform_get_resource(IORESOURCE_IRQ) Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Hans Verkuil Cc: kernel@collabora.com, Andrew-CT Chen , Lad Prabhakar , Marc Zyngier , Matthias Brugger , Mauro Carvalho Chehab , Rob Herring , Tiffany Lin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20220617203906.2422868-1-nfraprado@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220617203906.2422868-1-nfraprado@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 17/06/22 22:39, Nícolas F. R. A. Prado ha scritto: > Commit a1a2b7125e10 ("of/platform: Drop static setup of IRQ resource > from DT core") removed support for calling platform_get_resource(..., > IORESOURCE_IRQ, ...) on DT-based drivers, but the probe() function of > mtk-vcodec's encoder was still making use of it. This caused the encoder > driver to fail probe. > > Since the platform_get_resource() call was only being used to check for > the presence of the interrupt (its returned resource wasn't even used) > and platform_get_irq() was already being used to get the IRQ, simply > drop the use of platform_get_resource(IORESOURCE_IRQ) and handle the > failure of platform_get_irq(), to get the driver probing again. > > Fixes: a1a2b7125e10 ("of/platform: Drop static setup of IRQ resource from DT core") > Signed-off-by: Nícolas F. R. A. Prado > > --- > Tested on mt8192-asurada-spherion. Yep, that's totally necessary... Except the Fixes tag should be wrong here, as you're not fixing that commit, but the mtk-vcodec driver in relation to what's happening due to said commit. I get that you're trying to tell everyone "this is an urgent fix", though, and I agree that this *has to* get in v5.19 to avoid breaking this driver. Finally, for the code: Reviewed-by: AngeloGioacchino Del Regno ...but I think that you have to send a v2 that drops that Fixes tag. Cheers, Angelo