From: "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com>
To: Vasyl Gomonovych <gomonovych@gmail.com>
Cc: ssantosh@kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] soc: ti: knav_qmss: Use percpu instead atomic for stats counter
Date: Fri, 13 Apr 2018 09:19:07 -0600 [thread overview]
Message-ID: <89591f43-19c6-26b5-c0f7-e370721ec397@oracle.com> (raw)
In-Reply-To: <63d79bc4-2ee1-2350-2431-ae41b53b0914@oracle.com>
On 4/11/18 3:28 PM, santosh.shilimkar@oracle.com wrote:
> On 4/11/18 12:16 PM, Vasyl Gomonovych wrote:
>> Hwqueue has collect statistics in heavy use queue_pop/queu_push functions
>> for cache efficiency and make push/pop faster use percpu variables.
>> For performance reasons, driver should keep descriptor in software
>> handler
>> as short as possible and quickly return it back to hardware queue.
>> Descriptors coming into driver from hardware after pop and return back
>> by push to reduce descriptor lifetime in driver collect statistics on
>> percpu.
>>
>> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
>> ---
> This is really good idea. Have you tested this patch ? If not it needs
> to be tested on Keystone SOCs to make sure all works.
>
Thanks for confirming the tests done with rapidIO offlist. Will queue
this patch for next merge window.
Regards,
Santosh
next prev parent reply other threads:[~2018-04-13 15:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 19:16 Vasyl Gomonovych
2018-04-11 21:28 ` santosh.shilimkar
2018-04-13 15:19 ` santosh.shilimkar [this message]
2018-04-12 23:33 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89591f43-19c6-26b5-c0f7-e370721ec397@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=gomonovych@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®