From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Cc: linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
Michal Marek <mmarek@suse.cz>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>, Pedro Alves <palves@redhat.com>,
Namhyung Kim <namhyung@gmail.com>,
Bernd Petrovitsch <bernd@petrovitsch.priv.at>,
"Chris J Arges" <chris.j.arges@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
David Vrabel <david.vrabel@citrix.com>
Subject: [PATCH v11 11/20] x86/xen: Add xen_cpuid() and xen_setup_gdt() to stackvalidate whitelists
Date: Mon, 24 Aug 2015 09:45:51 -0500 [thread overview]
Message-ID: <895b04939b3de9a5edfbc6fa706ecc2b3c802a3a.1440423732.git.jpoimboe@redhat.com> (raw)
In-Reply-To: <cover.1440423732.git.jpoimboe@redhat.com>
stackvalidate reports the following false positive warnings:
stackvalidate: arch/x86/xen/enlighten.o: xen_cpuid()+0x41: can't find jump dest instruction at .text+0x108
stackvalidate: arch/x86/xen/enlighten.o: xen_setup_gdt.constprop.23()+0x2e: kernel entry/exit from callable instruction
The first warning is due to xen_cpuid()'s use of XEN_EMULATE_PREFIX to
insert some fake instructions which stackvalidate doesn't know how to
decode.
The second warning is due to xen_setup_gdt()'s use of an lret
instruction, which stackvalidate normally doesn't allow in callable
functions. But this seems to be a valid use of the instruction.
Add both functions to the stackvalidate whitelist.
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: David Vrabel <david.vrabel@citrix.com>
---
arch/x86/xen/enlighten.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index d9cfa45..4ca89ac 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -32,6 +32,7 @@
#include <linux/gfp.h>
#include <linux/memblock.h>
#include <linux/edd.h>
+#include <linux/stackvalidate.h>
#include <xen/xen.h>
#include <xen/events.h>
@@ -345,8 +346,8 @@ static void xen_cpuid(unsigned int *ax, unsigned int *bx,
*cx &= maskecx;
*cx |= setecx;
*dx &= maskedx;
-
}
+STACKVALIDATE_IGNORE_FUNC(xen_cpuid);
static bool __init xen_check_mwait(void)
{
@@ -1443,6 +1444,7 @@ static void __ref xen_setup_gdt(int cpu)
pv_cpu_ops.write_gdt_entry = xen_write_gdt_entry;
pv_cpu_ops.load_gdt = xen_load_gdt;
}
+STACKVALIDATE_IGNORE_FUNC(xen_setup_gdt);
#ifdef CONFIG_XEN_PVH
/*
--
2.4.3
next prev parent reply other threads:[~2015-08-24 14:50 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 14:45 [PATCH v11 00/20] Compile-time stack validation Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 01/20] x86/asm: Frame pointer macro cleanup Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 02/20] x86/asm: Add C versions of frame pointer macros Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 03/20] x86/stackvalidate: Compile-time stack validation Josh Poimboeuf
2015-08-26 14:26 ` Andi Kleen
2015-08-27 14:29 ` Josh Poimboeuf
2015-08-28 17:26 ` Andi Kleen
2015-08-28 19:54 ` Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 04/20] x86/stackvalidate: Add file and directory ignores Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 05/20] x86/stackvalidate: Add ignore macros Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 06/20] x86/xen: Add stack frame dependency to hypercall inline asm calls Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 07/20] x86/paravirt: Add stack frame dependency to PVOP " Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 08/20] x86/paravirt: Create a stack frame in PV_CALLEE_SAVE_REGS_THUNK Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 09/20] x86/amd: Set ELF function type for vide() Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 10/20] x86/reboot: Add ljmp instructions to stackvalidate whitelist Josh Poimboeuf
2015-08-24 14:45 ` Josh Poimboeuf [this message]
2015-08-24 14:45 ` [PATCH v11 12/20] x86/asm/crypto: Create stack frames in aesni-intel_asm.S Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 13/20] x86/asm/crypto: Move .Lbswap_mask data to .rodata section Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 14/20] x86/asm/crypto: Move jump_table " Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 15/20] x86/asm/crypto: Create stack frames in clmul_ghash_mul/update() Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 16/20] x86/asm/entry: Create stack frames in thunk functions Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 17/20] x86/asm/acpi: Create a stack frame in do_suspend_lowlevel() Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 18/20] x86/asm: Create stack frames in rwsem functions Josh Poimboeuf
2015-08-24 14:45 ` [PATCH v11 19/20] x86/asm/efi: Create a stack frame in efi_call() Josh Poimboeuf
2015-08-24 14:46 ` [PATCH v11 20/20] x86/asm/power: Create stack frames in hibernate_asm_64.S Josh Poimboeuf
2015-08-25 8:05 ` [PATCH v11 00/20] Compile-time stack validation Ingo Molnar
2015-08-25 15:25 ` Josh Poimboeuf
2015-08-26 7:07 ` Ingo Molnar
2015-08-26 8:44 ` Jiri Kosina
2015-08-27 13:11 ` Josh Poimboeuf
2015-08-28 8:21 ` Ingo Molnar
2015-08-28 13:54 ` Josh Poimboeuf
2015-09-14 13:19 ` Ingo Molnar
2015-09-14 14:10 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=895b04939b3de9a5edfbc6fa706ecc2b3c802a3a.1440423732.git.jpoimboe@redhat.com \
--to=jpoimboe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=bernd@petrovitsch.priv.at \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=chris.j.arges@canonical.com \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=namhyung@gmail.com \
--cc=palves@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®