From: bot+bpf-ci@kernel.org
To: odys.yuan@gmail.com,ast@kernel.org,daniel@iogearbox.net,andrii@kernel.org,eddyz87@gmail.com,memxor@gmail.com,martin.lau@linux.dev,song@kernel.org,yonghong.song@linux.dev,jolsa@kernel.org,emil@etsalapatis.com,ihor.solodrai@linux.dev,shuah@kernel.org
Cc: bpf@vger.kernel.org,linux-kselftest@vger.kernel.org,linux-kernel@vger.kernel.org,odys.yuan@gmail.com,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,mason@kernel.org,ihor.solodrai@linux.dev
Subject: Re: [PATCH bpf-next 2/2] selftests/bpf: Skip libarena on kernels with too many possible CPUs
Date: Fri, 9 Oct 2026 02:37:45 +0000 (UTC) [thread overview]
Message-ID: <895e3fd053ba93b849a81ecc54b4aaaf7f244dfdc0f354a01ac6e89a2400bfc3@mail.kernel.org> (raw)
In-Reply-To: <20261009-selftests-bpf-libarena-nr-cpus-v1-2-e726ccc66fc6@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2022 bytes --]
> selftests/bpf: Skip libarena on kernels with too many possible CPUs
TL;DR: Nit only: the libarena selftest skips silently on too many possible
CPUs; suggests printing a reason first, as arena_spin_lock.c does, though
leaving it may be acceptable.
> diff --git a/tools/testing/selftests/bpf/prog_tests/libarena.c b/tools/testing/selftests/bpf/prog_tests/libarena.c
> index daade4150af6..070a08856ee0 100644
> --- a/tools/testing/selftests/bpf/prog_tests/libarena.c
> +++ b/tools/testing/selftests/bpf/prog_tests/libarena.c
[ ... ]
> @@ -240,6 +240,15 @@ void serial_test_libarena(void)
> if (!ASSERT_OK(ret, "arena_alloc_reserve"))
> goto out;
>
> + /* Skip on kernels with more possible CPUs than arena spin locks support */
> + ret = libarena_run_prog(bpf_program__fd(skel->progs.arena_buddy_reset));
> + if (ret == -EOPNOTSUPP) {
> + test__skip();
> + goto out;
> + }
> + if (!ASSERT_OK(ret, "arena_buddy_reset"))
> + goto out;
> +
This isn't a bug, but a subsystem guideline flags a test that skips for a
missing capability without printing any reason.
When arena_buddy_reset returns -EOPNOTSUPP, this path calls a bare
test__skip(), so the test log shows SKIP with nothing indicating why. The
explanation only exists in the source comment above the call.
The sibling prog_tests/arena_spin_lock.c prints a reason before skipping
for the same condition:
printf("%s:SKIP: CONFIG_NR_CPUS exceed the maximum supported by arena spinlock\n",
__func__);
test__skip();
Would it make sense to print a similar message here before test__skip()?
On the other hand, test__skip() takes no message argument, and the existing
skip in run_libarena_parallel_test() for a disabled parallel test is also
bare, so leaving it as is may be acceptable.
[ ... ]
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/37873620927
next prev parent reply other threads:[~2026-10-09 2:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 1:49 [PATCH bpf-next 0/2] selftests/bpf: Skip libarena when arena spin locks are unsupported Qiliang Yuan
2026-10-09 1:49 ` [PATCH bpf-next 1/2] selftests/bpf: Return the lock error from buddy_init() of libarena Qiliang Yuan
2026-10-09 2:37 ` bot+bpf-ci
2026-10-09 1:49 ` [PATCH bpf-next 2/2] selftests/bpf: Skip libarena on kernels with too many possible CPUs Qiliang Yuan
2026-10-09 2:37 ` bot+bpf-ci [this message]
2026-10-14 19:51 ` [PATCH bpf-next 0/2] selftests/bpf: Skip libarena when arena spin locks are unsupported Emil Tsalapatis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=895e3fd053ba93b849a81ecc54b4aaaf7f244dfdc0f354a01ac6e89a2400bfc3@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mason@kernel.org \
--cc=memxor@gmail.com \
--cc=odys.yuan@gmail.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®