From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C748139E6FF for ; Thu, 15 Jan 2026 14:05:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768485942; cv=none; b=Gezs8SXE1bJpiZL7kqb/C/zZPBSU3tW1KnVW5Mx7MJ+j6wumvXNRLHBlOji2+w66P81ayl7TUBlsfetfF7DCnKyywXHKN1kl5E5BfDAZYVGVKrqTTPVI2eFodUhXwBempdt5Ct/qRZ+Sm6eFj1WlyhAqQkiIqFmu0lmsoIN1kw8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768485942; c=relaxed/simple; bh=kZUdwyeP1mnIFxtNDKSNzJMBi8Z/yJpOn0c5q0WuxE8=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=tnxOhZBlZw3oZS5NfjmGV/VdffH6tWIMHQet9+N766FX4S8Tth108NJhLRqTdJOUEx1xsq4zMhZWZAokE5RhRXolhz3LarflvAwmNmcgvYVkKN1+XPv2RvGZ07E/T1BaoT0bPm9rcfzA2IyuQUYi2VB5lOP75LjX8g0oBI2Sci4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KIavuc9X; arc=none smtp.client-ip=209.85.221.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KIavuc9X" Received: by mail-wr1-f68.google.com with SMTP id ffacd0b85a97d-43284ed32a0so537411f8f.3 for ; Thu, 15 Jan 2026 06:05:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768485939; x=1769090739; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=GYvocclPNzuO2Xle2lrVn+hLTZXEdchNTRgU0mDAfI4=; b=KIavuc9XrT1C2IeH5Cc2MkLv6pTIsAA/OJ5NA/iFD7GuPrEI1zz7bV10OkxdWBlYqd xgYOmNkiGkZkrDk69qpRBLK/X9bVzqlRlIaObxT3WmpfQUbeu5KFJM/qhDh//tbS/YV+ WuiXbkGoEaFKe6lBPDkWKqc4IfPa0MjDrcRXS8wo0boMbDrlDmMh7SQQY5h+fAcMry/J jOUTxlfmrOpyknevGFa7giPucUnpBDNLw3r1zgJp79sSeNqg8waoEAoRDni2C+/uu9At yRWdiM9fPX3A2Is1qV1sQkz79pRtoOHk12QeTekVkOn66gS8JFpKM5O6Qw/icEGu2Y+x Jd4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768485939; x=1769090739; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GYvocclPNzuO2Xle2lrVn+hLTZXEdchNTRgU0mDAfI4=; b=em4pOOQJhy3u8R8Hj2lIzzEozicHtT4dSjapg2L9Lo2opACm+mvdoVNYCgauY+IzWN /tQCtrf5VSvlnsgSHClLFLQTRHg6FoV+hhavyRpP5LZnu4/wob+yOV8+fdspZD7CZGYK dxczXZz/1fwWV7a8ReXtFFvhmOAvLqKbCoBRO2+1KPhp+NFzSeoOta4OZYPd4IHt8lJO SgwVrQryccnbzFnzEIUvn7xg3i/ysIXM7L27kYciGI7QEi1DWLqAGu0JhdgD/n2srcWI fRU2LxR5GNsvR69I9s8bA+xlwW3dnk0+y2Iy8vXgnyUZaTOTriRpXFpBJU3dHoJNooCf 2Oqw== X-Forwarded-Encrypted: i=1; AJvYcCUnxyjPqe8btzYStQdC7LLIvYMJdRprZlomMg+ZnnvPaCCghoDsHFrEINw4taXRQuZq2Nr9A/9DLxMwx3I=@vger.kernel.org X-Gm-Message-State: AOJu0YzoG5KnJ+uIZbwkOnVfAYwEYuqE4X6IKpi0oXp5Qv5rCQyOjVIZ IF2JsXmEjykJy84cQ+dHdcqHtDKjHSLyHUZj5VHQ/D8b+idNFxz9SGUZVaIUcF6gKig= X-Gm-Gg: AY/fxX6x18+Xbg5CNwIDtrUtieeL/xSHtIuiAhPUkS1t8nodOByqUzYQEo9piG1AUtC dZXNeCTVtTAGG53NpHerAhZFBjKnXwAL33WXbAgmK7YweFqO3TqMQRiPWqsWqzip/vEe2d+FcEP 1CSqE/EGUP7JP3dlD/OfsGbBE37T1PV5EMSrNGJc0hq6xe2YftaqYBaVOujf49WfxZbMAIFaFff ETn3WrO+H6NxNhRGuIfsHIoXupTRedNrrMr7oWc1+AiA/UJ1Pxfv2iWGGS4UXYLwowqYHC9t/5f xFYTsQTnuoUt3Vbk/9VWuhCqsyYO5igZWEH1o8s6Gqgd2FQS34eTH+82M1LHB5V+z+WC6JIga1S hiBymRGfb1he0QfPnD09DEanuNWpLIxeVoW4IuEexijC7NIL233PdcZfkB08NMUDu5uWH4Xovpe PLQXOTZscCcqVxO1e8+umNFNPeLbXmlGm5dk3Xyv8s2mubnLvjHhyb/DhmzMH7t+M= X-Received: by 2002:a5d:5f52:0:b0:431:8f8:7f17 with SMTP id ffacd0b85a97d-4342d59bf78mr7749285f8f.10.1768485938970; Thu, 15 Jan 2026 06:05:38 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:d283:7a7e:4c57:678d? ([2a01:e0a:3d9:2080:d283:7a7e:4c57:678d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-434af6fc8dcsm6215675f8f.40.2026.01.15.06.05.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jan 2026 06:05:38 -0800 (PST) Message-ID: <89634869-7858-45b7-bc2c-81436e028b83@linaro.org> Date: Thu, 15 Jan 2026 15:05:37 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 2/2] arm64: dts: amlogic: add the type-c controller on Radxa Zero 2 To: Ricardo Pardini , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260114-arm64-dts-amlogic-radxa-zero2-additions-v1-0-8b5cdf328fde@pardini.net> <20260114-arm64-dts-amlogic-radxa-zero2-additions-v1-2-8b5cdf328fde@pardini.net> <1f256bf2-2739-4785-88fd-25101df9dad9@pardini.net> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <1f256bf2-2739-4785-88fd-25101df9dad9@pardini.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/15/26 14:59, Ricardo Pardini wrote: > Hi Neil, > > On 15/01/2026 14:00, Neil Armstrong wrote: > >>> The Radxa Zero2 has an FUSB302 controller on i2c3 at address 0x22 and >>> INT# wired to GPIOA-13. >>> >>> +        interrupts = <13 IRQ_TYPE_LEVEL_LOW>; >> >> OK it seems I did read too fast, this should be 74 ! >> >> S922X Datasheet (same as A311D for this) >> >> Table 6-32 GPIO Interrupt Sources >> >> --------------------------------------------- >> | Input Mux Location    |    Description | >> --------------------------------------------- >> | [76:61]        |    gpioA[15:0] | >> --------------------------------------------- >> >> So gpioA13 ==> 74 > > Indeed. Sorry for this. > >>> + >>> +        vbus-supply = <&ao_5v>; >>> + >>> +        status = "okay"; >> >> And I get: >> >>    DTC [C] arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dtb >> arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dtb: fusb302@22 (fcs,fusb302): 'connector' is a required property >>          from schema $id: http://devicetree.org/schemas/usb/ fcs,fusb302.yaml# >> >> Please add a minimal connector, like: >> >> +               connector { >> +                       compatible = "usb-c-connector"; >> +                       label = "USB-C"; >> +                       data-role = "host"; >> +                       power-role = "source"; >> +                       source-pdos = ; >> +               }; >> >> I'll drop this change from my tree. > > Again, my bad. My intention here was a "minimal" description, mostly to reserve 0x22 so end-users can run `i2cdetect` or such on the 40-pin exposed i2c3 and not be surprised. Guess I didn't run dtbs_check hard enough and missed the required connector. > >> >> And you may also add support for the superspeed mux to switch the USB3 polarity. >> >> I have a prototype at https://gitlab.com/superna9999/linux/-/tree/topic/ amlogic/radxa-zero2/fusb302?ref_type=heads > > I'll try your prototype. I had no idea it actually had those capabilities. > > Do you think it is worth to resend this with just the fixed 74 pin & the minimal connector as you suggested? Now that I've seen your work, a "add FUSB302" that does nothing (while being capable) feels frivolous and confusing. Yes please resent with the interrupt fix and minimal connector, I'll rebase my work on top. It still needs some testing, but I'll be happy if you test it on your side aswell. Neil > > Thanks, > Ricardo > > >