From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933389AbcKVO1P (ORCPT ); Tue, 22 Nov 2016 09:27:15 -0500 Received: from esa2.hgst.iphmx.com ([68.232.143.124]:3637 "EHLO esa2.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932605AbcKVO1M (ORCPT ); Tue, 22 Nov 2016 09:27:12 -0500 X-IronPort-AV: E=Sophos;i="5.31,533,1473091200"; d="scan'";a="34568842" Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Damien.LeMoal@wdc.com; Subject: Re: [PATCH] f2fs: fix 32-bit build To: Arnd Bergmann , Jaegeuk Kim References: <20161122142033.1680054-1-arnd@arndb.de> CC: Chao Yu , Yunlei He , Fan Li , , From: Damien Le Moal Message-ID: <896398fe-d971-1166-faa8-de2ff005cc70@wdc.com> Date: Tue, 22 Nov 2016 23:27:00 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20161122142033.1680054-1-arnd@arndb.de> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [199.255.44.5] X-ClientProxiedBy: SN1PR01CA0042.prod.exchangelabs.com (10.165.224.52) To BL2PR04MB1969.namprd04.prod.outlook.com (10.167.97.141) X-Microsoft-Exchange-Diagnostics: 1;BL2PR04MB1969;2:1fTRRprG+jYq986ab351Jpg+d1ctkRHFWpnE5K3WzPKL9gn5Xwcml8Eu6vAIch9pP3i9/NYqP91pnIAWhSvjfbb4hY7IbPCOOOHebX4Rqs1vZUiIw1+NQf5nLTlq2WGc8cgEsJjh4HWokHxbFfATU1+cTPQ8hBzLVcj/xk6VFTo=;3:w4QE35+OMDeWJWTWmMjdth688oEWG9uTzFtE+c8/51yGM5QVelWTyXSxvx97WF/DyJ7k4i441BkmXxtLMehBxIHSDlf4jeB1cFUCE2PZPBF1vIXksvuf83Y7pRLjbhloc+njEmbovUVGSF1cdCLQkdvrAwZjuuJZjlHCJKhq3iU=;25:eWJOwKkjuqIWq3TvZQs0dD8v0JFV9HooK4IeiyzYLtY7ygClQpcewP7Qtq6KtbZY0IlhEEyhwuxYe2c6isx98B9l1Ok/HzaLzZF0RDxi2T/nG3VKd1lvQz/v9qvHVuX25ZS8A0Dih3ypEIe0DyIus4SeNeunoPIsvWV7T1nYdrDt0v/Zd+X9J5mBcec9zC07Y1k5RJBtwzBLTEFvyikIgRCh9LPM1EpqBmnojMDjGOah9Nthcamfhi4qExihwyhILTetjNzoNtVv6MSQaSe/+W8iLeWULNXB7y1/mxbnULdwxNK/mDUyDTD2Uc0T55UyBNUmEUX6e3irf/O1o/1SzuV7Xlzc30AJBPwCkUshxuFmhw5tlaops/efzjbIDinhZcngHRUr06C8a4phIqj2/FUoQ5Vo5ycxUHnPeOR+J0wLbAacBs7o2kKqXsI2OiS9iNF/YcyDvZ+ZQIYvkT98YQ== X-MS-Office365-Filtering-Correlation-Id: 718743e6-3a72-49fa-d9e0-08d412e3a3de X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BL2PR04MB1969; X-Microsoft-Exchange-Diagnostics: 1;BL2PR04MB1969;31:0m3BdG/wJJePXJi/vJBx0kBDSbGz7c+A50QevufctXnGfCKvVV6jESSPWsNPhyQwBtVoWu3qaKGrMWotJt97ZovDlRjWewXkU8uL9SZHRLkYiEMoZfY25MUP/F9W490L4zy1eMWV2Xb1X1/YvDlPmvGhOmL5pj+h535ailpSPZ/V/HMP0k9AzZX9fLpcRyMGpsWNV0nY3qrLtiGdlsNU4hVLzEoPFDhiATkttqPcvV5UiSlrzWlMJlQ7rDZ60dywk4C3rynA1/u6DEtc/irHfQ==;20:OgnyY6wyqPeE2F8mN4YnuCVBG3iTi7VqGstGpzZoY1eja45FTmhfcfxdWzqGsusQxz4vXWd+QJG6sJril7negSvtgXmMxZ2/0OiOB7y2tWzevsqPhO57pLA9u394nExR6+fk0ChL2BDb6CT/OfkdPKHXuVVAiWRH9oUYixNsJH/y+JqZakqTsBEG95WsABMzddi8DKn4G+XjUy9m+nto4JvKdIrqUdhE0MEXZSCb01lNWbzd+QIeZgVEzwwdPuILzGlvpDsHBXsH3i6NU4rxunh4IlJuqDX2C/qXN3NxVLpQtvJfdra9h3yo/U7MAU95ASGlvPPiQ51uGXVIUhuM45re8CCzdI74sXyBo/udrWkolC2XZFpL+aNA7xfFwsWr+WL7051ojsVdAX0XHgszd2Co1UzxZHzyuCpPQ12bsgOZ2+xKdqvrWcSezdCW0CKMimSq+hbztBtIormAMNRmdf/L48TwLurL3crjmk5UWnS4P6Msdq8NK8cqKuuv5/FD X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(79135771888625)(67367480688388)(56741022784758); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6060326)(6040307)(6045199)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6061324)(6041248)(6072148)(6042181);SRVR:BL2PR04MB1969;BCL:0;PCL:0;RULEID:;SRVR:BL2PR04MB1969; X-Microsoft-Exchange-Diagnostics: 1;BL2PR04MB1969;4:7/WuIbfprGZDBAalgg/gmF35jNLP3kdIjfMzKxxYHY+tMX/SDxgxu01PyPYJvPevolGEF9Q6fEIIoJlqTkXYINjGYToa5xLCGmIdbAoXCdZafcHZ2rj2qnUXwBxn368rOXTqWFb2/aSrfaTEhSmq6XZMVdrPKVrvyua/lYAmGLp92mBi0sVeZY1bHt2SKINOm+6HQEuc6EtA/rB307hJvHmla7IImvVeplQWs9H7SC+C/pmfH/Gigi1iukuaga4BOX/JXdzS5sTapce4crRzDkh/aJ3mN3ejpkP11hOCIHYxt+qe9+M+j1hGpcBACNAabkUQHfXNWBm/TGQ16uSSrolktM+93eYyBAyRJcSagOvCrP7fWlwKZHAt8hqrCS9axRKveyvQMH/t2VfvIDIjinMFMoiKyaT9EeV94iY6GHfA/VjssNg0GAsvN+CyoN6zRPkGPwsAGIljKCD9ZtnaTirPIvZZVgfq9GBkgxeNvB16J1pNYAu89A/5JOPLVsD8p2T39vA6+NUCzgpVz8TSaiSpjSrAQG2nftbJN5aXCe4vl+srfRZGHThFjXs4y1LQXHhkUpQvMVA4e1lkGOthO+X9T2k2Y9EjcPdkZMDyL10O1SfyjYMDpWmW2goOCzmUFWaIVy2ThbnALzrTqf46Ug== X-Forefront-PRVS: 0134AD334F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(377424004)(199003)(189002)(5001770100001)(50466002)(97736004)(8676002)(81166006)(81156014)(106356001)(47776003)(42186005)(23746002)(65826007)(31686004)(38730400001)(15974865002)(2950100002)(68736007)(4001350100001)(33646002)(36756003)(92566002)(6666003)(65956001)(66066001)(7736002)(50986999)(5660300001)(229853002)(76176999)(54356999)(7846002)(77096005)(189998001)(31696002)(101416001)(65806001)(3846002)(6116002)(86362001)(105586002)(83506001)(2906002)(64126003)(305945005)(230700001)(4326007)(7099028)(5005270100013)(18886075002);DIR:OUT;SFP:1102;SCL:1;SRVR:BL2PR04MB1969;H:[10.84.70.42];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BL2PR04MB1969;23:oJSAjb+k4qK65tLsovWzG73Z9SWQAqf7IoNiK?= =?Windows-1252?Q?7lK+U4mIS+N2FLiGv06GzZOZttZ/l8sV7lp99FmGNKvwCQmKXY457vL/?= =?Windows-1252?Q?GIsyW8fja8LTe3Sf/jlZfaXq8VV/tNDhQmHXYCykP2IIYNLem+uGb85E?= =?Windows-1252?Q?lxfP+XU10RFvFNbCQhxn7lbem38Bt/oaoN9VExdM2kotsaX3O58G1l+7?= =?Windows-1252?Q?EkoylR9fUKVuGs1y4R8CuSES1yDNVgdzbwCOs6dUD/D9chiqQe/MJP2v?= =?Windows-1252?Q?VLgJos/qCtQEu7ucqZm5WeTirdJIucvdWUeL3PiGCHUlYSzCoE0a+Ewi?= =?Windows-1252?Q?uB0lAqC+KvWwrCOZJ6pJmy4d13HUKH8qK8BQehsosYWPHb1jjCYnaO7i?= =?Windows-1252?Q?YF0y0GdFgwVQRu3Ui3Y5iq4cxSjF3u2WhmN9FmCPS7BjbOl+9vt0liAD?= =?Windows-1252?Q?bx318ZbFOBVqsIdthN/tu4S3iXV577JJXsge50jBCtEKxbjiaFEIQBTf?= =?Windows-1252?Q?/QQsyXG3bTfbmYw239zY9WTUFq4BQ6FaenbivwOqzR1hK3P5qUyL9vwT?= =?Windows-1252?Q?By0Oi4dXRfCruQWULne86zjXgf7LbhBIBsZRBzy0xpdsSZGVuU3awoVx?= =?Windows-1252?Q?7IKEYOJahGNZagczU+25ddAwOYmjrbDCwW0+65kwcejMDkE8mHcDmx4U?= =?Windows-1252?Q?tsvstOG459JFovMzdtH2fdmMARm3wtpyzGqhDA663U238/dBLWxXhoee?= =?Windows-1252?Q?XMQeot+sO68AUBPW+wV3DAPIlAgUSEgZfid8aVJlLGhEq4X9g5Q3p6mI?= =?Windows-1252?Q?PVtExMZQ8TeZWBLE09zQyyuPhGPLTcb1IyjWTLy8KgzqlCrM3EPSZ4/6?= =?Windows-1252?Q?6ku+zZ5wxaxcEDgd+Qs477xXCZWjd5GKDeLp892Apfs/f0rG980WPQLd?= =?Windows-1252?Q?Ad9I5T/JUoOoR/78DeCPzyNQyWdWlQVd3M6jH/oCHybYQ6AeV07fH5xz?= =?Windows-1252?Q?Y//yq7MHGNdGWH/5Y8UYmuoqg0LGcGx43aGU/paBx/okwpEK7laNUyXP?= =?Windows-1252?Q?Sm4Wjco7KlD53z/Itkfhd5MOpcSQBaiwfmMdxt62XswjqCJHU/oVWH29?= =?Windows-1252?Q?ehoe43LQMRNYWtTAzAdxcP+cuNragCF8/ULGd5ePo619Ri0mKPWuQlIY?= =?Windows-1252?Q?4ZxqMdVRxXSfbBpSFAYtGoP563kSWkO25CF0lLCXcpuiXVJOQc5eVRSa?= =?Windows-1252?Q?MsRyUH9U/FhBqd8WKjirfHj9j2qNczECHPBzH779NGY+StdpEk4FrTF+?= =?Windows-1252?Q?tGw870RSCc+HWKRU0Y7P5c4+O/x/qUMsG7wNO1GeMSiOn925tEk+E/7n?= =?Windows-1252?Q?vf73A7Vjx02B65QYxqFZZmDSLPr1+ZWGobsv/HbMoEWe5gRqv+w7YBFp?= =?Windows-1252?Q?FIBwVQ2kFDAI9zuuyzW?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR04MB1969;6:7XHTXNp+pqOQ1XU6H+uL7ECejKuVRiPcxn68MADly4Ysa2scwDhyyN9j3fLbJiaOlbNXdm3ImhOPhwNsQ+Zd0mynUUM+e3G3wRdqGxEJayQp6urvjYxuq20lZm/B8I4934+E1fNagABqOv1svFPHSKcy8ovS46r+o2kWRBaAA7fw8wCe6Bcr8B0EwrXYBqCufk7hLViYE9XfUSSwRJ++42p5j4JgZTPeOPfK1KisbyuTd4FPESK4hHSImGmNpR6tQe/u2Vw72Mg97vrg+iFxH1SzjJlSMIstKGADEkJi/KtMaKsE8INg3a/uyZ3y6dE05nEEyhgeL9dChmWKVxY/blxcwjeLle5D7G2nBm8Ag74ipiS13lQd9HBUCR6vuLxC;5:x7loCvi6PDFWFx3pqG2E8XAS77nGz5EFY3btjXBqRVe3ilTooziGdx8rTV7GDmXjkJBs634arv3Loy0i4bB2hRyfJEC32+eWugFJivWZXNplep2U8oejgT5ibtYOJ9fChO7KVCIMrqVZy+aMMllIcRyZPerkb4KZs9HqQycWtmM=;24:FsDNVDXMxVaNuQz5ad/ntGbfR841vMkvgGY5rXT9dY0Nohk2/Sy/fB8wLEPYIsvXGM8K6oxIcxmr7Xua+aDCn9nbnDawA5EQQ7DEoEkSpgs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BL2PR04MB1969;7:E1fGKyifL37IQUryhbV66CzwnRVsPan+rQQYOhpzGsehhO1wb5vcZa4iZddZbBBEAcNSYq++0d9YnggQti3DrS6/ppyeXMWs5Jr5H5ZdPq9Osvf35GdUnbX7uziPzX0T6iRkqTnn5wG/k1ZKc5AEV+SRMWPyHXIgW9B2fVwR2F5VMnGU+y6hAoEKHNtanUkcL60+naeMFvp+z2lwkIQhHLdkzuL/xe6DWU+My+JYtK/XvuEP5KlqcFgkaSNn8lalWMtp+a79yPxxp05DyeP1IsH3OYVOcNUOptZA4+Hs4szUMiJliO6or1+BjJ+jzo2JTAJLQ+0Jr5tKHjU9ZmO+19FfWP+EmSWY1XhkZhZNpMg=;20:RZ6nVqHsAZJoCPgqo0wUF6JlsVg8e9RYs5d0FTjbnavEuYqhc9w0ZbpHFYWFBOwLjtZdO/ZQXzyBRocLqLYS2t3AOgpvij1Mx9D0RljDDTclbUZr39sUhdCP2I6EdLXZtj6TVFJRiQWu2HFGIQwtGjMGrhw3zF+uZDO8y6O2+TtN+YmmrIDdNg61RAKg4S4Iz8xH3UtK19YEVI7yLV9vHQwDP+LL9eYeBYy+ZQxybPgBRhzcDBG7KP6VYivfH9vc X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2016 14:27:06.2183 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR04MB1969 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd, > Unfortunately, the sector number is usually a 64-bit number, and > we probably can't guarantee that bdev_zone_size() returns a > power-of-two number, so we actually have to do the expensive 64-bit > operation to get the remainder. No, the zone size is guaranteed to be a power of 2. See sd_zbc.c in Jens linux-block tree, branch for-4.10/block. So it is ok to do a & (bdev_zone_size() - 1) for the remainder. That was indeed my mistake in this patch. Modulo should not have been used in the first place. My bad. > > Fixes: 792b84b74b54 ("f2fs: support multiple devices") > Signed-off-by: Arnd Bergmann > --- > fs/f2fs/segment.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index 634834e5a232..e4c5497aa172 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -685,6 +685,7 @@ static int __f2fs_issue_discard_zone(struct f2fs_sb_info *sbi, > { > sector_t nr_sects = SECTOR_FROM_BLOCK(blklen); > sector_t sector; > + u32 rem; > int devi = 0; > > if (sbi->s_ndevs) { > @@ -693,7 +694,8 @@ static int __f2fs_issue_discard_zone(struct f2fs_sb_info *sbi, > } > sector = SECTOR_FROM_BLOCK(blkstart); > > - if (sector % bdev_zone_size(bdev) || nr_sects != bdev_zone_size(bdev)) { > + div_u64_rem(sector, bdev_zone_size(bdev), &rem); > + if (rem || nr_sects != bdev_zone_size(bdev)) { > f2fs_msg(sbi->sb, KERN_INFO, > "(%d) %s: Unaligned discard attempted (block %x + %x)", > devi, sbi->s_ndevs ? FDEV(devi).path: "", Thanks ! Best regards. -- Damien Le Moal, Ph.D. Sr Manager, System Software Research Group, Western Digital Damien.LeMoal@hgst.com Tel: (+81) 0466-98-3593 (Ext. 51-3593) 1 kirihara-cho, Fujisawa, Kanagawa, 252-0888 Japan www.wdc.com, www.hgst.com