mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Takashi Iwai <tiwai@suse.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 2/3] fonts: Use BUILD_BUG_ON() for checking empty font table
Date: Tue, 18 Jun 2019 16:05:58 -0700	[thread overview]
Message-ID: <896583b9-3231-9e31-e51b-c76b889db85b@infradead.org> (raw)
In-Reply-To: <20190618203425.10723-3-tiwai@suse.de>

On 6/18/19 1:34 PM, Takashi Iwai wrote:
> We have a nice macro, and the check of emptiness of the font table can
> be done in a simpler way.
> 
> Signed-off-by: Takashi Iwai <tiwai@suse.de>

Hi,

Looks good to me.
Acked-by: Randy Dunlap <rdunlap@infradead.org>

Also, would you mind adding TER16x32 to Documentation/fb/fbcon.rst, here:
(AFAIK that would be appropriate.)

1. fbcon=font:<name>

	Select the initial font to use. The value 'name' can be any of the
	compiled-in fonts: 10x18, 6x10, 7x14, Acorn8x8, MINI4x6,
	PEARL8x8, ProFont6x11, SUN12x22, SUN8x16, VGA8x16, VGA8x8.

> ---
>  lib/fonts/fonts.c | 15 +--------------
>  1 file changed, 1 insertion(+), 14 deletions(-)

Thanks.
-- 
~Randy

  reply	other threads:[~2019-06-18 23:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-18 20:34 [PATCH RFC 0/3] Automatically choose a bigger font for high resolution screens Takashi Iwai
2019-06-18 20:34 ` [PATCH RFC 1/3] fonts: Fix coding style Takashi Iwai
2019-06-18 20:34 ` [PATCH RFC 2/3] fonts: Use BUILD_BUG_ON() for checking empty font table Takashi Iwai
2019-06-18 23:05   ` Randy Dunlap [this message]
2019-06-19  5:36     ` Takashi Iwai
2019-06-18 20:34 ` [PATCH RFC 3/3] fonts: Prefer a bigger font for high resolution screens Takashi Iwai
2019-06-20  6:28 ` [PATCH RFC 0/3] Automatically choose " Greg Kroah-Hartman
2019-06-20  7:43   ` Takashi Iwai
2019-06-20  8:12     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=896583b9-3231-9e31-e51b-c76b889db85b@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®