From: Prakash Sangappa <prakash.sangappa@oracle.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
Daniel Jordan <daniel.m.jordan@oracle.com>
Subject: Re: [RFC PATCH 0/4] Scheduler time slice extension
Date: Wed, 13 Nov 2024 20:10:52 +0000 [thread overview]
Message-ID: <896BA407-E19C-4CEB-BF5E-9707543BA365@oracle.com> (raw)
In-Reply-To: <f0f681a0-22b4-45f4-85a1-18f140286cbe@efficios.com>
> On Nov 13, 2024, at 11:36 AM, Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
>
> On 2024-11-13 13:50, Peter Zijlstra wrote:
>> On Wed, Nov 13, 2024 at 12:01:22AM +0000, Prakash Sangappa wrote:
>>> This patch set implements the above mentioned 50us extension time as posted
>>> by Peter. But instead of using restartable sequences as API to set the flag
>>> to request the extension, this patch proposes a new API with use of a per
>>> thread shared structure implementation described below. This shared structure
>>> is accessible in both users pace and kernel. The user thread will set the
>>> flag in this shared structure to request execution time extension.
>> But why -- we already have rseq, glibc uses it by default. Why add yet
>> another thing?
>
> Indeed, what I'm not seeing in this RFC patch series cover letter is an
> explanation that justifies adding yet another per-thread memory area
> shared between kernel and userspace when we have extensible rseq
> already.
It mainly provides pinned memory, can be useful for future use cases where updating user memory in kernel context can be fast or needs to avoid pagefaults.
>
> Peter, was there anything fundamentally wrong with your approach based
> on rseq ? https://lore.kernel.org/lkml/20231030132949.GA38123@noisy.programming.kicks-ass.net
>
> The main thing I wonder is whether loading the rseq delay resched flag
> on return to userspace is too late in your patch. Also, I'm not sure it is
> realistic to require that no system calls should be done within time extension
> slice. If we have this scenario:
I am also not sure if we need to prevent system calls in this scenario.
Was that restriction mainly because of restartable sequence API implements it?
-Prakash
>
> A) userspace grabs lock
> - set rseq delay resched flag
> B) syscall
> - reschedule
> [...]
> - return to userspace, load rseq delay-resched flag from userspace (too late)
>
> I would have thought loading the delay resched flag should be attempted much
> earlier in the scheduler code. Perhaps we could do this from a page fault
> disable critical section, and accept that this hint may be a no-op if the
> rseq page happens to be swapped out (which is really unlikely). This is
> similar to the "on_cpu" sched state rseq extension RFC I posted a while back,
> which needed to be accessed from the scheduler:
>
> https://lore.kernel.org/lkml/20230517152654.7193-1-mathieu.desnoyers@efficios.com/
> https://lore.kernel.org/lkml/20230529191416.53955-1-mathieu.desnoyers@efficios.com/
>
> And we'd leave the delay-resched load in place on return to userspace, so
> in the unlikely scenario where it is swapped out, at least it gets paged
> back at that point.
>
> Feel free to let me know if I'm missing an important point and/or saying
> nonsense here.
>
> Thanks,
>
> Mathieu
>
> --
> Mathieu Desnoyers
> EfficiOS Inc.
> https://www.efficios.com
>
next prev parent reply other threads:[~2024-11-13 20:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 0:01 Prakash Sangappa
2024-11-13 0:01 ` [RFC PATCH 1/4] Introduce per thread user-kernel shared structure Prakash Sangappa
2024-11-13 0:01 ` [RFC PATCH 2/4] Scheduler time extention Prakash Sangappa
2024-11-13 3:57 ` K Prateek Nayak
2024-11-13 17:40 ` Prakash Sangappa
2024-11-13 0:01 ` [RFC PATCH 3/4] Indicate if schedular preemption delay request is granted Prakash Sangappa
2024-11-13 0:01 ` [RFC PATCH 4/4] Add scheduler preemption delay granted stats Prakash Sangappa
2024-11-13 5:43 ` [RFC PATCH 0/4] Scheduler time slice extension K Prateek Nayak
2024-11-13 19:56 ` Prakash Sangappa
2024-11-13 18:50 ` Peter Zijlstra
2024-11-13 19:36 ` Mathieu Desnoyers
2024-11-13 20:10 ` Prakash Sangappa [this message]
2024-11-13 20:57 ` Mathieu Desnoyers
2024-11-13 23:24 ` Prakash Sangappa
2024-11-14 10:28 ` Peter Zijlstra
2024-11-14 19:42 ` Prakash Sangappa
2024-11-15 14:13 ` Mathieu Desnoyers
2024-11-15 17:20 ` Prakash Sangappa
2024-12-09 20:36 ` Prakash Sangappa
2024-12-09 21:17 ` Mathieu Desnoyers
2024-12-16 18:59 ` Prakash Sangappa
2025-02-04 3:04 ` Prakash Sangappa
2024-11-14 10:14 ` Peter Zijlstra
2024-11-15 14:41 ` Mathieu Desnoyers
2024-11-15 17:49 ` Prakash Sangappa
2024-11-13 19:50 ` Prakash Sangappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=896BA407-E19C-4CEB-BF5E-9707543BA365@oracle.com \
--to=prakash.sangappa@oracle.com \
--cc=daniel.m.jordan@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®