From: Armin Wolf <W_Armin@gmx.de>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Hans de Goede" <hdegoede@redhat.com>
Cc: markgross@kernel.org, platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/6] platform/x86: wmi: Fix probe failure when failing to register WMI devices
Date: Fri, 13 Oct 2023 18:24:04 +0200 [thread overview]
Message-ID: <896d6ea7-f258-46f3-aed8-80c0a372e7e1@gmx.de> (raw)
In-Reply-To: <6fc5eacc-15e7-8de4-a031-d57ae27568bd@linux.intel.com>
Am 12.10.23 um 18:32 schrieb Ilpo Järvinen:
> On Sun, 8 Oct 2023, Armin Wolf wrote:
>
>> When a WMI device besides the first one somehow fails to register, retval
>> is returned while still containing a negative error code. This causes the
>> ACPI device failing to probe, leaving behind zombie WMI devices leading
>> to various errors later.
>> Fix this by handling the single error path separately and return 0 after
>> trying to register all WMI devices. Also continue to register WMI devices
>> even if some fail to allocate.
> I think the usual approach would be to unroll all registerations done so
> far when an error occurs while registering n devices.
I agree, however the surrounding code unrolls only the WMI device registration,
so i kept it that way. After all, this patch focuses on fixing the "zombie" WMI devices
problem, so changing the code to unroll all registrations should be done in a separate
patch IMHO.
Armin Wolf
> Do you Hans have something to add what would be the best course of action
> here?
>
next prev parent reply other threads:[~2023-10-13 16:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-07 23:39 [PATCH 0/6] Preparations for fixing WMI reprobing issue Armin Wolf
2023-10-07 23:39 ` [PATCH 1/6] platform/x86: wmi: Update MAINTAINERS entry Armin Wolf
2023-10-11 9:24 ` Hans de Goede
2023-10-07 23:39 ` [PATCH 2/6] platform/x86: wmi: Decouple probe deferring from wmi_block_list Armin Wolf
2023-10-09 13:19 ` Ilpo Järvinen
2023-10-07 23:39 ` [PATCH 3/6] platform/x86: wmi: Fix refcounting of WMI devices in legacy functions Armin Wolf
2023-10-07 23:39 ` [PATCH 4/6] platform/x86: wmi: Fix probe failure when failing to register WMI devices Armin Wolf
2023-10-12 16:32 ` Ilpo Järvinen
2023-10-13 16:24 ` Armin Wolf [this message]
2023-10-07 23:39 ` [PATCH 5/6] platform/x86: wmi: Fix opening of char device Armin Wolf
2023-10-07 23:39 ` [PATCH 6/6] platform/x86: wmi: Decouple WMI device removal from wmi_block_list Armin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=896d6ea7-f258-46f3-aed8-80c0a372e7e1@gmx.de \
--to=w_armin@gmx.de \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®