From: Waiman Long <llong@redhat.com>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Frederic Weisbecker <frederic@kernel.org>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
Costa Shulyupin <cshulyup@redhat.com>,
Daniel Wagner <dwagner@suse.de>
Subject: Re: [PATCH v2 1/2] sched/isolation: Exclude dynamically isolated CPUs from housekeeping masks
Date: Fri, 15 Nov 2024 14:39:26 -0500 [thread overview]
Message-ID: <896fe0bd-41a1-4613-a3f7-f3ccf80d880c@redhat.com> (raw)
In-Reply-To: <f5241a1d-9753-4c95-b633-067ecda50c10@redhat.com>
On 11/15/24 2:32 PM, Waiman Long wrote:
> On 11/15/24 10:45 AM, Michal Koutný wrote:
>> Hello.
>>
>> I recently liked the idea of considering isolated CPUs a static (boot
>> time) resource and only use cpusets to place (or remove) sensitive
>> workload from those selected CPUs depending on current needs. (Yes, this
>> may not efficiently utilize the isolated CPUs when reserve them based on
>> maximum needs of a node.)
>
> Thanks for taking a look at this.
>
> Yes, I am moving in this direction too. Boot time statically isolated
> CPUs have better isolation than is currently possible if we do it
> dynamically at run time, though we are trying to close the gap.
>
>>
>>
>> On Wed, Aug 21, 2024 at 10:23:11AM GMT, Waiman Long
>> <longman@redhat.com> wrote:
>>> This patch is a step in that direction by making the housekeeping CPU
>>> mask APIs exclude the dynamically isolated CPUs when they are called
>>> at run time. The housekeeping CPU masks will fall back to the bootup
>>> default when all the dynamically isolated CPUs are released.
>> But when I look at it with the dynamism in mind, I would expect that
>> some API like housekeeping_setup_type(), i.e. modify the set of isolated
>> CPUs are requested and leave it up to the isolation implementation to
>> propagate any changes to respective subsystems. And return an error of
>> type contains a flag for which dynamism isn't implemented yet or not
>> possible.
>
> There are currently 9 different hk_type's defined in
> include/linux/sched/isolation.h. We are now trying to reduce their
> number as some of them cannot be set independently. See [1]. I am
> thinking about doing dynamism in the best effort basis. Of course, we
> could expose some information about what aspect of dynamic isolation
> can be enabled at the moment, if necessary.
Forgot to put the link.
[1] https://lore.kernel.org/lkml/20240921190720.106195-1-longman@redhat.com/
>
> Cheers,
> Longman
>
next prev parent reply other threads:[~2024-11-15 19:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 14:23 [PATCH v2 0/2] isolation: Exclude dynamically isolated CPUs from housekeeping cpumasks Waiman Long
2024-08-21 14:23 ` [PATCH v2 1/2] sched/isolation: Exclude dynamically isolated CPUs from housekeeping masks Waiman Long
2024-08-31 0:27 ` Waiman Long
2024-11-15 15:45 ` Michal Koutný
2024-11-15 19:32 ` Waiman Long
2024-11-15 19:39 ` Waiman Long [this message]
2024-11-16 0:40 ` Waiman Long
2024-11-20 17:17 ` Frederic Weisbecker
2024-08-21 14:23 ` [PATCH v2 2/2] cgroup/cpuset: Exclude isolated CPUs from housekeeping CPU masks Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=896fe0bd-41a1-4613-a3f7-f3ccf80d880c@redhat.com \
--to=llong@redhat.com \
--cc=bsegall@google.com \
--cc=cgroups@vger.kernel.org \
--cc=cshulyup@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=dwagner@suse.de \
--cc=frederic@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®