From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B96021C9F9 for ; Fri, 30 May 2025 10:56:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748602612; cv=none; b=pVVZ0xkJrnki/FRn4AYllWSYqBVBP4LuDfJjPfQSVSTwCGNOd1KWK2+W/G8aiNzQmF1lnsbdhgZ0lNWLpXZuVECWvMpO3znbs+YpsLcJMsfkhiO5uxm/dgIf6F6mHVgZaEOg2np2tctyvY7q8tFDdd4nOsgel9w1pTdhDUBJJuo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748602612; c=relaxed/simple; bh=wXzNltEAfvd2Z9TuqPjRTjSk3qvDN5IHyR2ohzs6boE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lBgvvQ2KzcpfpMNsOeQqOMkUGMyZcWQu76+E9CTDM2xkCF0l74DFFyFLZlLIRgRH9mQEb+zPzvpyedlO1RfVtGO3w93uQA8qewJ6ENmPvX1sTYWRNO39ZJGke5Watdq16ByiRewBO3r4cfsc/vzsf2FSxNyfp6YIJ3F92RyK70A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kZRVEeIj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kZRVEeIj" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54U16f3S011691 for ; Fri, 30 May 2025 10:56:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= odW9Gnbh0pAigIu977/CYjbuP4cZbGddXolCkSLXzHI=; b=kZRVEeIjcFr+g/o2 H7opx7uDuqhRJhyu3p9dKmR3VsPNX2SDDngRwAy4PjXS2Kny+Bbf6LwhzObSjFO7 bbex/gcsQN7IWlPObXnT64+6u5Hyzxvst3C3zVCOTk36cCys9SuEpec+NW/f8kPH kr0jXKFwvI4LN+djLvmlXOuP/C1faSFbBu6iApc2MqPMflDnwerCyhn1oAzD5CHw /CkkIdGXRtTJfCxfZq5eJgHXcM+f/z7CvymjPTrXOvHBmd/QZS3JYdH+7JOeiYxC QdmULlmPJKse2D1ChjNTmO0NcNAn7xTURhiMSPTymdFklTmJJsp8e05H//IKrP3/ 8bJJ4w== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46u6g98sun-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 30 May 2025 10:56:49 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c5841ae28eso43870885a.1 for ; Fri, 30 May 2025 03:56:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748602609; x=1749207409; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=odW9Gnbh0pAigIu977/CYjbuP4cZbGddXolCkSLXzHI=; b=qLRhbeTypmu3OdAy7CGn2UXFx5SHHEcj0wWAgqfEtl/HVltabVeol6SO5jAbFqRC2V oRoceOv6d/m8HcikfLXjRFesfQYPFeY48BU3Igo4OiLaHvir9Ajpq8hCJw+EXor0GDX1 TXoEA+tHkp41CdaQEjZgjd0m/zx6IJjBx4S48quelQIOOLY1wFLcd5hq+a/RVnXCEYjO 7g1HohhxEJ0MUct4Z+mxNrJhuRpLwC0JOYSSakHuo2TYzvjZkhtNMDmbZcawHWWh/W1w mA0wAHqGDC9GHbwbcW4ofp6Fb/3tc3cNAr0wAaonUx2OGlR57gaKMxYqMA20CxilRL+7 9Xjg== X-Forwarded-Encrypted: i=1; AJvYcCXcD/lWDgA93fOQhewz/ceHiWOMxAsL6GKFZAr6fGtywSPNiuXRI8jKWGv9fmPjHYppj9U6I+coHzqou/o=@vger.kernel.org X-Gm-Message-State: AOJu0Ywc6UncL0c5H3qXlH5+IawQwKgU1CQzAZawifsFACnCGvEjp531 8sGetcfjyL6l/fW6M4Mhp+m4iN8I2o5aXqfFI7Rqwv/n78X3JjxbMhA0u2puaOaBc1oxAv4e9YP yIiVgj7X9UggPUuhhM8073T72HK8oC/kZSymDYCUDbd+yIDNgP4a1MDLhEXF9tZXJVLs= X-Gm-Gg: ASbGncvEDJwWOckFMv0uxD+46K/rWPgO9JUs9rVeXsBsrPVL51ct1penwRV3Uc/8JUM yEFXK/dj4TEPsPt/C/v1mgqxfjC8m5lHF2XGDE8EC7G5i1SOc9KOmNdIKYUOX0+pZ6kYX5DVQSB cAbFmH4Q2+7+VJj4ZbGxF4c7c5SGtEUKaVABkLsoNnlRuwex2GIvUXR3jFFYDtKrYQ4E82IAyow R8NuzuK9sfIR4pD8sL5/Eni5ozJgG5oyzTEcpIV7booaPEPCs16XsJm2xiXqq/cHcX0ahuIW3HB DzgQZ9uVMDH0d4KFnJesJNhTYi9zqIWePRCwYgUHsVnNrKqBICQT3giRY/oVkJeXKw== X-Received: by 2002:a05:620a:22cb:b0:7d0:a873:41b6 with SMTP id af79cd13be357-7d0a87341eemr23248185a.13.1748602609017; Fri, 30 May 2025 03:56:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFVhwGo6eIBUc8NIPWCq/VAYr79CpNK6ZT1bJU+Fx1YS9w2pL/7LMaola04s9DtuAsRXHuuOQ== X-Received: by 2002:a05:620a:22cb:b0:7d0:a873:41b6 with SMTP id af79cd13be357-7d0a87341eemr23247285a.13.1748602608611; Fri, 30 May 2025 03:56:48 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ada5d84f2bcsm306618166b.83.2025.05.30.03.56.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 May 2025 03:56:47 -0700 (PDT) Message-ID: <8972adb4-b6ae-4ea9-986a-32e59fe84c50@oss.qualcomm.com> Date: Fri, 30 May 2025 12:56:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: sa8775p: Remove max link speed property for PCIe EP To: Mrinmay Sarkar Cc: Dmitry Baryshkov , Vinod Koul , Kishon Vijay Abraham I , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, krishna.chundru@oss.qualcomm.com, quic_vbadigan@quicinc.com, quic_nayiluri@quicinc.com, quic_ramkri@quicinc.com, quic_nitegupt@quicinc.com, Mrinmay Sarkar References: <20250525-update_phy-v3-0-5b315cd39993@quicinc.com> <20250525-update_phy-v3-2-5b315cd39993@quicinc.com> <0aef1687-0158-4d7e-8e3d-b6eafc38d049@oss.qualcomm.com> <41ac26a6-7a5a-4c11-b05c-9ce688ad1856@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <41ac26a6-7a5a-4c11-b05c-9ce688ad1856@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=d4b1yQjE c=1 sm=1 tr=0 ts=68398ef1 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=ra-v6aFW90cMH64V2wwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: mwbXU_DL_8aK-4JxGMR4zq5KrF0Cm7f1 X-Proofpoint-GUID: mwbXU_DL_8aK-4JxGMR4zq5KrF0Cm7f1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTMwMDA5MyBTYWx0ZWRfX8iD4iJnvxujY 37o3IrelDtN31vdmrz6eRK1Zplfq4CsVYlgSaXD693TaAodO79gDQaRdtv2LK7oR+rODC5Zk6Vo 0gOWDyHlPxnYiGsKIB0qptRkz5xbK0qYZFsuOpEkeNM6fb0n2FKRNLnxp/PGsCl2OLc0SPTzuZH ICCFOENpfBfc9VFjM+LgHs1wvCsBKRngXFpiIst1pbpojUvaKAGTVMo1NdCduPKIYB7fawB0f48 OZTQlKgOfHsqOYN0TLEejZpWn04QknCLn7Bm6M8AibdTRV/Rk9y/HHiaTf0P9jlcoMU2TXf5A36 l6dMPIbsMYKaEuAUGyB2Zyrf+c44Z3pFoftbH5zIe+Z44pyDjQ5g+rU88gw3eQm8JjKY8T0V9m7 dNMwG9FOOsWDPpgjD/QaJilQE95Dj7JA13vjeYO1Dc0eZVWGWfyFQk2H/ElpvcRqVO6Os+zF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-30_04,2025-05-29_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 malwarescore=0 phishscore=0 mlxlogscore=886 lowpriorityscore=0 priorityscore=1501 bulkscore=0 spamscore=0 clxscore=1015 impostorscore=0 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505300093 On 5/30/25 12:50 PM, Konrad Dybcio wrote: > On 5/30/25 7:38 AM, Mrinmay Sarkar wrote: >> On Tue, May 27, 2025 at 4:06 PM Konrad Dybcio >> wrote: >>> >>> On 5/25/25 3:29 PM, Dmitry Baryshkov wrote: >>>> On Sun, May 25, 2025 at 11:27:18AM +0530, Mrinmay Sarkar wrote: >>>>> From: Mrinmay Sarkar >>>>> >>>>> The maximum link speed was previously restricted to Gen3 due to the >>>>> absence of Gen4 equalization support in the driver. >>>>> >>>>> Add change to remove max link speed property, Since Gen4 equalization >>>>> support has already been added into the driver. >>>> >>>> As Gen4 equalization is already supported by the XYZ driver remove the >>>> max-link-speed property. >>>> >>>> "Add change to remove" is a bit clumsy. >>> >>> I'm more worried about this node not having these gen4 eq settings >>> (i.e. the part talking about driver support landing is true, but it's >>> unused without the presets being explicitly defined in eq-presets-16gts) >>> >>> Konrad >> >> Hi Konrad, >> >> Actually stability issue was resolved by this patch series: >> https://lore.kernel.org/linux-pci/20240911-pci-qcom-gen4-stability-v7-3-743f5c1fd027@linaro.org/ >> and I don't think we need to define eq-presets-16gts for this. > > Okay, so there's multiple parts to it.. > > I was referring to this series > > https://lore.kernel.org/all/20250328-preset_v6-v9-0-22cfa0490518@oss.qualcomm.com/ > > Please check if you need this as well If not, we can get this merged as-is Konrad