From: khairul.anuar.romli@altera.com
To: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org (open list:SPI SUBSYSTEM),
linux-kernel@vger.kernel.org (open list),
Matthew Gerlach <matthew.gerlach@altera.com>,
Khairul Anuar Romli <khairul.anuar.romli@altera.com>,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: [PATCH 1/1] spi: cadence-quadspi: fix cleanup of rx_chan on failure paths
Date: Mon, 30 Jun 2025 17:11:56 +0800 [thread overview]
Message-ID: <89765a2b94f047ded4f14babaefb7ef92ba07cb2.1751274389.git.khairul.anuar.romli@altera.com> (raw)
In-Reply-To: <cover.1751274389.git.khairul.anuar.romli@altera.com>
From: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
Remove incorrect checks on cqspi->rx_chan that cause driver breakage
during failure cleanup. Ensure proper resource freeing on the success
path when operating in cqspi->use_direct_mode, preventing leaks and
improving stability.
Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
---
drivers/spi/spi-cadence-quadspi.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
index aa1932ba17cb..d3c78f59b22c 100644
--- a/drivers/spi/spi-cadence-quadspi.c
+++ b/drivers/spi/spi-cadence-quadspi.c
@@ -1960,11 +1960,6 @@ static int cqspi_probe(struct platform_device *pdev)
pm_runtime_enable(dev);
- if (cqspi->rx_chan) {
- dma_release_channel(cqspi->rx_chan);
- goto probe_setup_failed;
- }
-
pm_runtime_set_autosuspend_delay(dev, CQSPI_AUTOSUSPEND_TIMEOUT);
pm_runtime_use_autosuspend(dev);
pm_runtime_get_noresume(dev);
--
2.35.3
next parent reply other threads:[~2025-06-30 9:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1751274389.git.khairul.anuar.romli@altera.com>
2025-06-30 9:11 ` khairul.anuar.romli [this message]
2025-06-30 10:40 ` Santhosh Kumar K
2025-06-30 18:00 ` Dan Carpenter
2025-07-01 0:39 ` Romli, Khairul Anuar
2025-07-01 3:40 ` Dan Carpenter
2025-07-01 22:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89765a2b94f047ded4f14babaefb7ef92ba07cb2.1751274389.git.khairul.anuar.romli@altera.com \
--to=khairul.anuar.romli@altera.com \
--cc=broonie@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthew.gerlach@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®