From: Dan Carpenter <dan.carpenter@linaro.org>
To: Gary Rookard <garyrookard@fastmail.org>
Cc: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] staging: rtl8192e: rename variable is40MHz
Date: Mon, 8 Jan 2024 10:58:23 +0300 [thread overview]
Message-ID: <897a8bb4-a1d7-46ab-96cf-fd5ba447d2d8@moroto.mountain> (raw)
In-Reply-To: <20240108032233.4280-2-garyrookard@fastmail.org>
On Sun, Jan 07, 2024 at 10:22:29PM -0500, Gary Rookard wrote:
> Coding style issue, checkpatch avoid CamelCase,
> rename it. is40MHz -> is_40mhz
>
> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
> ---
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index 6d0912f90198..1b1cb9514028 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -87,36 +87,36 @@ static u16 ht_mcs_to_data_rate(struct rtllib_device *ieee, u8 mcs_rate)
> {
> struct rt_hi_throughput *ht_info = ieee->ht_info;
>
> - u8 is40MHz = (ht_info->cur_bw_40mhz) ? 1 : 0;
> + u8 is_40mhz = (ht_info->cur_bw_40mhz) ? 1 : 0;
This should be is_40MHz. It's metric. M means Mega. m means milli.
regards,
dan carpenter
next prev parent reply other threads:[~2024-01-08 7:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 3:22 [PATCH 0/5] staging: rtl8192e: renamed variable is40MHz and 4 other Gary Rookard
2024-01-08 3:22 ` [PATCH 1/5] staging: rtl8192e: rename variable is40MHz Gary Rookard
2024-01-08 7:58 ` Dan Carpenter [this message]
2024-01-08 13:22 ` Gary Rookard
[not found] ` <62836460ae502097ca8307bcee85a5ae3634e1acc74af843ffc466c28d1a0b95@mu.id>
2024-01-09 1:25 ` Gary Rookard
2024-01-09 7:43 ` Dan Carpenter
2024-01-08 3:22 ` [PATCH 2/5] staging: rtl8192e: rename variable isShortGI Gary Rookard
2024-01-08 3:22 ` [PATCH 3/5] staging: rtl8192e: rename variable retValue Gary Rookard
2024-01-08 3:22 ` [PATCH 4/5] staging: rtl8192e: rename variable EWC11NHTCap Gary Rookard
2024-01-08 3:22 ` [PATCH 5/5] staging: rtl8192e: rename variable AdvCoding Gary Rookard
2024-01-08 4:46 ` [PATCH 0/5] staging: rtl8192e: renamed variable is40MHz and 4 other Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=897a8bb4-a1d7-46ab-96cf-fd5ba447d2d8@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=garyrookard@fastmail.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®