From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Jianhua Lu <lujianhua000@gmail.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: display: panel: nt36523: Allow 'port' instead of 'ports'
Date: Sun, 16 Apr 2023 17:25:36 +0200 [thread overview]
Message-ID: <897f65ac-3aaf-b5c2-d888-c2100069d53a@linaro.org> (raw)
In-Reply-To: <20230412-topic-lenovopanel-v2-1-055c3649788e@linaro.org>
On 13/04/2023 12:09, Konrad Dybcio wrote:
> Using 'port' instead of 'ports' for single-DSI usecases allows for saving
> a couple of DTS LoC, including a level of indentation. Allow that.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> .../bindings/display/panel/novatek,nt36523.yaml | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> index 0039561ef04c..38f4f986aef1 100644
> --- a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
> @@ -33,15 +33,26 @@ properties:
> description: regulator that supplies the I/O voltage
>
> reg: true
> - ports: true
> backlight: true
>
> +oneOf:
> + - allOf:
> + - properties:
> + ports: true
> + - required:
> + - ports
> +
> + - allOf:
> + - properties:
> + port: true
> + - required:
> + - port
If one is not connected, I still would prefer to have ports node as this
device in general supports two ports.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-16 15:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 10:09 [PATCH v2 0/5] Lenovo Tab P11 panel Konrad Dybcio
2023-04-13 10:09 ` [PATCH v2 1/5] dt-bindings: display: panel: nt36523: Allow 'port' instead of 'ports' Konrad Dybcio
2023-04-16 15:25 ` Krzysztof Kozlowski [this message]
2023-04-13 10:09 ` [PATCH v2 2/5] dt-bindings: display: panel: nt36523: Add Lenovo J606F panel Konrad Dybcio
2023-04-16 15:20 ` Krzysztof Kozlowski
2023-04-13 10:09 ` [PATCH v2 3/5] drm/panel: nt36523: Add DCS backlight support Konrad Dybcio
2023-04-13 10:09 ` [PATCH v2 4/5] drm/panel: nt36523: Get orientation from OF Konrad Dybcio
2023-04-13 10:09 ` [PATCH v2 5/5] drm/panel: nt36523: Add Lenovo J606F panel Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=897f65ac-3aaf-b5c2-d888-c2100069d53a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lujianhua000@gmail.com \
--cc=marijn.suijten@somainline.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®