From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932284AbdJYSUt (ORCPT ); Wed, 25 Oct 2017 14:20:49 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:53974 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbdJYSUq (ORCPT ); Wed, 25 Oct 2017 14:20:46 -0400 X-Google-Smtp-Source: ABhQp+TyasOCzdTBp1KLHbLIJet8D6U5hGTmnQxRpXk16Dg4LwR+Uzy/1m8mZ3uA292skj4kWJCXPg== Subject: Re: [PATCH v5 9/9] block: Assign a lock_class per gendisk used for wait_for_completion() To: Ingo Molnar , Byungchul Park Cc: peterz@infradead.org, johan@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, tj@kernel.org, johannes.berg@intel.com, oleg@redhat.com, amir73il@gmail.com, david@fromorbit.com, darrick.wong@oracle.com, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, hch@infradead.org, idryomov@gmail.com, kernel-team@lge.com References: <1508921765-15396-1-git-send-email-byungchul.park@lge.com> <1508921765-15396-10-git-send-email-byungchul.park@lge.com> <20171025101328.b6fg32m2oazh3zro@gmail.com> From: Jens Axboe Message-ID: <89864125-688d-d3df-a24c-7f335b9a144e@kernel.dk> Date: Wed, 25 Oct 2017 11:20:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171025101328.b6fg32m2oazh3zro@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/25/2017 03:13 AM, Ingo Molnar wrote: > > * Byungchul Park wrote: > >> Darrick posted the following warning and Dave Chinner analyzed it: >> >>> ====================================================== >>> WARNING: possible circular locking dependency detected >>> 4.14.0-rc1-fixes #1 Tainted: G W > >> Reported-by: Darrick J. Wong >> Analyzed-by: Dave Chinner >> Signed-off-by: Byungchul Park >> --- >> block/bio.c | 2 +- >> block/genhd.c | 10 ++-------- >> include/linux/genhd.h | 22 ++++++++++++++++++++-- >> 3 files changed, 23 insertions(+), 11 deletions(-) > > Ok, this patch looks good to me now, I'll wait to get an Ack or Nak from Jens for > these changes. > > Jens: this patch has some dependencies in prior lockdep changes, so I'd like to > carry it in the locking tree for a v4.15 merge. Looks fine to me, you can add my reviewed-by and carry it in your tree. -- Jens Axboe