From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752882AbcFFOvJ (ORCPT ); Mon, 6 Jun 2016 10:51:09 -0400 Received: from ausxippc101.us.dell.com ([143.166.85.207]:7769 "EHLO ausxippc101.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbcFFOvH convert rfc822-to-8bit (ORCPT ); Mon, 6 Jun 2016 10:51:07 -0400 DomainKey-Signature: s=smtpout; d=dell.com; c=nofws; q=dns; h=X-LoopCount0:X-IronPort-AV:From:To:CC:Subject: Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language: X-MS-Has-Attach:X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader:x-originating-ip: Content-Type:Content-Transfer-Encoding:MIME-Version: Return-Path; b=pbWFfTzhfT/cvzGkbDdTpiit74cEdyIDMD83gtld5yMkqMTstCVK97rc H4qnYxmJ/rZlgx1RrIzN7BGssopAsw4VOql5Z3yzF0VbLytQdWFJTImBW yXRDE+pIQvUrfbv/WR36azE7W2SnIrWWZCwcETvfAb1Yt3vMMhPbvlHOw M=; X-LoopCount0: from 10.175.216.249 X-IronPort-AV: E=Sophos;i="5.26,427,1459832400"; d="scan'208";a="808596145" From: To: CC: , , , , , Subject: RE: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Thread-Topic: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Thread-Index: AQHRv/3ntC5RJsCNs0GplFP1kSdYIZ/c1nuA//+s0YCAAFYJgP//rFLA Date: Mon, 6 Jun 2016 14:51:04 +0000 Message-ID: <8986582922fa40a095e740214d4a05da@ausx13mpc124.AMER.DELL.COM> References: <1465222521-7217-1-git-send-email-mario_limonciello@dell.com> <20160606144009.GB4758@kroah.com> <20160606145021.GA6433@kroah.com> In-Reply-To: <20160606145021.GA6433@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.11.181.4] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Monday, June 6, 2016 9:50 AM > To: Limonciello, Mario > Cc: hayeswang@realtek.com; linux-kernel@vger.kernel.org; > netdev@vger.kernel.org; linux-usb@vger.kernel.org; pali.rohar@gmail.com; > anthony.wong@canonical.com > Subject: Re: [PATCH v3] r8152: Add support for setting pass through MAC > address on RTL8153-AD > > On Mon, Jun 06, 2016 at 02:43:37PM +0000, Mario_Limonciello@Dell.com > wrote: > > > -----Original Message----- > > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > > Sent: Monday, June 6, 2016 9:40 AM > > > To: Limonciello, Mario > > > Cc: hayeswang@realtek.com; LKML ; > Netdev > > > ; Linux USB ; > > > pali.rohar@gmail.com; anthony.wong@canonical.com > > > Subject: Re: [PATCH v3] r8152: Add support for setting pass through MAC > > > address on RTL8153-AD > > > > > > On Mon, Jun 06, 2016 at 09:15:20AM -0500, Mario Limonciello wrote: > > > > Since this is a Realtek feature, I feel this shouldn't be moved into a > platform > > > > MAC address lookup. The code should only be run when the correct > > > Realtek device > > > > is plugged in. > > > > > > > > Changes from v2: > > > > * Only apply to RTL8153-AD w/ eFuse pass through mac address pass > thru > > > > bit set. > > > > * Drop matching DMI information on Dell. Although this is > implemented > > > on > > > > Dell, this is a Realtek feature that may may be implemented on other > > > > OEMs as well. > > > > * Test that pass through MAC address is valid, fall back to HW address if > > > > invalid. > > > > * Don't track status of which device has MAC pass through activated. > > > > - Expected experience is that if two docks (RTL8153-AD's w/ mac pass > thru > > > > bit set) were plugged in both should have MAC pass through > activated. > > > > > > cover letters for single-patch submissions is overkill and confusing, > > > please don't. > > > > I was trying to convey differences between versions of this patch, I'll avoid > > that in the future and let the audience find them themselves. > > No, put them in the patch itself, under the --- line, like is documented > to do so. Don't make people "find them themselves", if you do that, > your patch will just be ignored. > > greg k-h Sorry I was not aware of that. I'll do that in the next patch.