From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27DEE1E0080; Mon, 28 Oct 2024 20:26:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=167.114.26.122 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730147175; cv=none; b=ItyMhe+EWWJV5izLRv29H3JGgXeKJDb/7NahXYYdNFidJ3TXWQJUVrVRcMoXNuf2Fjmlw8+4pU2X9TsnJrLfw4ntmHifIXH+ThL3ZKWw9T2/XqiNiuVIn6L6mQNQ9p8hD4CtXmH6ZX9M+1nbum/aEIuUlYa6BoddesegzNDTmck= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730147175; c=relaxed/simple; bh=J2DcfBdWy45uJItdWiguW3idrp9CeNy/8d4dmAE9PTs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gINK2YSRW4HdOQwKfSNnqcEC9nKqaHn7O8YQewVgSCsiWXC6y0l97HiUq5oHX0qDRfbtJhha44eaJ0cGQhiSAWfsJjbL28bcDO5XXjA+/m1pqSMN5eiYF+FcCE1gDI4cR/Neh99SuCJNbg80nk31DMsQRhZtjId5fG79j+k6m88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=J/z9iVP/; arc=none smtp.client-ip=167.114.26.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="J/z9iVP/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1730147171; bh=J2DcfBdWy45uJItdWiguW3idrp9CeNy/8d4dmAE9PTs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=J/z9iVP/Y6RPeDMdI5MNRoGDml6fNQxfZR+pU6ZwxpeXMjd6TZQpBUqwwAaXsPmko prHP+ObPRwOIpi2rz2MHqsnQLzrpjIIE8NvoY4YKpasH1nrORDrjr92rqAIIlPJr4s xzFpsDLefLueJ39WLOBzexPANTmY7n2Rj2IeravhgB/yG8uihwRknnnpuoH4zY5TRp dgqMV6VRzAKT/mrcyEi1XP/rAGECrJ5LPIPRxeja6LFkhIWOQ86X/z1BxdQHlAcL3R pJ1y1MJCHqNq1y0TRltZsymOJ97MJMchwsWLJhaM77ZirS3EWDZ+VE+jHAAvaaQd9G 8dhYZTqHtXWWA== Received: from [172.16.0.134] (96-127-217-162.qc.cable.ebox.net [96.127.217.162]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4XclJz40dTzsZx; Mon, 28 Oct 2024 16:26:11 -0400 (EDT) Message-ID: <89947c86-a8fa-425f-8e86-d80bb5220280@efficios.com> Date: Mon, 28 Oct 2024 16:24:32 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v4 2/4] tracing: Introduce tracepoint_is_faultable() To: Andrii Nakryiko Cc: Steven Rostedt , linux-kernel@vger.kernel.org, Thomas Gleixner , Michael Jeanson , Masami Hiramatsu , Peter Zijlstra , Alexei Starovoitov , Yonghong Song , "Paul E . McKenney" , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , bpf@vger.kernel.org, Joel Fernandes , Jordan Rife References: <20241028190927.648953-1-mathieu.desnoyers@efficios.com> <20241028190927.648953-3-mathieu.desnoyers@efficios.com> From: Mathieu Desnoyers Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2024-10-28 16:19, Andrii Nakryiko wrote: > On Mon, Oct 28, 2024 at 12:11 PM Mathieu Desnoyers > wrote: >> >> Introduce a "faultable" flag within the extended structure to know >> whether a tracepoint needs rcu tasks trace grace period before reclaim. >> This can be queried using tracepoint_is_faultable(). >> >> Signed-off-by: Mathieu Desnoyers >> Cc: Michael Jeanson >> Cc: Steven Rostedt >> Cc: Masami Hiramatsu >> Cc: Peter Zijlstra >> Cc: Alexei Starovoitov >> Cc: Yonghong Song >> Cc: Paul E. McKenney >> Cc: Ingo Molnar >> Cc: Arnaldo Carvalho de Melo >> Cc: Mark Rutland >> Cc: Alexander Shishkin >> Cc: Namhyung Kim >> Cc: Andrii Nakryiko >> Cc: bpf@vger.kernel.org >> Cc: Joel Fernandes >> Cc: Jordan Rife >> --- >> include/linux/tracepoint-defs.h | 2 ++ >> include/linux/tracepoint.h | 24 ++++++++++++++++++++++++ >> include/trace/define_trace.h | 2 +- >> 3 files changed, 27 insertions(+), 1 deletion(-) >> > > LGTM FYI I'm still missing the "static" here: >> +#define DEFINE_TRACE_SYSCALL(_name, _reg, _unreg, _proto, _args) \ >> + struct tracepoint_ext __tracepoint_ext_##_name = { \ >> + .regfunc = _reg, \ >> + .unregfunc = _unreg, \ >> + .faultable = true, \ >> }; Will fix in v5. Acked-by noted, thanks! Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com