From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756212AbdAIVoy (ORCPT ); Mon, 9 Jan 2017 16:44:54 -0500 Received: from mail-it0-f52.google.com ([209.85.214.52]:35071 "EHLO mail-it0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754581AbdAIVos (ORCPT ); Mon, 9 Jan 2017 16:44:48 -0500 Subject: Re: [PATCH] direct-io: don't introduce another read of inode->i_blkbits To: Jeff Moyer , Chandan Rajendra References: <1483886830-23878-1-git-send-email-chandan@linux.vnet.ibm.com> Cc: jack@suse.cz, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, anton@samba.org, linuxppc-dev@lists.ozlabs.org From: Jens Axboe Message-ID: <899a8860-90d8-1856-f7b6-b4cc76227d34@kernel.dk> Date: Mon, 9 Jan 2017 14:44:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/09/2017 02:42 PM, Jeff Moyer wrote: > Commit 20ce44d545844 ("do_direct_IO: Use inode->i_blkbits to compute > block count to be cleaned") introduced a regression: if the block size > of the block device is changed while a direct I/O request is being > setup, it can result in a panic. See commit ab73857e354ab ("direct-io: > don't read inode->i_blkbits multiple times") for the reasoning, and > commit b87570f5d3496 ("Fix a crash when block device is read and block > size is changed at the same time") for a more detailed problem > description and reproducer. > > Fixes: 20ce44d545844 > Signed-off-by: Jeff Moyer > > --- > Chandan, can you please test this to ensure this still fixes your problem? Please, that would be great. And if so, then let's fold the two. -- Jens Axboe