From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5F4DC34022 for ; Wed, 19 Feb 2020 03:10:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80EE42176D for ; Wed, 19 Feb 2020 03:10:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728276AbgBSDKf (ORCPT ); Tue, 18 Feb 2020 22:10:35 -0500 Received: from smtprelay0170.hostedemail.com ([216.40.44.170]:53137 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728230AbgBSDKe (ORCPT ); Tue, 18 Feb 2020 22:10:34 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id 491D4181D3417; Wed, 19 Feb 2020 03:10:33 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: mice02_792c93b56d712 X-Filterd-Recvd-Size: 1893 Received: from XPS-9350.home (unknown [47.151.143.254]) (Authenticated sender: joe@perches.com) by omf03.hostedemail.com (Postfix) with ESMTPA; Wed, 19 Feb 2020 03:10:32 +0000 (UTC) Message-ID: <899e4e41c4cf5c62a4fbce0923e5796141ef46f0.camel@perches.com> Subject: Re: [RFC PATCH 0/2] trace: Move trace data to new section _ftrace_data From: Joe Perches To: Steven Rostedt Cc: linux-kernel@vger.kernel.org Date: Tue, 18 Feb 2020 19:09:10 -0800 In-Reply-To: <20200218215328.16744447@gandalf.local.home> References: <20200218215328.16744447@gandalf.local.home> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-02-18 at 21:53 -0500, Steven Rostedt wrote: > On Tue, 18 Feb 2020 18:03:16 -0800 > Joe Perches wrote: > > > Move the trace data to a separate section to make it easier to > > examine the amount of actual data in an object file. > > Not that I'm against this patch set, but can you elaborate more on > "make it easier to examine the amount of actual data in an object file". size -A would now show each section of an object file separating normal data from trace data. It makes it easier to identify data that could be const like https://lore.kernel.org/lkml/60559197a1af9e0af7f329cc3427989e5756846f.camel@perches.com/ > Also, don't use "_ftrace" as the section name. "ftrace" should be > reserved for the function hook part of tracing, which trace events do > not apply to. "_trace_event_data" would be more appropriate. I don't care about the section name at all. I used that name for consistency with _ftrace_event in the same file. Perhaps the _ftrace_event section name could be renamed to something intelligible too.