From: Wang Zhaolong <wangzhaolong@huaweicloud.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Steve French <sfrench@samba.org>,
Paulo Alcantara <pc@manguebit.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>, Bharath SM <bharathsm@microsoft.com>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH next] smb: client: Fix NULL vs ERR_PTR() returns in cifs_get_tcon_super()
Date: Mon, 18 Aug 2025 21:03:44 +0800 [thread overview]
Message-ID: <89a2023c-e383-4780-83e3-ba8f9e44c015@huaweicloud.com> (raw)
In-Reply-To: <aKL5dUyf7UWcQNvW@stanley.mountain>
> The cifs_get_tcon_super() function returns NULL on error but the caller
> expect it to return error pointers instead. Change it to return error
> pointers. Otherwise it results in a NULL pointer dereference.
>
> Fixes: 0938b093b1ae ("smb: client: Fix mount deadlock by avoiding super block iteration in DFS reconnect")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Hi Dan,
Thank you for your patch and for taking the time to address this issue.
I would like to mention that I have recently sent out the V4 version of
the patch series, which addresses the issues related to `cifs_get_tcon_super()`.
In the latest version, the issue of NULL pointer dereference has already
been resolved.
https://lore.kernel.org/all/CAH2r5msLMNdqdo6EBuTvrQ0hwrqSRC-LSZuN2WpwV+PkDwsCOw@mail.gmail.com/
I avoid null pointer dereferencing by performing a null pointer check on
the return value of cifs_get_dfs_tcon_super().
> ---
> fs/smb/client/misc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/smb/client/misc.c b/fs/smb/client/misc.c
> index 3b6920a52daa..d73c36862e97 100644
> --- a/fs/smb/client/misc.c
> +++ b/fs/smb/client/misc.c
> @@ -1116,7 +1116,7 @@ static struct super_block *cifs_get_tcon_super(struct cifs_tcon *tcon)
> struct cifs_sb_info *cifs_sb;
>
> if (!tcon)
> - return NULL;
> + return ERR_PTR(-EINVAL);
>
> spin_lock(&tcon->sb_list_lock);
> list_for_each_entry(cifs_sb, &tcon->cifs_sb_list, tcon_sb_link) {
> @@ -1141,7 +1141,7 @@ static struct super_block *cifs_get_tcon_super(struct cifs_tcon *tcon)
> }
> spin_unlock(&tcon->sb_list_lock);
>
> - return NULL;
> + return ERR_PTR(-ENOENT);
> }
>
> struct super_block *cifs_get_dfs_tcon_super(struct cifs_tcon *tcon)
Additionally, I think it somewhat peculiar that in the current
implementation, cifs_get_tcon_super() returns -EINVAL.
I would greatly appreciate it if you could review my latest patch series to
confirm if it resolves the concerns. If there are any additional improvements, I
would be happy to collaborate further to ensure the best possible solution.
Best regards,
Wang Zhaolong
next prev parent reply other threads:[~2025-08-18 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 9:59 Dan Carpenter
2025-08-18 13:03 ` Wang Zhaolong [this message]
2025-08-18 21:41 ` Steve French
2025-08-19 2:48 ` Wang Zhaolong
2025-08-19 5:27 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89a2023c-e383-4780-83e3-ba8f9e44c015@huaweicloud.com \
--to=wangzhaolong@huaweicloud.com \
--cc=bharathsm@microsoft.com \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®