From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 696683AA1A8 for ; Wed, 14 Jan 2026 21:59:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768427969; cv=none; b=Ld7ok2uusnNPV3KuEs3yUZOF7iyMF4hNqAoXfyLagAI6m9Vi4tWinAG3/vVKTXnLTYqmZ43wwGLgNgXHYomRARm83zxIxMXPfoKTK5ikLwzhPjWCnuoSnKPFYIqBDNHQyyViQngdYHvXQWWtmMDIsv6OlafS1SJwJRu8KcRK8M4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768427969; c=relaxed/simple; bh=frBlYVR2Ft6P+ZhttGDwMdzZh206l/teIaCIbXQvM9A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eNDGlYm9n9d5OLVzw9weXWzl+wxeebQKsx+S2MXqxg+NcKanZAFgIi0yZzCa6+PbopQsO6ZUwD69E85HLsEZ84IV2CAQbs6mz0XLLtbHP7KqfwYIwzxA39hdujEDaND/r5AVtk1sGl7A8HfNuB7VXFo9ddL06p4KH7rmlUEgHNo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BV9uvlqZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=htaQMKA8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BV9uvlqZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="htaQMKA8" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60EIkMjO3279831 for ; Wed, 14 Jan 2026 21:59:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OpvEH4+21FwdP09LJL6iR3hKr4clZnGQYSImAni7YoQ=; b=BV9uvlqZgkHRVeEL 1LBpMOnJMGEzujNzwizNp/D3litzDgCUwdmD0WSGlrKcuSjaOvVjVJhTizReRffh YY4qXBUYWBq4WhHBqxSgm0BLvYP39+qvcVYMIhHxpm56+CD9FqPwSVZkh0PzJyWv wmaAaZuFoWlQcYTVUnH8iqgT4EOtkYExvhHGRpKUBQ0mcJAb7webWIff7RfWzGxp 6qLZow7mux2KgXyBjhIDtvGIStp5LM1jKIzrCQmFD8YENnD4ZUohKmDU/DTd4y41 WG/4zXcpxWowZQ3vAeG5trLNaokToDG099Yun5yF93H5AzfLUf+pvlTVkXgEChQS eMzVrQ== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bp9x8t454-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 21:59:13 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2ae32686ed0so2230828eec.0 for ; Wed, 14 Jan 2026 13:59:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768427952; x=1769032752; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OpvEH4+21FwdP09LJL6iR3hKr4clZnGQYSImAni7YoQ=; b=htaQMKA86YpcwJ0n/jSPAgWoFHfSUZuCpLwKX5qoKEwRetdQTXV81yAoD37VVw3vzW jN2fULfPhYLPyWTm4HWVpy3yKwehbiUIWdGtkEIzoaQLL399TYfxumc+tI7WKZHXyrlb 8fYeO01icmEdW7FHHX4m5nNM3O+u6QRMiXVEwezz5dLZCclohwnlduPAYol1ulMCPtRy WHG8rjHvrJ9JFYp9WXZcRLD3DvW27diPy2L432OcQHOobecpxLU6wwROqI/wLiqZZLQC y2Is94r217LX4q0u4N+QQuhLUVyhdIAQojm5U7oFkcYuEZx9iRnqOlgE80bKybNlIDCW 7zFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768427952; x=1769032752; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OpvEH4+21FwdP09LJL6iR3hKr4clZnGQYSImAni7YoQ=; b=iyy8NYHKOYEAt7jBR+dUO4OZlfsPM4Id5KkwFwcnxT3Jp9zqJyXY/UFEtaSJ5k5A0d cWg52JyGrVQbG01eBpVjcJQulnrIUPN33NnvarQnuiyrB1DQv0MLf0Unk4Jl4jdHusdp ttLpvVOh9uKxed40PYtoW5lXAZojDQWEMzlcoovSDcyYF7blmknKSJZbkw0rqPH8oJhR HXSxRD7vSf9Uc8LNo3S//Cpwv4keuzwt63TJPPPwtlnUvAq7Y3wF0e73DSJRuYXAyj7L OoZ8mUGd+4OobhMK/1H5/gECp5KcTNL6xGvUjpspUEHN+StpsppGn8Tb0SL1CCUNVHJ9 paSQ== X-Forwarded-Encrypted: i=1; AJvYcCWq/sgb+2NU+iDAhY/uGg2Yuil/BhL/dn1Y60dBB30Rzduv+oAuZgwtuslDdKnOxYGRmXjoMenrBakdeSw=@vger.kernel.org X-Gm-Message-State: AOJu0YxvGovVthYUre/pO0xmozT8/vUVKqzEDNrd90/aYQn44wJSzwsU WUcJ5CTP8B6JjFRi/d+9gY4XLYu0GlkYKPr6J3MIYVG5L8hKEnuoVwSVmWK0NL3cXFnRzMXzFcC 7CTkFmeP3gjEG5aRPgEJVw2WlajAztf8YDueLRYLS9KJNF9f/o4mF08HFObFc9p/DWJE= X-Gm-Gg: AY/fxX7LcIwhUjo9P862KMUu6YVTLuoGp4Bor7n6Nyi2XCVodIo0CGTF+k8+OHRtu+o upGjpsVGup1UfYK9hazIj92iurYknyFbneb94XD/g6E1YW5ctf5fOW0tQ7i0YvEBGfAQPgCtKed 1UvXFkhHjFP5fOX8oOpXJ+FGMtlxxT0Uja4H3elfHiDzihSw7laRKg1m6tdpbQ6MtTcw26JBrux uPXAlLG0hZgvx8+H85M6M123d1nWdlAmbCYgmI93Fcb3miDs5yTHvP9q9S5gYPXY1fki+XDGXN0 i5xfJ65F4c0iLPB/LVJObs1KPjwCV9vhsJPCAQrQejkM/EhAW6TQYOszKue/dfCBBo7nUbcybDR evBf4rfSkO6HH7AkLqZnnu1xE9FFAwBODnK2yleM5hjwufbLkiAsUh0J82ZqFifSAqkZ6ladNCy CF X-Received: by 2002:a05:693c:2c13:b0:2b0:59da:f798 with SMTP id 5a478bee46e88-2b487068cccmr5445132eec.21.1768427952429; Wed, 14 Jan 2026 13:59:12 -0800 (PST) X-Received: by 2002:a05:693c:2c13:b0:2b0:59da:f798 with SMTP id 5a478bee46e88-2b487068cccmr5445073eec.21.1768427951297; Wed, 14 Jan 2026 13:59:11 -0800 (PST) Received: from [192.168.1.3] (c-24-130-122-79.hsd1.ca.comcast.net. [24.130.122.79]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b17078dd78sm20133476eec.19.2026.01.14.13.59.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jan 2026 13:59:10 -0800 (PST) Message-ID: <89a61ef1-3e83-4303-ba04-cf5c5a4aae56@oss.qualcomm.com> Date: Wed, 14 Jan 2026 13:59:09 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] wifi: ath11k: move .max_tx_ring to struct ath11k_hw_hal_params To: "Alex G." , Vasanthakumar Thiagarajan , jjohnson@kernel.org, ath11k@lists.infradead.org Cc: baochen.qiang@oss.qualcomm.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251228151408.2116108-1-mr.nuke.me@gmail.com> <56c6471b-c878-4afd-8e8e-d56266ca9c64@oss.qualcomm.com> <5896283.e9J7NaK4W3@nukework.gtech> From: Jeff Johnson Content-Language: en-US In-Reply-To: <5896283.e9J7NaK4W3@nukework.gtech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: XYXzx506NI5wyLr3KwDUebc0rofAjAhz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDE4MCBTYWx0ZWRfX0fsrsEru21f8 IQFR8adsqYnrU2tOCaCj8MNkVS/7/PwgMK6HKn1MPh2GfDkw4O6yKCNXZ0ObIbbGUChnBPTPmwd A+QFgBVbFn1h4d2HIKVzx20TU80yWCt8vQCQPPhV+iXuEbNOrJHqMX3lwAHDW9Hfol4pFCe0q7E 4d/KBIYbM+QgvcGaDYOAH3fxXsfTyCfQfvDTnL8EwK3nwrRi6th2+r4aMss4OW7p4KRm0Vo+PpV 2f6XwMG1khqOX8ZNmsUqCmbNSsq3+l1EuspEbtChs2ts4EOdTYE3a4GyJuu/EsCv4nVRKBBTZVQ NOHGp2ZQ3fV3Sq8J2KqBjmV9aZgCqHTHHLz4bQPWTPmBiX7hMbrGR6RuO3TU2taYHeekXHvGDeQ TZjq9dvvQeW5Ol32l5I8WyEta7NqSB0tD4i2nBwxw7k0U6g2cgn5Lef4q6PhhIwzvcHZTYXcCvu mC19pwaANP9DJh5A1Dg== X-Authority-Analysis: v=2.4 cv=HY4ZjyE8 c=1 sm=1 tr=0 ts=696811b1 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=Tg7Z00WN3eLgNEO9NLUKUQ==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=azILXIGDsH6i2WhDGicA:9 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-ORIG-GUID: XYXzx506NI5wyLr3KwDUebc0rofAjAhz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_06,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 suspectscore=0 clxscore=1015 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140180 On 1/14/2026 1:29 PM, Alex G. wrote: > On Wednesday, January 14, 2026 11:24:19 AM CST Jeff Johnson wrote: >> On 1/12/2026 11:00 PM, Vasanthakumar Thiagarajan wrote: >>> On 12/28/2025 8:44 PM, Alexandru Gagniuc wrote: >>>> ".max_tx_ring" is an upper bounds to indexing ".tcl2wbm_rbm_map". It >>>> is initialized in, core.c, a different file than the array. This >>>> spaghetti-like relation is fragile and not obvious. Accidentally >>>> setting ".max_tx_ring" too high leads to a hard to track out-of- >>>> bounds access and memory corruption. >>>> >>>> There is a small ambiguity on the meaning of "max_tx_ring": >>>> - The highest ring, max=3 implies there are 4 rings (0, 1, 2, 3) >>>> - The highest number to use for array indexing (there are 3 rings) >>>> >>>> Clarify this dependency by moving ".max_tx_ring" adjacent to the array >>>> ".tcl2wbm_rbm_map", and name it "num_tx_rings". Use ARRAY_SIZE() >>>> instead of #defines to initialize the length field. >>>> >>>> The ath11k_hw_hal_params_qca6390 uses fewer num_tx_rings than its map, >>>> so use a constant to express the correct value. Add a static_assert() >>>> to fail compilation if the constant is accidentally set too high. >>> >>> Text related to static_assert to be removed accordingly. >> > Hi Jeff, > >> I removed the last sentence in 'pending', please check: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pendin >> g&id=26bb149b5e011b0f73f7b74421589cbd38e3304b > > Re-reading the commit message, I think it makes sense to also remove the > sentence "The ath11k_hw_hal_params_qca6390 uses fewer num_tx_rings than its > map, so use a constant to express the correct value.". Do you think it's worth > submitting a v4 with this minor change? > > Alex No need to submit a v4. I can make that change in 'pending' /jeff